Compare commits

..
Author SHA1 Message Date
Antigravity AIandClaude Sonnet 4.6 d5acae2a1c fix: add 20s safety boot fallback for environments where globe never initialises
On headless Linux CI (ubuntu-latest), Firefox uses Mesa software rendering
which can prevent CesiumJS from mounting its WebGL context. When that
happens, the `globeReady` DataBus event never fires, `startBoot()` is
never called, and `data-testid="app-ready"` never appears — causing every
Playwright test to time out at 45 s.

The fix guards `boot.startBoot()` behind a `bootStarted` flag so only the
first caller wins, then adds a 20 s `setTimeout` safety fallback in
AppShell. Normal flow (globe loads) fires the boot immediately via
`globeReady`; the safety timer is cleared. Degraded flow (WebGL absent)
still reaches the `app-ready` state after ~23.5 s (20 s + 3.5 s
animation), well within the 45 s test timeout.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-20 12:21:11 +12:00
Antigravity AIandClaude Sonnet 4.6 56e61253a5 fix: set NO_AT_BRIDGE=1 for firefox in CI to prevent AT-SPI hang
The firefoxUserPrefs approach alone is insufficient — Firefox on Linux
loads the AT-SPI accessibility bridge at the GTK level before user prefs
apply. Setting NO_AT_BRIDGE=1 cuts the connection at the OS/GTK layer,
which is what actually prevents the ~20 min hang on ubuntu-latest runners.
Scoped to the firefox matrix leg only; chromium and webkit are unaffected.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-20 11:44:07 +12:00
Antigravity AIandClaude Sonnet 4.6 718f089c9f fix: disable Firefox MSAA/AT-SPI accessibility on CI to prevent hangs
Adds `accessibility.force_disabled: 1` to Firefox's user prefs in the
Playwright config. On Linux CI (GitHub Actions / ubuntu-latest) Firefox
attempts to connect to the AT-SPI accessibility bus, which causes the
browser to hang for ~20 minutes before timing out. Disabling the
accessibility layer at the browser level eliminates the hang without
affecting test coverage.

Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
2026-05-20 11:18:13 +12:00
Antigravity AI 3210b3bd15 chore: convert .claude from text file to git symlink pointing to .agents 2026-05-20 10:52:00 +12:00
Antigravity AI 9fad051f75 Merge branch 'main' of https://github.com/silvertakana/worldwideview 2026-05-19 23:25:23 +12:00
Antigravity AI a818822023 chore: add CLAUDE.md symlink pointing to AGENTS.md for Claude Code 2026-05-19 23:24:59 +12:00
Silvertakana 012184af30 Fix: Plugin fetch error (#159)
* fix(plugin-manager): downgrade non-fatal 'Failed to fetch' errors to warn, remove polling re-throw

* fix(codeql): resolve format string vulnerability in console logging

* fix(ci): restore playwright dependencies and configure tsconfig properly

* fix(plugins): ensure plugin fetch uses HTTP scheme instead of WSS
2026-05-18 11:10:04 +12:00
SilvertakanaandCopilot Autofix powered by AI c1f7ffb5b4 Refactor: High quality standards (#156)
* chore(merge): resolve conflicts, fix mockWs error, and apply refactor standards

* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* fix(ci): Stabilize github actions and resolve test failures

- fix(tests): update WsClient mock to use standard function for Vitest constructor compatibility

- fix(db): correct PrismaClient import path to use generated output directory

- fix(e2e): add predev database boot step to playwright CI workflow

- chore: sync pnpm-lock.yaml after merge conflict resolution

* refactor(plugins): decouple GeoJSON plugin and implement data bus lifecycle

- feat(sdk): [Minor] Added dynamicPluginCreate, dynamicPluginRemove, and pluginUnregistered to DataBusEvents.

- feat(core): [Minor] Implemented unregisterPlugin in PluginManager.ts for automated IndexedDB caching cleanup and polling teardown.

- feat(core): [Minor] Added removeLayer to layersSlice.ts to support safe removal of plugin states.

- refactor(plugins): [Patch] Refactored useGeoJsonImport.ts and ImportedLayerList.tsx to decouple from direct manager imports, utilizing DataBus for lifecycle events.

- refactor(core): [Patch] Added pluginUnregistered listener to DataBusSubscriber.tsx to handle state and cache cleanup synchronously via event.

* fix(types): resolve PluginManager type errors

* refactor(core): decouple PluginManager and fix rendering invariants

- refactor(core): Replace Zustand mutations in PluginManager with DataBus events (Patch)
- refactor(sdk): Add layerLoadingChanged, pluginError, pluginUnregistered to DataBusEvents (Patch)
- refactor(ui): Subscribe to new DataBus events in DataBusSubscriber (Patch)
- fix(plugins): Remove size from BaseAviationPlugin to fix model rendering clipping (Patch)
- fix(plugins): Migrate BaseIncidentPlugin from size to iconScale to fix billboard clipping (Patch)

* chore: resolve lockfile conflict

* fix: restore BottomPanelManager in AppShell and fix vitest config

* fix(layout): restore bottom panel positioning and transition styling

This commit corrects the missing bottom panel issue by resolving CSS aggregation errors and fixing transition logic. The version is bumped to 2.15.5.

* refactor(core): harden typescript and fix linting violations

This commit addresses the remaining any types and linting errors across the core engine.

* fix(eslint): resolve react-hook immutability and cascading render violations

---------

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2026-05-18 11:08:00 +12:00
Silvertakanaandsnyk-bot 6816081644 Fix: Snyk vulnerability fix (#158)
* fix: package.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-WS-16722635

* fix: update pnpm-lock.yaml for ws dependency bump and bump version to 2.15.11

---------

Co-authored-by: snyk-bot <[email protected]>
2026-05-18 11:06:39 +12:00
Antigravity AI 433004598d Merge branch 'fix/lint-cleanups'
# Conflicts:
#	eslint.config.mjs
#	package.json
2026-05-17 22:08:13 +12:00
Antigravity AI 02d8355a83 feat: add inverted app icon and update lockfile dependencies 2026-05-17 22:05:48 +12:00
Silvertakana 89010b2425 feat(ui): Bottom Panel System and E2E Testing (#147)
* test(bottom-panel): add e2e resize testing and data-testid

* test(e2e): fix playwright drag events skipping React state
2026-05-17 20:14:18 +12:00
Antigravity AI 0ff1d23e4a chore(lint): clean up legacy linting errors and hallucinated rules 2026-05-17 20:04:13 +12:00
Silvertakanaandsnyk-bot fd29865e7a [Snyk] Security upgrade ws from 8.20.0 to 8.20.1 (#151)
* fix: package.json to reduce vulnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-WS-16722635

* fix: update pnpm-lock.yaml for ws dependency bump and bump version to 2.15.11

---------

Co-authored-by: snyk-bot <[email protected]>
2026-05-17 19:54:03 +12:00
Silvertakana 42564b537f ci(playwright): Add multi-browser test matrix (#150)
* ci(playwright): Add multi-browser test matrix (Patch)

* fix(cesium): Disable MSAA in Firefox to prevent readPixels crash (Patch)
2026-05-17 19:14:54 +12:00
14 changed files with 1063 additions and 20 deletions

No files matched your search

+6
View File
@@ -38,3 +38,9 @@ E2E tests require an authenticated user to access core application features. We
> [!WARNING]
> If you encounter flaky tests or `ECONNREFUSED` errors during Playwright runs, check if the local Next.js dev server or the Docker engine stack is competing for ports (e.g., port 5432 or 3000). Ensure `pnpm run dev:backends` is running and stable before launching the test suite.
## 6. Execution Environment & Tooling Limitations
The development environment operates on **Windows PowerShell**. Agents MUST adhere to the following strict execution rules when running commands or interacting with the testing infrastructure:
- **No Double Ampersands (`&&`)**: Standard Windows PowerShell (prior to v7) does not support the `&&` operator. Use the semicolon (`;`) to chain commands, or rely on `pnpm` package.json scripts which manage cross-platform execution properly.
- **Avoid Non-existent Database CLI Commands**: Do not attempt to use raw `pg` or `psql` commands unless explicitly verified to exist in the path. Instead, use Prisma (`npx prisma studio`, `npx prisma migrate`) or Docker executions (`docker exec -it wwv-db psql ...`) for database interactions.
- **Creating Test Plugins**: You will repeatedly need to create mock test plugins for verifying different platform features (e.g. bottom-panel resizing, new UI widgets). When doing so, you MUST review this `e2e-testing.md` file to ensure compliance with the `PluginManager` strict interface rules (implementing `getPollingInterval`, `fetch`, and `renderEntity`).
-1
View File
@@ -1 +0,0 @@
.agents
Symlink
+1
View File
@@ -0,0 +1 @@
.agents
+5
View File
@@ -41,6 +41,11 @@ jobs:
pnpm run predev
- name: Run Playwright tests
env:
# Prevent Firefox from loading the AT-SPI/MSAA accessibility bridge on
# Linux CI — without this, Firefox hangs for ~20 min waiting for a bus
# that doesn't exist on ubuntu-latest runners.
NO_AT_BRIDGE: ${{ matrix.browser == 'firefox' && '1' || '0' }}
run: pnpm test:e2e --project=${{ matrix.browser }}
- uses: actions/upload-artifact@v4
Symlink
+1
View File
@@ -0,0 +1 @@
AGENTS.md
+3 -3
View File
@@ -35,10 +35,10 @@ const config = [
// Pre-existing — flagged in the original code review (#96):
"@typescript-eslint/no-explicit-any": "warn",
"no-console": "warn",
"no-console": "off",
// React 19 hook-purity rules from eslint-plugin-react-hooks 7+:
// (These were previously hallucinated or require extra plugins)
// Misc one-offs across the codebase:
"@typescript-eslint/ban-ts-comment": "warn",
"@next/next/no-assign-module-variable": "warn",
-2
View File
@@ -93,6 +93,4 @@ const nextConfig: NextConfig = {
},
};
import { withSentryConfig } from "@sentry/nextjs";
export default nextConfig;
+3 -3
View File
@@ -1,7 +1,7 @@
{
"name": "worldwideview",
"version": "2.15.10",
"private": true,
"version": "2.15.16",
"private": true,
"type": "module",
"packageManager": "[email protected]",
"scripts": {
@@ -56,7 +56,7 @@
"stripe": "^22.1.1",
"tslib": "^2.8.1",
"undici": "^8.2.0",
"ws": "^8.14.2",
"ws": "^8.20.1",
"zod": "^4.4.3",
"zustand": "^5.0.13"
},
+2 -1
View File
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
import { Command } from 'commander';
import { execSync } from 'child_process';
import path from 'path';
@@ -66,7 +67,7 @@ export const publishCommand = new Command('publish')
try {
const whoami = execSync('npm whoami', { stdio: 'pipe' }).toString().trim();
targetOrg = whoami;
} catch (e) {
} catch (_e) {
// Not logged in or errored, ignore
}
+8 -2
View File
@@ -41,9 +41,15 @@ export default defineConfig({
},
{
name: 'firefox',
use: {
use: {
...devices['Desktop Firefox'],
storageState: 'playwright/.auth/user.json'
storageState: 'playwright/.auth/user.json',
launchOptions: {
firefoxUserPrefs: {
// Disable MSAA/AT-SPI accessibility layer — causes hangs on Linux CI
'accessibility.force_disabled': 1,
},
},
},
},
{
+962 -5
View File
File diff suppressed because it is too large. Load diff
Binary file not shown.

After

Width:  |  Height:  |  Size: 9.8 KiB

+16 -4
View File
@@ -129,15 +129,27 @@ export function AppShell() {
console.log("[AppShell] Platform Ready. Waiting for globe tiles...");
};
// Start boot sequence when globe tiles are loaded
const unsubGlobe = dataBus.on("globeReady", () => {
console.log("[AppShell] Globe ready — starting boot sequence.");
// Guard so boot only starts once regardless of which trigger fires first.
let bootStarted = false;
const startBootOnce = (reason: string) => {
if (bootStarted) return;
bootStarted = true;
console.log(`[AppShell] Starting boot sequence (${reason}).`);
boot.startBoot();
});
};
// Primary trigger: globe signals it is ready.
const unsubGlobe = dataBus.on("globeReady", () => startBootOnce("globeReady"));
// Safety fallback: if the globe never initialises (e.g. WebGL unavailable
// in headless CI environments), force the boot sequence after 20 s so the
// app still reaches the "ready" state and tests are not left hanging.
const safetyTimer = setTimeout(() => startBootOnce("safety-timeout"), 20_000);
startPlatform();
return () => {
clearTimeout(safetyTimer);
unsubGlobe();
boot.cleanup();
pluginManager.destroy();
@@ -179,6 +179,7 @@ export function BottomPanelManager() {
<>
<div
className="bottom-panel-resize-handle"
data-testid="bottom-panel-resize-handle"
ref={resizeRef}
onMouseDown={() => setIsDragging(true)}
>
+56
View File
@@ -74,4 +74,60 @@ test.describe('Bottom Panel System', () => {
// Verify the content is no longer visible
await expect(mockContent).not.toBeVisible();
});
test('verifies the bottom panel can be resized via the drag handle', async ({ page }) => {
const panelTab = page.locator('.dock-btn', { hasText: 'E2E Bottom Panel Mock' });
await expect(panelTab).toBeVisible();
await panelTab.click();
const bottomPanel = page.locator('.bottom-panel.open');
await expect(bottomPanel).toBeVisible();
// Get initial height
const initialBox = await bottomPanel.boundingBox();
expect(initialBox).not.toBeNull();
// Find the drag handle
const dragHandle = page.locator('[data-testid="bottom-panel-resize-handle"]');
await expect(dragHandle).toBeVisible();
const handleBox = await dragHandle.boundingBox();
expect(handleBox).not.toBeNull();
// Perform drag UP
await page.mouse.move(handleBox!.x + handleBox!.width / 2, handleBox!.y + handleBox!.height / 2);
await page.mouse.down();
await page.waitForTimeout(100); // allow React to process mousedown and attach mousemove listener
// Drag up by 100 pixels with steps to simulate smooth motion and trigger isDragging styles
await page.mouse.move(handleBox!.x + handleBox!.width / 2, handleBox!.y - 100, { steps: 10 });
await page.waitForTimeout(100); // allow resize state to update
await page.mouse.up();
await page.waitForTimeout(400); // wait for CSS transition to settle since opacity/height transitions apply
// Check new height
const finalBox = await bottomPanel.boundingBox();
expect(finalBox).not.toBeNull();
expect(finalBox!.height).toBeGreaterThan(initialBox!.height + 50);
// Get updated handle position for second drag
const newHandleBox = await dragHandle.boundingBox();
expect(newHandleBox).not.toBeNull();
// Drag DOWN
await page.mouse.move(newHandleBox!.x + newHandleBox!.width / 2, newHandleBox!.y + newHandleBox!.height / 2);
await page.mouse.down();
await page.waitForTimeout(100);
await page.mouse.move(newHandleBox!.x + newHandleBox!.width / 2, newHandleBox!.y + 100, { steps: 10 });
await page.waitForTimeout(100);
await page.mouse.up();
await page.waitForTimeout(400);
// Check height decreased
const shrunkBox = await bottomPanel.boundingBox();
expect(shrunkBox).not.toBeNull();
expect(shrunkBox!.height).toBeLessThan(finalBox!.height - 50);
});
});