Brad Fitzpatrick
383d86df5f
paths: remove some debug logging I left in
2020-03-03 11:45:49 -08:00
Brad Fitzpatrick
65e7c58aa4
cmd/tailscale, cmd/tailscaled, paths: add paths package for default paths
...
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-03-03 09:36:18 -08:00
Brad Fitzpatrick
06092a3af3
ipn/ipnserver: document potential race, start on test for it
2020-03-03 09:15:11 -08:00
Brad Fitzpatrick
ef1f967ec0
ipn: remove an unnecessary named parameter in doc
2020-03-03 08:05:11 -08:00
Brad Fitzpatrick
844d991baf
netcheck: add Report.Clone, return cloned report to avoid races on late replies
2020-03-02 15:02:34 -08:00
Brad Fitzpatrick
657f9593ae
Reduce some logspam.
2020-03-02 14:55:12 -08:00
David Crawshaw
61529ac459
controlclient, tailcfg: deliver DERP addresses in a separate field
...
We still include them directly in the controlclient network map
just where we have been. Client plumbing we can do later.
Signed-off-by: David Crawshaw <[email protected] >
2020-03-02 17:16:17 -05:00
David Anderson
ca11e3804b
Add a using section that points to pkgs.tailscale.com.
2020-03-02 13:52:51 -08:00
Brad Fitzpatrick
4675c70464
wgengine/magicsock: check STUN regularly
2020-03-02 12:37:52 -08:00
Brad Fitzpatrick
7172f3dbf4
version: add IsMobile func
...
And use it control/controlclient.
2020-03-02 12:37:28 -08:00
Brad Fitzpatrick
11489a6e67
go.sum: add lines
2020-03-02 11:07:42 -08:00
Brad Fitzpatrick
bc7bc43fb8
magicsock, interfaces: move some code from magicsock to interfaces
2020-03-02 10:38:44 -08:00
Brad Fitzpatrick
af7a01d6f0
wgengine/magicsock: drop donec channel, rename epUpdateCtx to serve its purpose
2020-03-02 09:31:25 -08:00
Brad Fitzpatrick
a399ef3dc7
cmd/derper: appease staticcheck
2020-03-02 08:59:50 -08:00
Brad Fitzpatrick
051b6ef141
cmd/derper: accept more LetsEncrypt hostnames without explicit config
2020-03-02 08:55:44 -08:00
David Crawshaw
cc4afa775f
magicsock: rate limit send error log messages
...
The x/time/rate dependency adds 24kb to tailscaled binary size.
Signed-off-by: David Crawshaw <[email protected] >
2020-03-02 08:10:06 -05:00
David Anderson
9cdaeac00a
go.mod: update wireguard-go version.
...
I accidentally crushed one of crawshaw's patches, fixing this now.
2020-03-01 14:04:10 -08:00
David Anderson
92bae83cc1
go.mod: update wireguard-go commit.
...
Signed-Off-By: David Anderson <[email protected] >
2020-03-01 13:58:09 -08:00
David Crawshaw
719c974c38
go.mod: update wireguard-go version
...
Signed-off-by: David Crawshaw <[email protected] >
2020-03-01 12:17:10 -05:00
David Crawshaw
0752c77dc2
magicsock: keep DERP magic IPs out of the address map
...
Signed-off-by: David Crawshaw <[email protected] >
2020-03-01 07:29:48 -05:00
David Crawshaw
c6550135d5
magicsock: remove the index from indexedAddrs
...
The value predates the introduction of AddrSet which replaces
the index by tracking curAddr directly.
Signed-off-by: David Crawshaw <[email protected] >
2020-03-01 07:29:48 -05:00
David Anderson
18fb98792b
go.mod: update wireguard-go version.
...
Signed-off-by: David Anderson <[email protected] >
2020-03-01 01:16:07 -08:00
David Anderson
061315acb4
go.mod: update version of wireguard-go.
...
Signed-Off-By: David Anderson <[email protected] >
2020-03-01 00:50:39 -08:00
David Crawshaw
1dbd1babc9
go.mod: use latest wireguard-go version
...
Signed-off-by: David Crawshaw <[email protected] >
2020-02-29 16:08:28 -05:00
David Crawshaw
d5050c37a5
go.mod: use latest wireguard-go version
2020-02-29 11:26:44 -05:00
David Crawshaw
d417be6a4b
controlclinet: clone filter.MatchAllowAll
...
This avoids a non-obvious data race, where the JSON decoder ends
up creating do-nothing writes into global variables.
==================
WARNING: DATA RACE
Write at 0x0000011e1860 by goroutine 201:
tailscale.com/wgengine/packet.(*IP).UnmarshalJSON()
/home/crawshaw/repo/corp/oss/wgengine/packet/packet.go:83 +0x2d9
encoding/json.(*decodeState).literalStore()
/home/crawshaw/go/go/src/encoding/json/decode.go:877 +0x445e
...
encoding/json.Unmarshal()
/home/crawshaw/go/go/src/encoding/json/decode.go:107 +0x1de
tailscale.com/control/controlclient.(*Direct).decodeMsg()
/home/crawshaw/repo/corp/oss/control/controlclient/direct.go:615 +0x1ab
tailscale.com/control/controlclient.(*Direct).PollNetMap()
/home/crawshaw/repo/corp/oss/control/controlclient/direct.go:525 +0x1053
tailscale.com/control/controlclient.(*Client).mapRoutine()
/home/crawshaw/repo/corp/oss/control/controlclient/auto.go:428 +0x3a6
Previous read at 0x0000011e1860 by goroutine 86:
tailscale.com/wgengine/filter.matchIPWithoutPorts()
/home/crawshaw/repo/corp/oss/wgengine/filter/match.go:108 +0x91
tailscale.com/wgengine/filter.(*Filter).runIn()
/home/crawshaw/repo/corp/oss/wgengine/filter/filter.go:147 +0x3c6
tailscale.com/wgengine/filter.(*Filter).RunIn()
/home/crawshaw/repo/corp/oss/wgengine/filter/filter.go:127 +0xb0
tailscale.com/wgengine.(*userspaceEngine).SetFilter.func1()
/home/crawshaw/repo/corp/oss/wgengine/userspace.go:390 +0xfc
github.com/tailscale/wireguard-go/device.(*Device).RoutineDecryption()
/home/crawshaw/repo/corp/wireguard-go/device/receive.go:295 +0xa1f
For #112
Signed-off-by: David Crawshaw <[email protected] >
2020-02-28 22:33:06 -05:00
David Crawshaw
8aa2090919
go.mod: roll forward wireguard-go
...
Signed-off-by: David Crawshaw <[email protected] >
2020-02-28 22:12:05 -05:00
David Crawshaw
d133339216
ipn: always guard LocalBackend.prefs with mu
...
Signed-off-by: David Crawshaw <[email protected] >
2020-02-28 21:54:22 -05:00
Brad Fitzpatrick
bcf3719b9e
netcheck: add hairpinning detection
...
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 14:26:51 -08:00
Brad Fitzpatrick
1abf2da392
wgengine/magicsock: reset favorite address on handshakes
...
Updates #92 (not a complete fix; could be better/faster?)
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 17:23:09 -05:00
Brad Fitzpatrick
517a91de75
derp/derphttp: fix reconnect behavior
...
I broke it in today's 752146a70f .
Added some comments to prevent recurrences.
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 13:39:48 -08:00
Brad Fitzpatrick
d59d0576af
derp: don't log on all dropped packets; super spammy
...
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 13:33:47 -08:00
Brad Fitzpatrick
38acccad09
derp: remove some debug noise I left in
...
:(
2020-02-28 13:20:56 -08:00
Brad Fitzpatrick
752146a70f
derp: clean up derphttp client code, use contexts
...
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 13:18:59 -08:00
David Crawshaw
cdc10b74f1
ipn: always guard LocalBackend.endpoints with mu
...
For #112
Signed-off-by: David Crawshaw <[email protected] >
2020-02-28 15:13:01 -05:00
David Crawshaw
3425d8d84f
ipn: always guard LocalBackend.engineStatus with mu
...
Signed-off-by: David Crawshaw <[email protected] >
2020-02-28 14:58:52 -05:00
David Crawshaw
e7cdc11654
ipn: always guard LocalBackend.netMapCache with mu
...
Signed-off-by: David Crawshaw <[email protected] >
2020-02-28 14:39:36 -05:00
Brad Fitzpatrick
67ede8d6d2
wgengine, magicsock: fix SetPrivateKey data race
...
Updates #112
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 11:15:07 -08:00
Brad Fitzpatrick
4cd3e82bbd
go.mod: bump wireguard-go
...
Updates #112
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 11:15:07 -08:00
Brad Fitzpatrick
a6c695ba6b
types/key: add IsZero methods
...
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 11:15:07 -08:00
michael wilson
3878f0a67a
interfaces: recognize utun as a possible Tailscale interface name prefix
...
Signed-off-by: Michael Wilson <[email protected] >
2020-02-28 10:16:09 -08:00
Brad Fitzpatrick
07f0fd0fdc
version: add a manual date as version for now
...
Maybe we'll auto-bump this with a bot over time.
See golang/go#37475 & golang/go#29814
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 09:44:34 -08:00
Brad Fitzpatrick
f3c0ea23d9
netcheck, stunner: reduce log spam
...
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 09:40:25 -08:00
Brad Fitzpatrick
19b54d0ae7
wgengine: fix a data race on StatusCallback
...
Updates tailscale/tailscale#112
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-28 09:32:06 -08:00
David Crawshaw
c576a57067
wgengine: avoid holding any locks during HandshakeDone
...
Because wgLock is held while some wireguard-go methods run,
trying to hold wgLock during HandshakeDone potentially creates
lock cycles between wgengine and internals of wireguard-go.
Arguably wireguard-go should call HandshakeDone in a new goroutine,
but until its API promises that, don't make any assumptions here.
Maybe for #110 .
Signed-off-by: David Crawshaw <[email protected] >
2020-02-28 06:32:38 -05:00
David Crawshaw
06bf0d980e
go.mod: bump wireguard-go version
...
For #110
2020-02-28 06:21:07 -05:00
David Anderson
78654ee1bd
cmd/tailscale: switch to an ffcli based CLI.
...
Two commands for now, `up` and `netcheck`. The commands and the flags they take
will change a bunch in the future, but this is good enough to launch on parity
with relaynode.
Signed-Off-By: David Anderson <[email protected] >
2020-02-28 00:15:25 -08:00
David Crawshaw
4e3ff4b63b
controlclient: allow prefixed endpoints in tests
2020-02-27 16:52:14 -05:00
Brad Fitzpatrick
25797c8c2a
all: rename deep "Copy" methods to conventional Go name "Clone"
2020-02-27 12:20:29 -08:00
Brad Fitzpatrick
14559340ee
Start of netcheck package & including network state in Hostinfo.
...
* adds new packet "netcheck" to do the checking of UDP, IPv6, and
nearest DERP server, and the Report type for all that (and more
in the future, probably pulling in danderson's natprobe)
* new tailcfg.NetInfo type
* cmd/tailscale netcheck subcommand (tentative name, likely to
change/move) to print out the netcheck.Report.
Signed-off-by: Brad Fitzpatrick <[email protected] >
2020-02-27 11:05:27 -08:00