* Fix history items losing entry CustomData
Entry::beginUpdate() copied attributes, attachments and auto-type
associations into the temporary history item but not CustomData, unlike
clone() and copyDataFrom(). As a result every history item was created
with empty CustomData, and restoring an entry from history wiped its
CustomData, losing KeePassXC-Browser settings and other client metadata.
Copy CustomData into the history item like the other components and add
TestEntry::testHistoryItemCustomData covering creation and restore.
Co-Authored-By: Claude Fable 5 <[email protected]>
* Removed redundant code to ensure consistency
---------
Co-authored-by: Claude Fable 5 <[email protected]>
Co-authored-by: Jonathan White <[email protected]>
CSV files exported by KeePassXC always use English canonical headers.
When the UI locale translated field labels, only untranslated names
(URL, TOTP) matched. Also match the English export headers so
re-import works regardless of UI language.
Fixes#13523
* refactor(LineReader): Make use of the LineReader class in a much simpler way
The LineReader is made a concrete class whose declaration is independent of the readline library. Only its implementation depends on the presence or absence of the readline library. The LineReader code is embedded in a new library : line_reader, to make the cli library independant of the USE_READLINE definition.
* refactor(readline): better FindReadline module
The readline library is now searched with pkg-config first. If pkg-config is not installed, the search is manual. In both cases, the Readline::readline target is created, embedding transitive requirements.
FindReadline module was written with the help of Le Chat AI (https://chat.mistral.ai/chat)
---------
Co-authored-by: Jonathan White <[email protected]>
UrlTools does not need to inherit from QObject or even be a class.
It is a collection of regular functions.
refactor(urltools): Make regular expression static
domainHasIllegalCharacters() constructs a QRegularExpression on every call.
Since the pattern is constant, make it static const QRegularExpression
to avoid repeated regex compilation in hot paths
(e.g., domain validation during browsing/passkey operations).
refactor(urltools): Remove the unnecessary convertVariantToUrl function
format code
refactor(urltools): Include What You Use
refactor(urltools): Use URL_WILDCARD directly in implementation
refactor(urltools): some more inprovements
- code format
- use pure Qt functions for the string handling
- use chop to remove the last character of a QString
- make another QRegularExpression static const
beginResetModel/endResetModel in a QStandardItemModel doesn't make sense
Fixes following warnings
beginResetModel called on EntryURLModel(0x55c23c0dec40) without calling endResetModel first
endResetModel called on EntryURLModel(0x55c23c0dec40) without calling beginResetModel first
beginResetModel called on EntryURLModel(0x55c23c861120) without calling endResetModel first
endResetModel called on EntryURLModel(0x55c23c861120) without calling beginResetModel first
beginResetModel called on EntryURLModel(0x55c23cd1ab30) without calling endResetModel first
endResetModel called on EntryURLModel(0x55c23cd1ab30) without calling beginResetModel first
The plugin architecture wasn't very useful when we only had a single
plugin per platform before Wayland was added. Even with Wayland all the
dependencies are built into the main executable anyway making the plugin
a shim.
This fixes issues with the Wayland plugin that caused memory corruption
when allocations done from the plugin were free'd by the main
application. The plugin system was not meant to be used this way.
The {PGDN} placeholder is documented but only pgup/pgdown are registered
in g_placeholderToKey, so {PGDN} fails to resolve and aborts the rest of
the Auto-Type sequence.
Add pgdn as an alias for Qt::Key_PageDown, mirroring the existing
ins/insert and del/delete aliases (lookup already lowercases the
placeholder). Also assert {PGDN} in the syntax-check test.
Fixes#13379
Signed-off-by: Arpit Jain <[email protected]>
Some earlier Qt6 versions behaved differently and didn't understand the
last spacer is supposed to stretch vertically. This is clearly visible in
the AppImage build that uses older Qt6.
On first launch, we'll install a desktop file for the current user that
points to the specific AppImage that was used to start. We'll also
update it on every launch if any changes are made to it to ensure it
always points at the latest release.
We'll also use systemd-run if possible to ensure our DBus identity is
consistent on Wayland for Auto-Type to work in all possible scenarios.
The current dark mode detection implementation is prone to a race
between an asynchronous D-Bus method call in NixUtils::NixUtils() and
bootstrap logic in Bootstrap::bootstrap(). This race condition causes
dark mode detection to fail intermittently during application startup.
The sequence of events in the failing case is as follows:
1. In the Application constructor, osUtils is instantiated, causing
the NixUtils constructor to run.
2. An asynchronous D-Bus method call is issued to query the value of
the org.freedesktop.appearance.color-scheme key.
3. Bootstrap code runs. In particular, a prctl() system call is
issued to set the keepassxc process "dumpable" attribute to 0.
4. xdg-desktop-portal begins handling the D-Bus method call initiated
in step 2. Flatpak detection logic is invoked, triggering an
attempt to access /proc/<pid>/root, where <pid> is the PID of the
keepassxc process.
5. Since the keepassxc process had its "dumpable" attribute set to 0
in step 3, its /proc/<pid>/root entry becomes owned by root. This
causes the access attempt from xdg-desktop-portal to fail, which in
turn causes the D-Bus method call to fail as well. As a result, the
registered callback (NixUtils::handleColorSchemeRead()) is never
invoked, effectively breaking dark mode detection.
If xdg-desktop-portal completes its permission checks before the
prctl() system call is issued (that is, if the order of steps 3 and 4
is reversed), everything works correctly.
Fix by replacing the asynchronous D-Bus method call with a synchronous
one, preventing bootstrap code from executing while the D-Bus call is
still pending.
* Use ReadOne D-Bus method instead of Read
The org.freedesktop.portal.Settings.Read method is deprecated. Replace
its use with org.freedesktop.portal.Settings.ReadOne and adjust reply
handling accordingly.
Remove NixUtils::handleColorSchemeRead(), which is no longer needed.
* Fixes#13351
* This unfortunately breaks backwards compatibility with the _original_ KeeAgent plugin for KeePass2. Qt6 refuses to write XML in UTF-16 format, so we have to use UTF-8. This should not be a big deal at all since our SSH agent integration has surpassed the original KeeAgent with features at this point.
* Remove individual feature flags in favor of a single `KPXC_MINIMAL` flag that removes advanced features from the build. Basic features are no longer guarded by feature flags.
* Basic features: Auto-Type, Yubikey, KeeShare
* Advanced features include: Browser (and passkeys), SSH Agent, and Secret Service
* Networking, Documentation, and Update Checking remain as feature flags to accommodate various distro requirements.
This change also cleans up the main CMakeLists.txt by re-arranging some content and placing macros into a dedicated include file. The minimum CMake version was bumped to 3.16.0 to conform to our minimum Ubuntu support of Focal (20.04). This also allows us to default to C++20, we fall back to C++17 for Qt versions less than 5.15.0 due to lack of support.
Lastly this change removes the KEEPASSXC_BUILD_TYPE="PreRelease" which is never used. We only support "Snapshot" and "Release" now.
Additional cleanup of CMakeLists:
1. Removed always-true CMake version guard if(CMAKE_VERSION >= 3.14.0)
2. Removed dead GCC 4.8 stack protector fallback; C++20 requires GCC 10+, and -fstack-protector-strong has been available since GCC 4.9.
3. Removed dead ASan LSan version guard for the same reason.
4. Converted set_target_properties( COMPILE_DEFINITIONS) to target_compile_definitions() on both keepassxc_core and keepassxc_gui. Both are now PRIVATE since the symbol is an internal build detail.
5. Scoped Qt5Gui_PRIVATE_INCLUDE_DIRS to keepassxc_gui preventing Qt-internal headers from leaking into every target in the build.
6. Use cmake_parse_arguments to cleanup test case definition macros. Remove test output formats as they are never used and can be controlled when tests are run.
* moved /fsanitize=address to compile options instead of definitions for MSVC builds
---------
Co-authored-by: varjolintu <[email protected]>
* Refactor: avoid naming lambda expressions and use STL algorithm
Lambda expressions in C++ are designed to be anonymous, lightweight, and local,
intended to encapsulate concise logic without the need for formal declarations.
Explicitly naming them (e.g., assigning to a variable or using a named `auto`)
contradicts their purpose: it introduces redundancy, adds unnecessary weight,
and blurs the line between lambdas and regular functions.
This change removes unnecessary lambda names and replaces the custom logic with
a standard STL algorithm, making the code more idiomatic, maintainable, and
aligned with the STL's philosophy of generic, reusable components.
* Refactor: Use std::any_of and lambda for deleted object checks
Replace manual for-loop iteration with std::any_of and a lambda expression
to check for the presence of a deleted object by UUID. This improves code
clarity, conciseness, and aligns with modern C++ best practices by leveraging
STL algorithms and functional-style expressions.
The second overload of containsDeletedObject() is now implemented by reusing
the first, avoiding code duplication and ensuring consistency.
* Run code format
* refactor(config): replace manual loop with `std::any_of` for roaming settings validation
- Remove the local lambda function `isValidSetting` and replace it with a direct use of `std::any_of` in the loop.
- Improve code readability and maintainability by leveraging the C++ Standard Library.
- Reduce redundancy and make the logic more concise and idiomatic.
This change ensures the code is more aligned with modern C++ practices while maintaining the same functionality.
* refactor(icons): simplify image format validation using `std::all_of`
- Replace manual loop and flag-based validation with `std::all_of` to check for non-alphanumeric characters in image formats.
- Improve code clarity and reduce boilerplate by leveraging the C++ Standard Library.
- Maintain the same filtering logic while making the code more concise and idiomatic.
---------
Co-authored-by: Jonathan White <[email protected]>