5061 Commits
Author SHA1 Message Date
Jessy2027 cd42236540 Fix UI freeze when downloading favicons with slow DNS
IconDownloader::setUrl resolved the entry's host name with the blocking QHostInfo::fromName on the GUI thread, only to find out whether the host is an IP address. When the DNS servers are slow or unreachable, the whole window stopped responding until the lookup timed out.

Check the host with UrlTools::isIpAddress instead, which parses the literal address without any network access. Also add IPv6 literal cases to the icon downloader tests.

Fixes #13989
2026-11-17 08:46:04 -05:00
Jonathan White 387fc781a2 Fix horizontal progress bars after Qt6 migration
* Fixes #13825
2026-11-15 12:21:14 +01:00
Janek Bevendorff d4c3eb359a Add workflow to automatically label pending backports 2026-11-13 20:33:01 +01:00
varjolintu 6f97143a0b Browser: Add port to title if found when creating new credentials 2026-11-13 19:52:22 +01:00
Sami VänttinenandJanek Bevendorff f33f01bf3a Browser: Fix domain matching with subdomains and wildcards (#14045)
---------

Co-authored-by: Janek Bevendorff <[email protected]>
2026-11-13 14:53:01 +01:00
Sami Vänttinen 300f0801a8 Passkeys: Fix use-after-free with passkey register/auth dialogs (#14011)
* Passkeys: Fix use-after-free with passkey register/auth dialogs
* Add one GUI test for testing the dialog rejection
2026-11-12 23:51:58 +01:00
tikisan_ b1715d81c1 Fix KDBX minor version mismatch warning after reading header
- Keep the KDBX version from the file header when setKdf() runs during open.
- Add testMinorVersionMismatchAfterSetKdf to prevent regressions.
2026-11-12 23:12:52 +01:00
Janek Bevendorff 6bcb901aef Fix out-of-bounds write due to integer wrap in KeeShare import
Thanks @tntrock for reporting
2026-11-05 08:15:26 +01:00
Janek Bevendorff a276a44b9a Bound allocation size in OpData01 reader
Thanks @smaeljaish771 for reporting
2026-11-05 08:15:26 +01:00
Janek Bevendorff 2082084690 Store only one UUID per entry in KDB reader.
Fixes use-after-free for crafted KeePass1 files with duplicate UUID fields.

Fixes GHSA-3524-mf44-vjr9 (thanks @tntrock)
2026-11-05 08:15:26 +01:00
Reilly Brogan b111337c25 Tests: Verify passkey signatures instead of comparing exact bytes
Botan 3.14 randomizes ECDSA signatures by default, even when RFC 6979
is available, so the exact signature bytes are no longer reproducible
and the EC passkey tests fail. Verify the signatures produced by
buildSignature() against the public key embedded in the signing key's
PEM instead, which validates both deterministic and randomized
signatures.
2026-11-04 18:03:57 -05:00
Janek Bevendorff 13f56db73e Reject KeeShare references without <Group>
Reject KeeShare references without a UUID and prevent synchronous reentry during import. A missing UUID previously got assigned a random UUID on each parse, causing equality checks to evaluate to false. During the merge, group removal signals could then trigger a nested import, leading to recursive destruction and use-after-free.

References without a <Group> are now rejected, nested imports are blocked by reentrance guards, and regression tests are added.

Additionally fixes file change updates arriving during a running import being silently dropped. These updates are now queue for later execution.
2026-11-04 15:58:29 +01:00
Janek Bevendorff c263a116d9 Fix window geometry restoration bug
Sometimes KeePassXC did not restore the window geometry properly. This change moves the geometry restoration to before showing the window. That should fix issues especially when the window is moved to another monitor on Wayland, but it may also resolve other strange quirks that can happen when the window starts in the tray.
2026-11-02 18:00:31 +01:00
varjolintu ba7473c0bb macOS: Force showing icons and shortcuts in menus 2026-11-02 09:55:44 +01:00
Janek Bevendorff f218280c07 Fix update version check
Handle -1 revisions correctly in the updater check version comparison and allow suffixes in the release-tool.
2026-11-01 18:25:56 +01:00
BilliamBaSH e091b3b53c Replace removed WITH_XC_* CMake flags in build scripts 2026-11-01 16:04:03 +01:00
Janek Bevendorff 07057acae0 FIx CodeQL and Copilot setup 2026-11-01 13:53:41 +01:00
Janek Bevendorff da0b07117d Fix translation file updates
release-tool.py i18n lupdate checked for an "lupdate version 5.x" substring, which no longer matches for Qt6. The check is unnecessary, and was removed.

Further, Qt 6.11 no longer skips empty source strings, so they make their way into keepassxc_en.ts. This is unnecessary, and it creates a mismatch between a local update and the CI still running Qt 6.4. Replaced empty tr("") strings with plain "".
2026-11-01 13:53:41 +01:00
Janek Bevendorff 70e439eb5f Fix potential integer overflows in importers
This is a fixup to #13682 (thanks @tikipiya).

I also found potential overflows in the OPVault importer, which are now fixed. These overflows are mostly relevant on 32-bit systems only, where Qt's decision to use signed ints for all size types comes to bite you.

Small API change: The size parameter of KeePass2RandomStream::randomBytes was widened from int to qsizetype, which is the more appropriate type anyway.
2026-11-01 13:53:41 +01:00
Toni Spets 0491ec6f06 Fix Ed25519 key size shown as 32 bits in SSH key generation dialog
Fixes #13871
2026-10-27 22:58:49 -04:00
Janek Bevendorff 09e34ba86c Ensure Qt's TLS plugins are deployed on macOS
For whatever reason, macdeployqt does not deploy the TLS plugins on its own. We need to find them manually.

Fixes #13855
2026-10-24 01:13:43 +02:00
Janek BevendorffandJonathan White 2e884edf7b Fix macOS Qt plugin deployment (#13821)
Co-authored-by: Jonathan White <[email protected]>
2026-10-24 01:09:03 +02:00
Janek Bevendorff a6ba28f8b2 Reformat code with clang-format-20 2026-10-23 15:44:56 +02:00
Janek Bevendorff b3ba195757 Add CMake option to fix clang-format binary. 2026-10-23 15:44:56 +02:00
Janek Bevendorff 1e373cf036 Remove AppDir output and force qmake6 2026-10-23 15:44:56 +02:00
Janek Bevendorff d5e43b779d Update GitHub sponsors 2026-10-21 14:28:07 +02:00
Janek Bevendorff 42bc892cab Fix regression in finding vcpkg macdeployqt 2026-10-21 07:27:50 -04:00
egglessness e0e3b844e9 Add support for configuration overrides via GPOs in Windows
This is a Windows only feature that uses policies set in the registry to control settings in KeePassXC. Overrides are set in HKLM\Software\Policies\KeePassXC and uses the same structure as the ini settings file. Overridden settings are disabled in the user interface and their values are not written to the user's own settings file.
2026-10-21 00:03:57 -04:00
Janek Bevendorff 9a58a0e128 Support cross-platform AppImage builds 2026-10-20 23:29:47 -04:00
Christian 9b4632a8da Restore wl-copy clipboard clearing on Wayland
Fixes #13809
2026-10-20 17:49:51 +02:00
Jonathan White 6c686af438 Improve cross-compiling ARM64 on Windows
* Fix using the specified QT_HOST_PATH for executables
* Fix setting the Visual Studio environment for cross-compiling
2026-10-20 11:06:53 +02:00
Jonathan White b0454704e4 Remove legacy qt.conf deployment
* Fixes #13702
2026-10-20 11:06:53 +02:00
Jonathan White 9daea646d7 Fix deploying qtbase translations with Qt6 2026-10-20 11:06:53 +02:00
Janek Bevendorff aabfb3858b Exclude libcrypto and libssl from AppImage
Fixes #13774
2026-10-18 15:26:29 -04:00
underclockeddev 0ae1b94093 Do not query the X root window without a display
Under QT_QPA_PLATFORM=offscreen the X11 native interface exists but has no
display, and DefaultRootWindow() dereferenced the null pointer at startup.
The global shortcut code already checks for a null display.
2026-10-18 16:24:31 +02:00
underclockeddevandClaude Opus 5.5 596ae49d60 Clear m_attemptingLock when a lock's autosave triggers a reload
DatabaseWidget::lock() returned early when its autosave failed and a reload
began, without clearing m_attemptingLock. Every later lock() then returned at
the m_attemptingLock check, so the database could not be locked again until
KeePassXC was restarted.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
2026-10-18 16:13:58 +02:00
Toni Spets d608efc1b8 Fix portal availability checks racing with D-Bus service activation
QDBusAbstractInterface::isValid() can latch an empty service owner
cached while xdg-desktop-portal is still activating, permanently
disabling auto-type and the global shortcut. Use the interfaces'
version() property reads instead: real blocking calls that trigger
activation if needed and return 0 only on failure.
2026-10-18 14:37:32 +02:00
varjolintu b05b0dd2e8 Use selected database when creaeting a new group when creating a passkey 2026-10-17 06:06:37 -04:00
fkobi 5abafd2805 INSTALL.md: update botan version
Should be done in

https://github.com/keepassxreboot/keepassxc/commit/7c7ca4575e7fe6c3412d3fffcd1d5ad580211a17
2026-10-16 11:34:50 -04:00
fkobi 5916e5d749 .github/workflows/codeql.yml: remove libargon2 dependency
should be done in https://github.com/keepassxreboot/keepassxc/commit/7c7ca4575e7fe6c3412d3fffcd1d5ad580211a17#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aL482-L486
2026-10-16 11:34:05 -04:00
Jonathan White b5523be1a1 Additional fixes for macOS and modern Qt6
* Replace Q_OS_MAC with Q_OS_MACOS
* Remove deleted macro QTEST_DISABLE_KEYPAD_NAVIGATION
2026-10-15 14:18:47 -04:00
Jonathan White 50738ec006 Fix warnings with COMPAT signal after Qt6 upgrade
* Fixes a specific warning that spams the console due to a deprecated signal that was used to indicate checkboxes state changed.
* Converted all QCheckBox::stateChanged(int) to QCheckBox::toggled(bool). All functionality still works as intended.
2026-10-15 14:18:47 -04:00
Jonathan White 52e2743b3a Fix snap build to use latest format (#13728)
* Fix snap build to use latest format

- add x11-related libs to make the program functional.
- additional metadata
- remove desktop-launch

* Move to core24
2026-10-14 00:00:31 -04:00
Janek Bevendorff 9e0f57a4a4 Update translations 2.8.0-beta1 2026-09-22 22:24:04 +02:00
Janek Bevendorff 013b2614e9 Update changelog date 2026-09-22 22:11:04 +02:00
ryain11andJanek Bevendorff 21bdc8248f Fixed a Secret Service Integration connection dereferencing a nullptr in some cases (#13655)
* Fix Secret Service message being null in some cases when unlocking a database

* Update changelog

---------

Co-authored-by: Janek Bevendorff <[email protected]>
2026-09-22 21:46:56 +02:00
varjolintu 80e68bb4e8 Fix out-of-bounds writing to browser messages 2026-09-22 21:46:36 +02:00
varjolintu dfdd561fc5 Passkeys: Fix parsing punycode domains 2026-09-21 22:26:59 -04:00
Janek Bevendorff fd603849ee Add --override-version option 2026-09-20 21:46:58 -04:00
Janek Bevendorff 1b2b04989e Update translations 2026-09-20 21:46:58 -04:00