Commit Graph
4286 Commits
Author SHA1 Message Date
e36c5a9589 Translated using Weblate
Currently translated at 99.7% (1472 of 1475 strings) (Estonian)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/et/

Translated using Weblate

Currently translated at 46.3% (683 of 1475 strings) (Norwegian Bokmål)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/nb/

Co-authored-by: klodrik <[email protected]>
Co-authored-by: rimasx <[email protected]>
2026-11-15 12:51:30 +00:00
98dbd79755 fix(lyrics): restore lyric lookup with missing artist metadata (#2705)
* fix: restore lyric lookup with missing artist metadata

Lyric lookup safely checks the first artist, falls back to artistName
and albumArtistName, and omits the artist parameter if none is
available. Subsonic normalization uses its fallback when both the artist
and remixer lists are absent or empty.

Fixes #2687

* chore: use conditional assign instead

---------

Co-authored-by: Matt Van Horn <[email protected]>
Co-authored-by: Kendall Garner <[email protected]>
2026-11-15 04:29:44 +00:00
ce4d42a357 fix(navidrome): restore global search with selected Navidrome folders (#2681)
* fix: restore global search with selected Navidrome folders

Searches with selected folders now use Navidrome's album artist, album,
and song list endpoints in parallel, passing the search term and folder
IDs to each. Each category preserves its limit and offset, skips
requests when its limit is zero, and sorts by name ascending. Searches
without folder filters continue using the Subsonic search endpoint.

Fixes #2666

* fix: allow subsonic search3 when one music folder is specified

---------

Co-authored-by: Matt Van Horn <[email protected]>
Co-authored-by: Kendall Garner <[email protected]>
2026-11-15 04:07:48 +00:00
DaniloandKendall Garner eb5b87df60 fix(api): pass multiple Subsonic musicFolderIds on getRandomSongList (#2609)
* fix(api): pass multiple Subsonic musicFolderIds on getRandomSongList

* fix: make only navidrome send multiple musicFolderId on getRandomSongList

* chore: use nonstandard api for nd

* chore: handle merge conflict

---------

Co-authored-by: Kendall Garner <[email protected]>
2026-11-15 02:47:15 +00:00
Mark DavenportandClaude Opus 5.5 a35ea72594 feat(library): Add refresh button to playlist sidebar (#2683)
* feat(library): refetch sidebar playlists on window focus

The sidebar query stays mounted for the whole session and global
refetchOnWindowFocus is off, so playlists changed outside the app only
appear after a manual refresh or an in-app playlist change. Enabling that
option would not help: TanStack only listens for visibilitychange, which
did not fire when alt-tabbing in Electron on Linux.

* feat(library): add refresh button to sidebar playlists

Replaces the window-focus refetch with an explicit refresh control in
the sidebar playlist header (expanded and collapsed). Invalidating the
playlist list key also refreshes the context menu and add-to-playlist
caches.

* fix(library): split collapsed sidebar playlist controls into two rows

Three icons in one row crowded the collapsed sidebar and sat under the
overlay scrollbar. Collapse toggle gets its own row; refresh and create
share the row below.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

---------

Co-authored-by: Claude Opus 5.5 <[email protected]>
2026-11-14 20:08:40 +00:00
Hosted Weblateandkarigane 9182c91c52 Translated using Weblate
Currently translated at 82.7% (1220 of 1475 strings) (Japanese)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/ja/

Co-authored-by: karigane <[email protected]>
2026-11-11 10:02:32 +01:00
Kendall Garner 302db1cc55 chore: upgrade dependencies, looks like prettier rules changed again (#2696)
* chore: upgrade dependencies, looks like prettier rules changed again

* chore: update electron version in builder
2026-11-09 21:58:11 -08:00
e60dcc80e2 fix(ui): show title combined in playlist list (#2689)
* fix(ui): show title combined in playlist list

A condition in the title combined column file expected an artist field which playlists don't have.

Fixes #2479

* chore: only render div if albumartists exists

---------

Co-authored-by: Carolina Alegre <[email protected]>
Co-authored-by: Kendall Garner <[email protected]>
2026-11-09 05:26:08 +00:00
David Jang 83c5de00dd fix(player): keep a valid index when next album finds no other album (#2660)
With every track in the queue from the same album, the next album
branch of mediaNext used findIndex's -1 as the new index, so the player
ended up without a current song. Fall back to the first track, the way
mediaPrevious already does for the previous album.

Closes #2602
2026-11-09 05:06:32 +00:00
Matt Van HornandMatt Van Horn 33aca411f4 fix: route genre context menu actions through genre song fetching (#2692)
Pass the menu's item type to PlayAction and AddToPlaylistAction so both
actions use genre song fetching for the selected genres.

Fixes #2672

Co-authored-by: Matt Van Horn <[email protected]>
2026-11-09 04:55:27 +00:00
Jonne Saloranta 3a614baae6 fix(library): send genre name for featured genre play (#2663)
* fix(library): send genre name for featured genre play

Subsonic getRandomSongs expects a genre name. Featured genres sent the
Navidrome tag id, which only matched by accident before Navidrome 0.64
(json_tree scan also hit the id leaf). Navidrome 0.64 filters genres by
name via indexed join tables, so the button queued nothing.

Use the name for Navidrome/Subsonic and keep the id for Jellyfin,
matching the shuffle all modal.

* fix(library): resolve random song genre per server
2026-11-09 03:54:13 +00:00
Nicolas Dréno 5a773daf21 fix(player): keep the jukebox player selected in the web build (#2614)
The web build reset the playback type to "web" on every page load, so a
jukebox user had to select Jukebox again each time Feishin was opened.
Only MPV and DLNA need the desktop app; keep Web and Jukebox as they are.
2026-11-09 03:00:12 +00:00
David Jang 155e562138 fix(player): cap skip forward at the track length in seconds (#2659)
Song.duration is in milliseconds while the player timestamp is in
seconds, so Math.min(duration - 1, ...) never applied and skipping
forward near the end of a track seeked past it.

Closes #2603
2026-11-03 03:32:30 +00:00
Jonne Saloranta 3a57625544 fix(player): set MPRIS DesktopEntry so KDE taskbar shows media controls (#2634)
Under Flatpak the MPRIS bus name is owned by xdg-dbus-proxy, so Plasma
cannot match the player to the window by PID. An empty DesktopEntry left
no fallback, hiding the media controls in the taskbar tooltip.
2026-11-03 03:26:17 +00:00
Kendall Garner d7bb2e8241 chore: upgrade electron 2026-11-02 19:14:55 -08:00
Hosted WeblateandJonatan Nyberg 76fa20e08d Translated using Weblate
Currently translated at 100.0% (1475 of 1475 strings) (Swedish)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/sv/

Co-authored-by: Jonatan Nyberg <[email protected]>
2026-11-01 05:51:30 +00:00
Hosted Weblateandคนแปล มังงะฝึกหัด 8d12eae8a1 Translated using Weblate
Currently translated at 18.3% (271 of 1475 strings) (Thai)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/th/

Co-authored-by: คนแปล มังงะฝึกหัด <[email protected]>
2026-10-25 09:51:26 +01:00
Hosted WeblateandHempa efaed0c577 Translated using Weblate
Currently translated at 60.9% (899 of 1475 strings) (Swedish)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/sv/

Co-authored-by: Hempa <[email protected]>
2026-10-22 10:19:58 +02:00
York 7d6ad318c7 fix: restore system font access (#2631) 2026-10-20 22:37:47 -07:00
Ray TranandClaude Fable 5.1 8baf5c2c9a fix(player): grant local-network permissions so LAN servers are reachable (#2593)
Chromium in Electron 43 enforces Local Network Access. The renderer is
loaded from file://, which is not treated as a local origin, so every
request to a private address needs the local-network-access permission.
Without a permission handler it is denied and a server on a LAN address
cannot be reached at all. Grant it for the app's own session.

Fixes #2430.


Claude-Session: https://claude.ai/code/session_01UxDiPkoRCtgk6rMMNjPfdT

Co-authored-by: Claude Fable 5.1 <[email protected]>
2026-10-20 18:18:06 -07:00
Joel Town Road 2f4c8ca925 fix(library): prefer codec over container in codec column and get info (#2592)
* fix(library): prefer codec over container in codec column and get info

Jellyfin and Navidrome adapters populate song.codec with the actual
codec name (e.g. AAC, Vorbis) while song.container holds the file
container (e.g. m4a, ogg). The codec column and the Get Info modal
were both reading song.container directly, so m4a files showed "m4a"
instead of "AAC" and ogg files showed "ogg" instead of "Vorbis".

Change both display sites to song.codec ?? song.container so the
real codec is shown when available and the container is used as a
fallback when the server does not supply a separate codec field.

No unit test harness exists for these UI components.

* feat(library): add codec column to item table list

Add TableColumn.CODEC support to ItemTableList by creating a new
CodecColumn component that displays song.codec ?? song.container,
matching the existing codec column behavior in ItemDetailList.
2026-10-20 18:13:35 -07:00
Hosted WeblateandKosmoMoustache 1b8039e375 Translated using Weblate
Currently translated at 99.5% (1468 of 1475 strings) (French)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/fr/

Co-authored-by: KosmoMoustache <[email protected]>
2026-10-20 03:51:25 +02:00
3f321069e3 Translated using Weblate
Currently translated at 100.0% (1475 of 1475 strings) (Czech)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/cs/

Translated using Weblate

Currently translated at 58.7% (867 of 1475 strings) (Swedish)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/sv/

Co-authored-by: Fjuro <[email protected]>
Co-authored-by: Hempa <[email protected]>
2026-10-18 17:51:30 +02:00
Hosted WeblateandHamster Jack 36f8e18395 Translated using Weblate
Currently translated at 99.3% (1465 of 1475 strings) (Russian)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/ru/

Co-authored-by: Hamster Jack <[email protected]>
2026-10-17 12:34:20 +02:00
jeffvli e5324a170c fix(ui): adjust item list table styles
- remove bg from queue section rows
- adjust bg/transparency on row selection
- fix row borders on fullscreen table
2026-10-16 01:50:29 -07:00
M4thew d76d989b5f fix(ui): make item count badge show 0 instead of loading indicator on favorites page (#2599) 2026-10-15 20:26:42 -07:00
Matt Bowles 319eefe49e fix(player): Prevent playerbar fullscreen toggle when total duration text is clicked (#2590) 2026-10-15 20:13:44 -07:00
Matt Van HornandMatt Van Horn 272570967c fix: pass the full artist name to native Spotify search (#2585)
The artist native link still encodes the name, then replaces every %20
with +. The album native link applies the same replacement to the artist
and the album name and joins the two parts with +.

Fixes #2264

Co-authored-by: Matt Van Horn <[email protected]>
2026-10-15 20:12:52 -07:00
3cece5820c Translated using Weblate
Currently translated at 100.0% (1475 of 1475 strings) (Ukrainian)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/uk/

Translated using Weblate

Currently translated at 100.0% (1475 of 1475 strings) (Catalan)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/ca/

Translated using Weblate

Currently translated at 100.0% (1475 of 1475 strings) (Chinese (Traditional Han script))
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/zh_Hant/

Translated using Weblate

Currently translated at 100.0% (1475 of 1475 strings) (Polish)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/pl/

Translated using Weblate

Currently translated at 100.0% (1475 of 1475 strings) (Spanish)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/es/

Co-authored-by: Fordas <[email protected]>
Co-authored-by: Gerard Gascón <[email protected]>
Co-authored-by: Viktor Varvaruk <[email protected]>
Co-authored-by: York <[email protected]>
Co-authored-by: skajmer <[email protected]>
2026-10-15 06:51:29 +02:00
DawidKrynskiandDawid Krynski dc96747a80 fix(lyrics): handle LRC timestamps without fractional seconds (#2546)
Co-authored-by: Dawid Krynski <[email protected]>
2026-10-14 19:15:33 -07:00
jeffvli 9d87539f94 fix(window): remove unneeded mouse navigation handler (#2538) 2026-10-14 18:19:36 -07:00
jayseandjanviernine 4e3ee968ec fix(library): aggregate album stats for playlist album rows (#2528)
Playlist album cards are built client-side from their songs, but
duration, play count and track count were hardcoded to null (so those
grid rows could never render) and last played was copied from a single
song. Sum duration/play count over the group's songs, use the group
size for the track count, and the most recent last-played date.

Fixes jeffvli/feishin#2481

Co-authored-by: janviernine <[email protected]>
2026-10-14 18:16:51 -07:00
jeffvli 9f53ee4d56 fix(player): queue delete hotkey focus check 2026-10-14 11:19:14 -07:00
jeffvli 985d298a67 fix(player): properly handle up next queue drop and after behavior 2026-10-14 11:19:13 -07:00
Anand Hegdeandjeffvli 947d5a1e4e feat(player): add Up Next queue for Play next (#2505)
* feat(player): add Up Next queue for Play next

Play next now adds songs to an Up Next section that sits directly after
the current song, in the order they were added. Songs leave Up Next when
they start playing, shuffle and replacing the queue keep it next, and
playing another song moves it after that song. The play queue labels the
section. A new "Up next queue" setting (on by default) restores the
previous Play next behavior when turned off.

Closes #1595

* fix(player): keep album group column working with queue sections

getRowItem returned undefined for every row when group headers were
present and no getItem accessor was used, which is the play queue's
setup, so the album group column — the one column that renders purely
from getRowItem — went blank as soon as the Up Next sections were
shown. Fall back to the expanded row model like the no-groups branch.

Also resolve the album group header's play index through the row id
instead of the display row index, which no longer matches the data
index when group header rows are interleaved.

* style(player): restyle queue section rows

Paint full-width surface bands on group header rows (including across pinned columns), style the section label/count row, and label the tail section Queue instead of the removed Next from queue string

* fix(player): correct auto-follow scroll with queue group rows

Map data index to row index accounting for inserted group header rows, so scrollToIndex no longer lands on a group header or the wrong row when Up Next sections are present. Defer the follow scroll a tick so it applies to the updated queue row model instead of the stale pre-change layout, which caused the viewport to jump down, back up, and down again on track change

* fix(player): keep queue drops above the up next block

Bottom-edge drops in the first Queue section pull items into Up
Next, or reflow them under the block after regroup. Items dropped
there stay pinned above the block; regroup and sync preserve the
gap. Boundary check shared by desktop and remote reorder paths.

---------

Co-authored-by: jeffvli <[email protected]>
2026-10-13 21:17:52 -07:00
Matt Van HornandMatt Van Horn 3a02de23f5 fix: initialize new playlists as private (#2540)
Fixes #2534

Co-authored-by: Matt Van Horn <[email protected]>
2026-10-13 18:39:27 -07:00
Alicia Sykes ae05f232f9 chore: disable analytics by default in docker-compose (#2610) 2026-10-13 18:38:49 -07:00
Hosted WeblateandAchim Walz c91cc2a940 Translated using Weblate
Currently translated at 85.3% (1256 of 1471 strings) (German)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/de/

Co-authored-by: Achim Walz <[email protected]>
2026-10-11 19:51:25 +00:00
9dc15477c8 Translated using Weblate
Currently translated at 99.8% (1469 of 1471 strings) (Estonian)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/et/

Translated using Weblate

Currently translated at 100.0% (1471 of 1471 strings) (Chinese (Traditional Han script))
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/zh_Hant/

Translated using Weblate

Currently translated at 83.2% (1224 of 1471 strings) (German)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/de/

Translated using Weblate

Currently translated at 83.2% (1224 of 1471 strings) (German)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/de/

Translated using Weblate

Currently translated at 98.7% (1453 of 1471 strings) (French)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/fr/

Translated using Weblate

Currently translated at 100.0% (1471 of 1471 strings) (Spanish)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/es/

Translated using Weblate

Currently translated at 100.0% (1471 of 1471 strings) (Spanish)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/es/

Co-authored-by: Fordas <[email protected]>
Co-authored-by: KosmoMoustache <[email protected]>
Co-authored-by: York <[email protected]>
Co-authored-by: kek w <[email protected]>
Co-authored-by: rimasx <[email protected]>
Co-authored-by: rvf1-k <[email protected]>
Co-authored-by: vahrina <[email protected]>
2026-10-05 12:51:25 +02:00
7e1bf98dcd Translated using Weblate
Currently translated at 100.0% (1471 of 1471 strings) (Indonesian)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/id/

Translated using Weblate

Currently translated at 100.0% (1471 of 1471 strings) (Czech)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/cs/

Co-authored-by: Arif Budiman <[email protected]>
Co-authored-by: Fjuro <[email protected]>
2026-10-03 23:51:24 +00:00
NekoPaw a2194d9cba Keep favorite badges visible over loaded artwork (#2545)
* fix(library): keep favorite badge above artwork
2026-10-01 20:58:15 -07:00
jeffvli 65c64d6d43 refactor(player): replace seekToTimestamp state with seek event (#2570) 2026-10-01 20:56:17 -07:00
4d3b7d68b1 Translated using Weblate
Currently translated at 100.0% (1471 of 1471 strings) (Ukrainian)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/uk/

Translated using Weblate

Currently translated at 100.0% (1471 of 1471 strings) (Catalan)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/ca/

Translated using Weblate

Currently translated at 100.0% (1471 of 1471 strings) (Polish)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/pl/

Translated using Weblate

Currently translated at 100.0% (1471 of 1471 strings) (Spanish)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/es/

Co-authored-by: Fordas <[email protected]>
Co-authored-by: Gerard Gascón <[email protected]>
Co-authored-by: Viktor Varvaruk <[email protected]>
Co-authored-by: skajmer <[email protected]>
2026-10-01 08:51:27 +02:00
jeffvli cd0839be44 fix: error due to originalYear domain type change to nullable 2026-09-30 01:20:06 -07:00
jeffvli 1e567f40e1 feat(api): re-add fallback dates to Navidrome normalization (#2509) 2026-09-30 01:16:27 -07:00
jeffvli a0cfa1b2c4 docs: add additional AI disclosures in CONTRIBUTING.md 2026-09-30 01:16:27 -07:00
Hosted WeblateandMichał 23ce912e66 Translated using Weblate
Currently translated at 100.0% (1469 of 1469 strings) (Polish)
Translation: feishin/Translation
Translate-URL: https://hosted.weblate.org/projects/feishin/translation/pl/

Co-authored-by: Michał <[email protected]>
2026-09-30 03:35:54 +00:00
jayseandjanviernine 5f04502cf0 fix(player): reset fullscreen title scroll state per track (#2529)
The scroll-mode title could render blank (particularly for short
titles): overflow was measured once per title with no re-check after
webfonts settled, and a previous title's scroll position/animation
could persist into the next one. Remount the scroll track per title,
snap back to origin plus cancel animations when the title fits, and
re-check overflow once webfonts are ready. The scroll viewport now also
spans the full available width (centered when the title fits) so the
overflow measurement is well-defined in every alignment.

Fixes jeffvli/feishin#2485

Co-authored-by: janviernine <[email protected]>
2026-09-29 20:35:45 -07:00
Andrew Herron 60a2e44640 Audiobook support (#2462)
* feat(player): support Jellyfin player position item property to resume playback

When an item is resumable, Jellyfin returns an `item.UserData.PlaybackPositionTicks` property.
Map this to a new `resumePositionMs` song property and seek to it when playback begins.

* feat(player): report playback position for Jellyfin resumable media

Jellyfin persists the resume position from progress and stop reports for
item types that are resumable (e.g. AudioBook). Progress is reported
every 10 seconds, and the stop scrobble is sent. The stop is sent before
the new track's start because Jellyfin clears the session's now-playing
item on any stop report.

* feat(library): extend Jellyfin library type support to allow audiobooks
2026-09-29 20:19:00 -07:00
Dyredhead d8cefd9a48 feat(ui): show playlist icons in collapsed sidebar (#2512)
* feat(ui): show playlist icons in collapsed sidebar

When the sidebar playlist list setting is on, the collapsed sidebar now
lists playlist images with a name tooltip, the same context menu and
drag/drop, and an accent ring on the currently playing playlist. A
header links to the playlists page, toggles the list, and creates a
playlist. The expanded sidebar gets a divider above its playlist
section.

Owned/shared list logic is shared in useSidebarPlaylistItems instead of
being duplicated per section.

* feat(ui): add hover play overlay to collapsed sidebar playlists

Hovering a collapsed sidebar playlist icon scales it up and shows a play
button styled like the table image column. The button follows the play
button behavior setting, has the shared play tooltip, and holding it
shuffles. The name tooltip opens without delay and icons request the
table image size.

* fix(ui): pad collapsed sidebar playlists header like nav items

Long translations of the header label overflowed the collapsed sidebar.
2026-09-29 20:16:30 -07:00