* fix: restore lyric lookup with missing artist metadata
Lyric lookup safely checks the first artist, falls back to artistName
and albumArtistName, and omits the artist parameter if none is
available. Subsonic normalization uses its fallback when both the artist
and remixer lists are absent or empty.
Fixes#2687
* chore: use conditional assign instead
---------
Co-authored-by: Matt Van Horn <[email protected]>
Co-authored-by: Kendall Garner <[email protected]>
* fix: restore global search with selected Navidrome folders
Searches with selected folders now use Navidrome's album artist, album,
and song list endpoints in parallel, passing the search term and folder
IDs to each. Each category preserves its limit and offset, skips
requests when its limit is zero, and sorts by name ascending. Searches
without folder filters continue using the Subsonic search endpoint.
Fixes#2666
* fix: allow subsonic search3 when one music folder is specified
---------
Co-authored-by: Matt Van Horn <[email protected]>
Co-authored-by: Kendall Garner <[email protected]>
* feat(library): refetch sidebar playlists on window focus
The sidebar query stays mounted for the whole session and global
refetchOnWindowFocus is off, so playlists changed outside the app only
appear after a manual refresh or an in-app playlist change. Enabling that
option would not help: TanStack only listens for visibilitychange, which
did not fire when alt-tabbing in Electron on Linux.
* feat(library): add refresh button to sidebar playlists
Replaces the window-focus refetch with an explicit refresh control in
the sidebar playlist header (expanded and collapsed). Invalidating the
playlist list key also refreshes the context menu and add-to-playlist
caches.
* fix(library): split collapsed sidebar playlist controls into two rows
Three icons in one row crowded the collapsed sidebar and sat under the
overlay scrollbar. Collapse toggle gets its own row; refresh and create
share the row below.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
---------
Co-authored-by: Claude Opus 5.5 <[email protected]>
* fix(ui): show title combined in playlist list
A condition in the title combined column file expected an artist field which playlists don't have.
Fixes#2479
* chore: only render div if albumartists exists
---------
Co-authored-by: Carolina Alegre <[email protected]>
Co-authored-by: Kendall Garner <[email protected]>
With every track in the queue from the same album, the next album
branch of mediaNext used findIndex's -1 as the new index, so the player
ended up without a current song. Fall back to the first track, the way
mediaPrevious already does for the previous album.
Closes#2602
Pass the menu's item type to PlayAction and AddToPlaylistAction so both
actions use genre song fetching for the selected genres.
Fixes#2672
Co-authored-by: Matt Van Horn <[email protected]>
* fix(library): send genre name for featured genre play
Subsonic getRandomSongs expects a genre name. Featured genres sent the
Navidrome tag id, which only matched by accident before Navidrome 0.64
(json_tree scan also hit the id leaf). Navidrome 0.64 filters genres by
name via indexed join tables, so the button queued nothing.
Use the name for Navidrome/Subsonic and keep the id for Jellyfin,
matching the shuffle all modal.
* fix(library): resolve random song genre per server
The web build reset the playback type to "web" on every page load, so a
jukebox user had to select Jukebox again each time Feishin was opened.
Only MPV and DLNA need the desktop app; keep Web and Jukebox as they are.
Song.duration is in milliseconds while the player timestamp is in
seconds, so Math.min(duration - 1, ...) never applied and skipping
forward near the end of a track seeked past it.
Closes#2603
Under Flatpak the MPRIS bus name is owned by xdg-dbus-proxy, so Plasma
cannot match the player to the window by PID. An empty DesktopEntry left
no fallback, hiding the media controls in the taskbar tooltip.
Chromium in Electron 43 enforces Local Network Access. The renderer is
loaded from file://, which is not treated as a local origin, so every
request to a private address needs the local-network-access permission.
Without a permission handler it is denied and a server on a LAN address
cannot be reached at all. Grant it for the app's own session.
Fixes#2430.
Claude-Session: https://claude.ai/code/session_01UxDiPkoRCtgk6rMMNjPfdT
Co-authored-by: Claude Fable 5.1 <[email protected]>
* fix(library): prefer codec over container in codec column and get info
Jellyfin and Navidrome adapters populate song.codec with the actual
codec name (e.g. AAC, Vorbis) while song.container holds the file
container (e.g. m4a, ogg). The codec column and the Get Info modal
were both reading song.container directly, so m4a files showed "m4a"
instead of "AAC" and ogg files showed "ogg" instead of "Vorbis".
Change both display sites to song.codec ?? song.container so the
real codec is shown when available and the container is used as a
fallback when the server does not supply a separate codec field.
No unit test harness exists for these UI components.
* feat(library): add codec column to item table list
Add TableColumn.CODEC support to ItemTableList by creating a new
CodecColumn component that displays song.codec ?? song.container,
matching the existing codec column behavior in ItemDetailList.
The artist native link still encodes the name, then replaces every %20
with +. The album native link applies the same replacement to the artist
and the album name and joins the two parts with +.
Fixes#2264
Co-authored-by: Matt Van Horn <[email protected]>
Playlist album cards are built client-side from their songs, but
duration, play count and track count were hardcoded to null (so those
grid rows could never render) and last played was copied from a single
song. Sum duration/play count over the group's songs, use the group
size for the track count, and the most recent last-played date.
Fixesjeffvli/feishin#2481
Co-authored-by: janviernine <[email protected]>
* feat(player): add Up Next queue for Play next
Play next now adds songs to an Up Next section that sits directly after
the current song, in the order they were added. Songs leave Up Next when
they start playing, shuffle and replacing the queue keep it next, and
playing another song moves it after that song. The play queue labels the
section. A new "Up next queue" setting (on by default) restores the
previous Play next behavior when turned off.
Closes#1595
* fix(player): keep album group column working with queue sections
getRowItem returned undefined for every row when group headers were
present and no getItem accessor was used, which is the play queue's
setup, so the album group column — the one column that renders purely
from getRowItem — went blank as soon as the Up Next sections were
shown. Fall back to the expanded row model like the no-groups branch.
Also resolve the album group header's play index through the row id
instead of the display row index, which no longer matches the data
index when group header rows are interleaved.
* style(player): restyle queue section rows
Paint full-width surface bands on group header rows (including across pinned columns), style the section label/count row, and label the tail section Queue instead of the removed Next from queue string
* fix(player): correct auto-follow scroll with queue group rows
Map data index to row index accounting for inserted group header rows, so scrollToIndex no longer lands on a group header or the wrong row when Up Next sections are present. Defer the follow scroll a tick so it applies to the updated queue row model instead of the stale pre-change layout, which caused the viewport to jump down, back up, and down again on track change
* fix(player): keep queue drops above the up next block
Bottom-edge drops in the first Queue section pull items into Up
Next, or reflow them under the block after regroup. Items dropped
there stay pinned above the block; regroup and sync preserve the
gap. Boundary check shared by desktop and remote reorder paths.
---------
Co-authored-by: jeffvli <[email protected]>
The scroll-mode title could render blank (particularly for short
titles): overflow was measured once per title with no re-check after
webfonts settled, and a previous title's scroll position/animation
could persist into the next one. Remount the scroll track per title,
snap back to origin plus cancel animations when the title fits, and
re-check overflow once webfonts are ready. The scroll viewport now also
spans the full available width (centered when the title fits) so the
overflow measurement is well-defined in every alignment.
Fixesjeffvli/feishin#2485
Co-authored-by: janviernine <[email protected]>
* feat(player): support Jellyfin player position item property to resume playback
When an item is resumable, Jellyfin returns an `item.UserData.PlaybackPositionTicks` property.
Map this to a new `resumePositionMs` song property and seek to it when playback begins.
* feat(player): report playback position for Jellyfin resumable media
Jellyfin persists the resume position from progress and stop reports for
item types that are resumable (e.g. AudioBook). Progress is reported
every 10 seconds, and the stop scrobble is sent. The stop is sent before
the new track's start because Jellyfin clears the session's now-playing
item on any stop report.
* feat(library): extend Jellyfin library type support to allow audiobooks
* feat(ui): show playlist icons in collapsed sidebar
When the sidebar playlist list setting is on, the collapsed sidebar now
lists playlist images with a name tooltip, the same context menu and
drag/drop, and an accent ring on the currently playing playlist. A
header links to the playlists page, toggles the list, and creates a
playlist. The expanded sidebar gets a divider above its playlist
section.
Owned/shared list logic is shared in useSidebarPlaylistItems instead of
being duplicated per section.
* feat(ui): add hover play overlay to collapsed sidebar playlists
Hovering a collapsed sidebar playlist icon scales it up and shows a play
button styled like the table image column. The button follows the play
button behavior setting, has the shared play tooltip, and holding it
shuffles. The name tooltip opens without delay and icons request the
table image size.
* fix(ui): pad collapsed sidebar playlists header like nav items
Long translations of the header label overflowed the collapsed sidebar.