Merge pull request #737 from element-hq/gaelg/curl-pods-restart

tests: restart curl pods on failure to fetch metrics
This commit is contained in:
Gaël Goinvic authored and GitHub committed 2025-09-16 11:50:00 +02:00
commit e3577cdee3
3 files changed
+6 -2

No files matched your search

+1
View File
@@ -0,0 +1 @@
Restart curl pods on failure when fetching metrics.
+4 -2
View File
@@ -111,7 +111,9 @@ async def get_deployment_marker(kube_client, generated_data, marker: str):
return configmap.data.get(marker)
async def run_pod_with_args(kube_client: AsyncClient, generated_data, image_name, pod_name, args):
async def run_pod_with_args(
kube_client: AsyncClient, generated_data, image_name, pod_name, args, restart_policy="Never"
):
pod_pull_secrets = []
if os.environ.get("CI") and ("DOCKERHUB_USERNAME" in os.environ) and ("DOCKERHUB_TOKEN" in os.environ):
pod_pull_secrets = [
@@ -120,7 +122,7 @@ async def run_pod_with_args(kube_client: AsyncClient, generated_data, image_name
pod = Pod(
metadata=ObjectMeta(name=pod_name + "-" + str(int(time.time() * 1000)), namespace=generated_data.ess_namespace),
spec=PodSpec(
restartPolicy="Never",
restartPolicy=restart_policy,
imagePullSecrets=pod_pull_secrets,
containers=[
Container(
+1
View File
@@ -246,6 +246,7 @@ async def has_actual_metrics_on_endpoint(
"-s",
f"http://{service.metadata.name}.{generated_data.ess_namespace}.svc.cluster.local:{port_spec.port}/metrics",
],
restart_policy="OnFailure",
)
for metric_family in text_string_to_metric_families(metrics_data):
assert metric_family.name, "Metric family has no name"