7w1 ef0df13b72 fix(timeline): suppress dividers when the underlying event renders null (#720)
## Summary

Closes #701. Stops the timeline from rendering bare day-dividers /
new-message dividers when the underlying event was filtered out at
render time. The orphan-divider pattern in the issue's screenshot was
caused by `useProcessedTimeline` attaching `willRenderDayDivider` to
events that `useTimelineEventRenderer` later returned `null` for (e.g.
membership / profile-change events when `hideMembershipEvents` or
`hideNickAvatarEvents` are on). The render layer would still emit the
divider but skip the event under it.

## Why this matters

7w1's diagnosis on the issue: "this is specifically an issue ... when
there's rooms with lots of hidden events (e.g. joins/leaves, profile
changes) and no other messages, such as announcement channels." The
render now matches that — when an event renders to `null`, its divider
is skipped too.

## Diff

`src/app/features/room/RoomTimeline.tsx`:

```tsx
+const showDividers = renderedEvent !== null;
-const dividers = (
+const dividers = showDividers ? (
   <>
     {eventData.willRenderDayDivider && ( ... )}
     {eventData.willRenderNewDivider && ( ... )}
   </>
-);
+) : null;
```

8 lines added, 2 changed.

## Edge case + follow-up

If a day's first hook-eligible event is rendered-null but a later event
renders correctly, the day-divider is lost for that day. That's strictly
better than an orphan divider in the announcement-channel symptom case,
and the proper fix (`useProcessedTimeline` propagates the divider
forward to the first event whose renderer prediction is non-null) is a
larger refactor that can land separately. Happy to follow up with that
if you'd prefer not to take the small fix first.

## Verification

- `pnpm tsc --noEmit` — `No errors found`.
- Manual smoke test path (per issue 7w1 comment): an announcement-style
room dominated by profile-change events stops showing bare day-dividers
between them. A normal chat with mixed messages and joins still renders
dividers correctly because the day's first message-event is the one
carrying the divider, and that event renders fine.

This contribution was developed with AI assistance (Claude Code).
2026-05-14 03:18:34 +00:00
2026-05-13 22:16:07 -05:00
2026-05-08 18:04:24 +02:00
2026-05-13 19:26:40 -05:00
2026-05-13 19:26:20 -05:00
2026-05-13 22:16:07 -05:00
2026-03-05 22:34:11 -06:00
2026-05-08 18:04:24 +02:00
2026-03-04 19:21:00 -06:00
2026-05-01 04:59:25 +03:00
2026-05-09 22:54:07 +00:00
2026-03-13 21:38:40 -05:00
2026-05-04 21:50:11 -05:00
2026-05-01 04:59:25 +03:00
2026-03-12 00:31:27 +01:00
2026-05-08 18:04:24 +02:00
2026-05-13 01:42:09 +00:00
2026-05-13 18:28:20 -05:00
2026-05-01 04:59:25 +03:00
2026-05-01 04:59:25 +03:00
2023-02-24 17:28:04 +05:30
2026-05-08 18:04:24 +02:00
2026-05-01 04:59:25 +03:00
2026-05-09 22:54:07 +00:00
2026-05-09 17:49:48 -05:00
2026-05-13 12:42:00 -05:00

Sable

A Matrix client built to enhance the user experience with quality-of-life features, cosmetics, utilities, and sheer usability. See the changelog.

Soon to be replaced desktop apps can be downloaded here. They auto-update by pulling the website.

Join our matrix space here to discuss features, issues, or meowing.

Forked from Cinny.

Getting started

The web app is available at app.sable.moe and gets updated on frequently, as soon as a feature is deemed stable.

You can also download our desktop app for windows and linux from releases.

Self-hosting

You have a few options for self hosting, you can:

  1. Run the prebuilt docker container.
  2. Deploy on a site like GitLab Pages. Jae has a guide here.
  3. Build it yourself.

Docker

Prebuilt images are published to ghcr.io/sableclient/sable.

  • latest tracks the current dev branch image.
  • X.Y.Z tags are versioned releases.
  • X.Y tags float within a release line.
  • Pushes to dev also publish a short commit SHA tag.

Run the latest image with:

docker run --rm -p 8080:8080 ghcr.io/sableclient/sable:latest

Then open http://localhost:8080.

If you want to override the bundled config.json, mount your own file at /app/config.json:

services:
  sable:
    image: ghcr.io/sableclient/sable:latest
    ports:
      - '8080:8080'
    volumes:
      - ./config.json:/app/config.json:ro

Build it yourself

To build and serve Sable yourself with nginx, clone this repo and build it:

pnpm i # Installs all dependencies
pnpm run build # Compiles the app into the dist/ directory

After that, you can copy the dist/ directory to your server and serve it.

  • In the config.json, you can modify the default homeservers, feature rooms/spaces, toggle the account switcher, and toggle experimental simplified slilding sync support.

Optional default client settings

While the default settings are recommended for most users, you can optionally add a top-level "settingsDefaults" object whose keys match client settings (only fields you want to override) to override them. The default settings for any new logins will match these. Existing keys in local storage or users who chose to sync settings with their account data will still have their settings set.

For example:

{
  "settingsDefaults": {
    "hour24Clock": true,
    "pageZoom": 110,
    "messageLayout": 2,
    "rightSwipeAction": "members",
    "captionPosition": "below",
    "renderUserCards": "both",
    "jumboEmojiSize": "large"
  }
}

Invalid or unknown keys are ignored.

  • To deploy on subdirectory, you need to rebuild the app youself after updating the base path in build.config.ts.
    • For example, if you want to deploy on https://sable.moe/app, then set base: '/app'.

Local development

Tip

We recommend using a version manager as versions change quickly. fnm is a great cross-platform option (Windows, macOS, and Linux). NVM on Windows and nvm on Linux/macOS are also good choices. Use the version defined in .node-version.

Execute the following commands to start a development server:

fnm use --corepack-enabled # Activates the Node version and enables corepack
# If you not using fnm, install corepack manually: npm install --global corepack@latest
corepack install # Installs the pnpm version specified in package.json
pnpm i # Installs all dependencies
pnpm run dev # Serve a development version

To build the app:

pnpm run build # Compiles the app into the dist/ directory

Deployment and infrastructure

Deployment workflows and infrastructure details live in infra/README.md.

S
Description
No description provided
Readme AGPL-3.0
107 MiB
0 Stars 1 Watchers 0 Forks
Languages
TypeScript 93.2%
Rust 5.2%
JavaScript 0.8%
Kotlin 0.2%
CSS 0.2%
Other 0.3%