Commit Graph
4094 Commits
Author SHA1 Message Date
hazre 4a99cc50f9 test: replace stale lint suppressions with type imports 2026-04-19 16:47:34 +02:00
hazre fecf22ad5a chore: drop stale oxlint suppressions 2026-04-19 16:47:28 +02:00
hazre 70ccc6ff55 chore: switch oxfmt to ts config 2026-04-19 16:47:05 +02:00
hazre 110e615d51 test: restore mocks after oxlint migration 2026-04-19 15:56:51 +02:00
7w1 f2bd03f427 add promise to plugins
and disable always-return because its annoying
2026-04-17 16:36:47 -05:00
7w1 40bb35f34c linting awayy 2026-04-17 16:23:59 -05:00
7w1 144e148154 many lint fixes 2026-04-17 14:09:04 -05:00
7w1 760b19ea1d more linting 2026-04-17 12:44:11 -05:00
7w1 9c13aaa557 knip ignore oxlint config, fix array issues 2026-04-17 12:34:20 -05:00
7w1 9636e7389d swap to .config.ts and remove useless script and pushnotification lint fixes 2026-04-17 12:30:04 -05:00
7w1 27eaadf9ae typecheck and linting fixes 2026-04-17 00:37:15 -05:00
7w1 b13c9b61d4 formatting 2026-04-16 22:38:18 -05:00
7w1 1717ca872f migrate to oxlint and oxfmt
ran formatter
fixed lint issues, primarily getting rid of "any"s and swapping to .toSorted()
2026-04-16 22:15:13 -05:00
7w1 f6f63253fa fix(caddy): add cache-control headers for static assets, service worker, and index.html (#609)
> Related to closed PR #548 (`fix/media-error-handling`), which was
split into smaller focused PRs.

### Description

Without explicit `Cache-Control` headers, browsers apply heuristic
caching to all responses — including `sw.js` and `index.html`. This
causes stale service workers and stale app shells to persist after a
deploy. Three header rules added to the Caddyfile:

- `/assets/*` — `public, max-age=31536000, immutable`: content-hashed
filenames change on every build, so these are safe to cache permanently.
- `/sw.js` — `no-cache`: must always be revalidated so the browser picks
up SW updates promptly.
- `/index.html` — `no-cache`: must always be revalidated so the browser
gets the latest asset hashes on load.

Fixes #

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).

The cache header rules were partially AI assisted. I verified the
`immutable` directive is appropriate for content-hashed assets and that
`no-cache` (revalidate-always, not no-store) is correct for `sw.js` and
`index.html`.
2026-04-16 15:10:48 +00:00
7w1 b8ef2418fa fix(pwa): re-enable Workbox precaching (remove injectionPoint override) (#611)
> Related to closed PR #548 (`fix/media-error-handling`), which was
split into smaller focused PRs.

### Description

`injectionPoint: undefined` was set in `vite.config.ts` to silence a
Workbox `AssertionError` about multiple `self.__WB_MANIFEST` occurrences
(an `if` guard in `sw.ts` plus the `precacheAndRoute()` call = two
matches; Workbox requires exactly one). The unintended consequence:
Workbox never injected the precache manifest, so **no assets were
precached** — every cold start hit the network instead of serving from
cache, and offline use was broken entirely.

Fix: remove the `if` guard in `sw.ts` (leaving exactly one
`self.__WB_MANIFEST` reference) then remove `injectionPoint: undefined`
from `vite.config.ts` to restore normal precaching behaviour.

Fixes #

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).

The root cause diagnosis (two `self.__WB_MANIFEST` references causing
Workbox to silently skip injection) was identified with AI assistance. I
verified the fix by checking Workbox's `injectionPoint` behaviour and
confirming precaching was restored.
2026-04-16 15:10:07 +00:00
7w1 618d71bc5d Fix the first message showing as empty because it is expecting a prevContent (#685)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Fixes the first message showing as empty because it is expecting a
prevContent

Fixes #

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
Having a hard time to think of a pun here made me optimize the fix
instead.
2026-04-15 19:44:47 +00:00
Evie Gauthier 8ea42131ed Merge branch 'dev' into fix/workbox-precaching 2026-04-15 11:48:19 -04:00
7w1 7783707d87 fix(ui): suppress button hover transform inside VList rows to prevent smearing (#614)
> Related to closed PR #598 (`fix/perf-rerender-reduction`), which was
split into smaller focused PRs.

### Description

Buttons inside VList rows were applying a CSS `transform` on `:hover`.
Because VList row elements use `position: relative` with `will-change:
transform` for virtualisation, the button transform was composited
against the row's own transform layer, producing a visual smear — the
button appeared to shift or blur while the row stayed in place.

Fix: add a scoped CSS override in `General.css.ts` that resets
`transform: none` on `:hover` for buttons inside VList row containers.

Fixes #

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).

The CSS override was partially AI assisted. I identified the smearing
symptom and verified that the transform interaction between VList row
layers and button hover state was the cause before applying the fix.
2026-04-14 22:28:41 +00:00
7w1 0ae344aa6e fix spamming the abbreviation crashing sable (#665)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Checks if the click is real and returns; if it isn't

Fixes #588

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
A Cupid with a Yellow Rose hit me with its arrow that had fix wrapped
around the shaft <3
2026-04-14 22:26:21 +00:00
Evie Gauthier 2db7b605a4 refactor(css): simplify VList hover transform overrides
The catch-all [data-index] button:hover and [data-index] [role="button"]:hover
selectors already cover every button variant inside VList items, making the
intermediate class-specific selectors redundant. Remove them.
2026-04-13 23:57:51 -04:00
Evie Gauthier 7e0b220bef chore: add changeset for vlist-hover-transform 2026-04-13 23:57:50 -04:00
Shea Duma 472b822eea smolest fix :plead::plead::plead: 2026-04-14 03:15:02 +03:00
Shea Duma f70d9a99b4 smoler fix :plead::plead: 2026-04-14 03:12:00 +03:00
Shea Duma 294103f00a smol fix :plead: 2026-04-14 03:02:32 +03:00
7w1 c96947b746 fix - statuses sticking, and badge rendering (#664)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Fix statuses sticking from optimization and badge showing the wrong pfp
in the DM list

(same 2 'people' in this chat, both dm chat, showing the right pfp with
their statuses fixed)
<img width="317" height="164" alt="image"
src="https://github.com/user-attachments/assets/5fd789bb-0aba-4a5b-bf28-70ba4bdd0d22"
/>

Fixes Issue mentioned in the space

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
A sleep paralysis demon moved my body as to type the fix
2026-04-13 00:10:24 +00:00
Shea Duma e16d96fab4 fix issue #588 2026-04-12 04:02:21 +03:00
Shea Duma 0b658e671b proper fix for more wide presence issues too! 2026-04-12 03:06:57 +03:00
Shea Duma e0c61ebdcc making the md checker happi 2026-04-11 20:51:05 +03:00
Shea Duma 9d77e8ab9f small fix sticking and showing the wrong item in the preview 2026-04-11 20:43:34 +03:00
7w1 6a895f8de1 chore: prepare release 1.14.0 (#603)
> [!IMPORTANT]
> Merging this PR will create a new release.

## Features

* Add support for rendering bundled urls per MSC4095
([#590](https://github.com/SableClient/Sable/pull/590) by @nushea)
* Improve code blocks with faster, more accurate syntax highlighting,
broader language support, and separate light and dark theme options.
([#576](https://github.com/SableClient/Sable/pull/576) by @hazre)
* Add statuses to DMs
([#644](https://github.com/SableClient/Sable/pull/644) by @nushea)
* Add custom DM images and descriptions
([#644](https://github.com/SableClient/Sable/pull/644) by @nushea)
* Add statuses to Member Tile
([#644](https://github.com/SableClient/Sable/pull/644) by @nushea)
* Add the ability to set Global Name Colors dependent on the theme
(dark/light) ([#656](https://github.com/SableClient/Sable/pull/656) by
@nushea)
* Add a setting to collapse sidebar folders by default.
([#624](https://github.com/SableClient/Sable/pull/624) by @7w1)
* Add a "Dismiss" button to command response messages.
([#625](https://github.com/SableClient/Sable/pull/625) by @7w1)
* Update threads: various fixes, browse all room threads, and see live
reply counts on messages.
([#564](https://github.com/SableClient/Sable/pull/564) by @Just-Insane)
* Re-introduced custom HTML formatting for long messages
([#641](https://github.com/SableClient/Sable/pull/641) by @Septicity)
* You can now share direct links to specific settings, and opening one
takes you to the right section and highlights the target option.
([#577](https://github.com/SableClient/Sable/pull/577) by @hazre)
* Settings now use route-based navigation with improved desktop and
mobile behavior, including better back and close handling.
([#577](https://github.com/SableClient/Sable/pull/577) by @hazre)

## Fixes

* Use file name instead of "a voice message" for non-voice audio files.
([#651](https://github.com/SableClient/Sable/pull/651) by @mvanhorn)
* Constrain bug report modal to viewport height to prevent overflow.
([#652](https://github.com/SableClient/Sable/pull/652) by @mvanhorn)
* Fix dms navigation not navigating to dms when local storage is messed
up. ([#653](https://github.com/SableClient/Sable/pull/653) by @7w1)
* Fix reply button not capturing editor focus.
([#623](https://github.com/SableClient/Sable/pull/623) by @7w1)
* Fixes links not being clickable in formatted messages, including
messages that use abbreviations.
([#632](https://github.com/SableClient/Sable/pull/632) by @hazre)
* Fix some zero-width (invisible) names
([#640](https://github.com/SableClient/Sable/pull/640) by @nushea)
* Fix iOS elastic bounce-back overscroll on the root element.
([#650](https://github.com/SableClient/Sable/pull/650) by @mvanhorn)
* Fixed the "sticky scrolling" issue in encrypted rooms with many PMP
messages. ([#626](https://github.com/SableClient/Sable/pull/626) by
@Septicity)
* Fix blank room timeline when app returns from background. When sliding
sync delivers an `initial: true` response for the open room, a
`TimelineReset` event now correctly shows skeleton placeholders while
events reload instead of leaving an empty view.
([#657](https://github.com/SableClient/Sable/pull/657) by @Just-Insane)
* Image zooming is now centered on the cursor position
([#602](https://github.com/SableClient/Sable/pull/602) by @mini-bomba)
* Image zooming is now multiplicative instead of additive, resulting in
a consistent "zooming speed".
([#602](https://github.com/SableClient/Sable/pull/602) by @mini-bomba)
* Image zoom buttons now zoom towards the center of the screen
([#602](https://github.com/SableClient/Sable/pull/602) by @mini-bomba)
* Right clicks no longer drag images in the viewer.
([#620](https://github.com/SableClient/Sable/pull/620) by @Septicity)
* Updated Support links to point to https://opencollective.com/sable
([#661](https://github.com/SableClient/Sable/pull/661) by @7w1)
v1.14.0
2026-04-10 03:23:45 +00:00
github-actions[bot] d6def47b4d chore: prepare release 1.14.0 2026-04-10 03:16:07 +00:00
7w1 b092e0dc2b Update support links (#661)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->

Update support buttons to point to https://opencollective.com/sable

#### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
2026-04-09 22:15:32 -05:00
7w1 ff8d1c73b2 Update donation links to Open Collective
Updated support links for donations.
2026-04-09 22:12:00 -05:00
7w1 1e43d2db4a Add donation link to contributing guidelines 2026-04-09 22:10:33 -05:00
7w1 b16c8e57be Remove commented-out GitHub button from WelcomePage
Removed commented-out button for GitHub link.
2026-04-09 22:09:47 -05:00
7w1 0fdbc9081f Update link in About component to Open Collective 2026-04-09 22:08:53 -05:00
7w1 882876e9ff feat(threads): thread drawer, thread browser, live reply counts, and unread badges (#564)
📝 **Docs:** Already live at [Threads — Sable
Docs](https://docs.sable.moe/new-features/threads/) — no separate docs
PR needed.

---

### Description

Expands Matrix thread support with a full thread drawer, server-side
thread browser, live reply counts, unread badges, and several UX fixes.

#### ThreadDrawer

- Slide-in drawer for reading and replying in threads without leaving
the main room
- Thread root message shown at top with full reply history below
- Up-arrow edit-last-message: pressing ↑ in the thread input edits the
user's last own message in that thread
- Reactions add/remove trigger immediate re-renders without manual
refresh (handles the fact that reaction events carry
`m.relates_to.event_id` not `threadRootId` directly — fetches target
event to check thread membership)
- Thread root message box sized to content with `maxHeight: 200px` to
avoid dead whitespace on short messages

#### ThreadBrowser

- Lists all threads in the room; calls `room.fetchRoomThreads()` on
mount to load threads beyond the local timeline window
- Load-more button when the server has additional thread pages
- Each thread preview shows sender avatar, display name, reply count,
and last message body with ellipsis truncation
- Jump button navigates to the thread root in the main timeline (via
`useRoomNavigate`) instead of re-opening the drawer
- Thread unread badges on each preview item via
`room.getThreadUnreadNotificationCount()`

#### ThreadReplyChip (main timeline)

- Shows unread badge for threads with unseen replies via
`room.getThreadUnreadNotificationCount()`

#### Thread button (RoomViewHeader)

- If a thread drawer is open, button closes the drawer and opens the
thread browser (allows going from a single thread to the full list)
- If no thread is open, button toggles the thread browser as before
- `aria-pressed` reflects both thread browser state and open thread
drawer

Fixes #

#### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does)
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail)

ThreadDrawer/ThreadBrowser/thread-chip iterations were partially AI
assisted; I reviewed and adjusted logic for timeline processing, thread
loading, and event rendering behavior.
2026-04-10 03:01:30 +00:00
7w1 29d90e6285 formatting 2026-04-09 21:58:44 -05:00
7w1 02876e032f Clean up comments in ThreadBrowser component
Removed comments explaining reply count logic.
2026-04-09 21:47:30 -05:00
7w1 595d990ced remove some unnecessary comments 2026-04-09 21:46:20 -05:00
7w1 f590b99339 fix: use file name instead of 'a voice message' for non-voice audio (#651)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

Only labels audio files as "a voice message" when they actually are
voice messages (have waveform data). Regular audio files (music,
podcasts) now use the file name as the body text instead.

Fixes #543

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).

The `isVoice` check logic was written alongside an AI tool. It checks
whether the audio message event contains `waveform` data in
`content.info` to distinguish voice messages from regular audio file
uploads. If waveform data is absent, the message body falls back to the
file name from `content.body` instead of the hardcoded "a voice message"
string.
2026-04-10 02:41:59 +00:00
7w1 72da551ae0 fix(timeline): fix blank room timeline when app returns from background (#657)
## Description

When the app returns from background, `retryImmediately()` triggers a
fresh sliding sync response. If the server includes `initial: true` for
the currently open room, the SDK emits `RoomEvent.TimelineReset`,
replacing the live timeline with a new empty one. `eventsLength` drops
to 0 but `isReady` stays `true`, leaving the message list visually blank
for ~500 ms until events re-arrive from the server.

### Changes

**`RoomTimeline.tsx`**

- Added a `useLayoutEffect` that detects `eventsLength` dropping to 0
while the timeline is already visible (`isReady === true`). It
immediately sets `isReady = false` and resets `hasInitialScrolledRef`,
re-arming the existing initial-scroll logic. Uses `useLayoutEffect` so
the transition happens before the browser paints — the blank frame is
never shown.

- Expanded `showLoadingPlaceholders`, `vListItemCount`, and the
container `opacity` to include the `!isReady` case, so skeleton
placeholders are shown immediately during the reload rather than leaving
an invisible list.

### Before / After

| Before | After |
|--------|-------|
| Room goes blank for ~500 ms on foreground return | Skeleton
placeholders appear instantly, then content fades in |

Fixes #

### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

## Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings

## AI disclosure:

Fully AI generated (explain what all the generated code does in moderate
detail).

The `useLayoutEffect` guard and the three `!isReady` condition
expansions were fully AI generated. The effect fires synchronously
before paint when `eventsLength` drops to 0 on an already-visible
timeline, hides content and resets the initial-scroll flag. The existing
80 ms scroll timer then re-runs once events refill and calls
`setIsReady(true)`. The `showLoadingPlaceholders` / `vListItemCount`
changes ensure VList renders 3 placeholder skeleton rows (matching the
existing pagination-loading behaviour) while events are absent.
2026-04-10 02:41:17 +00:00
7w1 35e147a564 Feat: Add the ability to set Global Name Colors dependent on the theme (dark/light) (#656)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
This PR proposes the ability to set up different Global Name Colors with
the purpose of making names easier to read for everyone independent on
which theme they might choose to use.

The Global Name Colors options are the General for legacy puroses, Dark
and Light Theme.

(example of the issue)
<img width="620" height="565" alt="image"
src="https://github.com/user-attachments/assets/ba3e5abd-b390-4fea-864d-ff290507efd3"
/>
Here the names of 7w1, Shea, Lunia and potentially Haz are hard to read
if one chooses to use a Light theme.

(example of the name Shea being corrected for using this PR)
<img width="619" height="568" alt="image"
src="https://github.com/user-attachments/assets/11720d83-573d-442f-9ee6-139e294089ab"
/>

This PR also reorganizes the setting for the Global Name Colors location
in order to align it more to the style of the other settings:
<img width="817" height="696" alt="image"
src="https://github.com/user-attachments/assets/ef25c513-9503-4a05-bed9-0ba81a10e188"
/>

And puts the Save button to the left as to not move the text box and the
selector button when it appears:
<img width="816" height="699" alt="image"
src="https://github.com/user-attachments/assets/9df3e1bc-1951-4d7a-a931-44a05e9156b1"
/>

#### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
My anxiety about the future helped me overthink the solution into
existence
2026-04-10 02:40:19 +00:00
Evie Gauthier 3aacd916db chore: add changeset for timeline-blank-on-foreground fix 2026-04-09 15:13:11 -04:00
Evie Gauthier dc5dbfdf4f fix(timeline): show skeleton placeholders while timeline reloads on foreground 2026-04-09 14:04:59 -04:00
Evie Gauthier 42b758258a fix(timeline): re-arm initial-scroll when TimelineReset blanks the view
When the app returns from background, retryImmediately() triggers a fresh
sliding sync response. If the server includes initial:true for the open room,
the SDK emits RoomEvent.TimelineReset, replacing the live timeline with a new
empty one. eventsLength drops to 0 but isReady stays true, leaving the message
list visible but empty for ~500 ms until events re-arrive.

Add a useLayoutEffect that detects eventsLength dropping to 0 while the timeline
is already visible (isReady === true). It hides the content (opacity 0) and
resets hasInitialScrolledRef so the initial-scroll effect re-arms. When events
refill the timeline the existing 80 ms scroll timer fires again and sets
isReady back to true, revealing the content.
2026-04-09 13:31:06 -04:00
7w1 f82446a2c6 fix: prevent iOS overscroll on root element (#650)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

Adds `overscroll-behavior: none` to the `html` element to prevent the
elastic bounce-back scroll on iOS from competing with the timeline
scroll.

Fixes #500

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).

The CSS property addition (`overscroll-behavior: none` on the `html`
selector) was suggested by an AI tool. It sets the browser's overscroll
behavior to prevent the elastic bounce effect on iOS from propagating to
the root element, which was causing the timeline scroll to fight with
the page-level bounce-back.
2026-04-09 16:21:04 +00:00
7w1 1ac0b08294 fix: constrain bug report modal to viewport height (#652)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

Constrains the bug report modal to 90vh max height so it doesn't
overflow the viewport, which was cropping the close button and header
text.

Fixes #629

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).

The `maxHeight` and `overflow` style additions to `BugReportModal.tsx`
were written alongside an AI tool. The changes add `maxHeight: '90vh'`
to the MUI Modal component and its inner Box container, with `overflow:
'hidden'` on the Box to prevent the modal from growing beyond the
viewport. The inner content area uses `overflowY: 'auto'` so the form
fields remain scrollable within the constrained modal.
2026-04-09 16:20:22 +00:00
7w1 55d5ed9972 Fix dm navigation breaking (#653)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->

Fixes the DMs button in the side bar taking you to a page than isn't a
dm.
The DM button just restores a page navigation from local storage, so if
that local storage is messed up somehow, then you can't get to dms. This
adds a check to ensure you always go to dms.

How this happened to me? I have no idea.

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
2026-04-09 11:19:48 -05:00
Shea Duma a556efe530 make the text and bubble not move around 2026-04-09 07:32:25 +03:00