<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
This PR proposes styling the misc data (the fields from extended profile
that sable does not recognize) in a more robust form, with json
formatting, and tapping through the options in order to have a clear
visual differentiation between it and anything else.
(current view for an example from someone using a different client and
thus having different fields)
<img width="350" height="701" alt="image"
src="https://github.com/user-attachments/assets/996bbcef-f7cf-4bbb-8667-051181d72835"
/>
(proposed new view, with the badge key selected)
<img width="344" height="661" alt="image"
src="https://github.com/user-attachments/assets/09cb347d-d287-477b-9562-5854ab09905b"
/>
(proposed new view when selecting an item)
<img width="345" height="564" alt="image"
src="https://github.com/user-attachments/assets/e52d18af-ae60-4747-9fd6-eef086373fe1"
/>
<img width="345" height="653" alt="image"
src="https://github.com/user-attachments/assets/9252b65f-d8ea-4926-8793-1b9ddff99b0a"
/>
(proposed view when there is only one key, and showing it is selected)
<img width="346" height="573" alt="image"
src="https://github.com/user-attachments/assets/4003f601-ddf4-44e9-b05d-4c07a4015033"
/>
Fixes #
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
My partner's avocado gasped the implementation as its last breath before
rotting away
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
Fixes#646
Changed settings link behavior to use a query parameter marker instead,
this avoids hardcoding `app.sable.moe`, keeps links valid on non-Sable
clients, and lets self-hosted Sable instances recognize links copied
from other Sable instances without misclassifying arbitrary third-party
`/settings/...` URLs.
Example:
`https://client.example/settings/account?focus=display-name&moe.sable.client.action=settings`
Edit:
I've ended up expanding the scope of the PR. Thanks to some suggestions
from @dozro and also general QoL improvements.
- Settings link URLs now get rewritten when sent from the RoomInput by
turning bare settings URLs into markdown links, so they look better on
non-Sable clients.
- Example on non-Sable clients: [Settings > Emojis & Stickers > Select
Pack](http://localhost:8080/settings/emojis?focus=select-pack&moe.sable.client.action=settings)
- Raw markdown sent: `[Settings > Emojis & Stickers > Select
Pack](http://localhost:8080/settings/emojis?focus=select-pack&moe.sable.client.action=settings)`
- Hardened settings link detection to avoid misclassifying invalid or
malformed URLs as settings links.
- Added validation so a settings link only renders as a settings chip if
it points to a real shareable settings target that exists.
- Invalid or malformed settings-looking URLs now fall back to normal
links instead of rendering as settings chips or trying to open invalid
focus targets.
- Fixed a styling issue where the settings link chip was not vertically
aligned with surrounding text.
- Removed settings links from dynamic/user-driven rows, such as emoji
packs and similar targets that are not stable to share across clients or
instances.
Migration note:
- `settingsLinkBaseUrl` is no longer used and can be removed from
`config.json`.
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
> Related to closed PR #548 (`fix/media-error-handling`), which was
split into smaller focused PRs.
### Description
Without explicit `Cache-Control` headers, browsers apply heuristic
caching to all responses — including `sw.js` and `index.html`. This
causes stale service workers and stale app shells to persist after a
deploy. Three header rules added to the Caddyfile:
- `/assets/*` — `public, max-age=31536000, immutable`: content-hashed
filenames change on every build, so these are safe to cache permanently.
- `/sw.js` — `no-cache`: must always be revalidated so the browser picks
up SW updates promptly.
- `/index.html` — `no-cache`: must always be revalidated so the browser
gets the latest asset hashes on load.
Fixes #
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
The cache header rules were partially AI assisted. I verified the
`immutable` directive is appropriate for content-hashed assets and that
`no-cache` (revalidate-always, not no-store) is correct for `sw.js` and
`index.html`.
> Related to closed PR #548 (`fix/media-error-handling`), which was
split into smaller focused PRs.
### Description
`injectionPoint: undefined` was set in `vite.config.ts` to silence a
Workbox `AssertionError` about multiple `self.__WB_MANIFEST` occurrences
(an `if` guard in `sw.ts` plus the `precacheAndRoute()` call = two
matches; Workbox requires exactly one). The unintended consequence:
Workbox never injected the precache manifest, so **no assets were
precached** — every cold start hit the network instead of serving from
cache, and offline use was broken entirely.
Fix: remove the `if` guard in `sw.ts` (leaving exactly one
`self.__WB_MANIFEST` reference) then remove `injectionPoint: undefined`
from `vite.config.ts` to restore normal precaching behaviour.
Fixes #
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
The root cause diagnosis (two `self.__WB_MANIFEST` references causing
Workbox to silently skip injection) was identified with AI assistance. I
verified the fix by checking Workbox's `injectionPoint` behaviour and
confirming precaching was restored.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Fixes the first message showing as empty because it is expecting a
prevContent
Fixes #
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
Having a hard time to think of a pun here made me optimize the fix
instead.
> Related to closed PR #598 (`fix/perf-rerender-reduction`), which was
split into smaller focused PRs.
### Description
Buttons inside VList rows were applying a CSS `transform` on `:hover`.
Because VList row elements use `position: relative` with `will-change:
transform` for virtualisation, the button transform was composited
against the row's own transform layer, producing a visual smear — the
button appeared to shift or blur while the row stayed in place.
Fix: add a scoped CSS override in `General.css.ts` that resets
`transform: none` on `:hover` for buttons inside VList row containers.
Fixes #
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
The CSS override was partially AI assisted. I identified the smearing
symptom and verified that the transform interaction between VList row
layers and button hover state was the cause before applying the fix.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Checks if the click is real and returns; if it isn't
Fixes#588
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
A Cupid with a Yellow Rose hit me with its arrow that had fix wrapped
around the shaft <3
The catch-all [data-index] button:hover and [data-index] [role="button"]:hover
selectors already cover every button variant inside VList items, making the
intermediate class-specific selectors redundant. Remove them.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Fix statuses sticking from optimization and badge showing the wrong pfp
in the DM list
(same 2 'people' in this chat, both dm chat, showing the right pfp with
their statuses fixed)
<img width="317" height="164" alt="image"
src="https://github.com/user-attachments/assets/5fd789bb-0aba-4a5b-bf28-70ba4bdd0d22"
/>
Fixes Issue mentioned in the space
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
A sleep paralysis demon moved my body as to type the fix
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Update support buttons to point to https://opencollective.com/sable
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
📝 **Docs:** Already live at [Threads — Sable
Docs](https://docs.sable.moe/new-features/threads/) — no separate docs
PR needed.
---
### Description
Expands Matrix thread support with a full thread drawer, server-side
thread browser, live reply counts, unread badges, and several UX fixes.
#### ThreadDrawer
- Slide-in drawer for reading and replying in threads without leaving
the main room
- Thread root message shown at top with full reply history below
- Up-arrow edit-last-message: pressing ↑ in the thread input edits the
user's last own message in that thread
- Reactions add/remove trigger immediate re-renders without manual
refresh (handles the fact that reaction events carry
`m.relates_to.event_id` not `threadRootId` directly — fetches target
event to check thread membership)
- Thread root message box sized to content with `maxHeight: 200px` to
avoid dead whitespace on short messages
#### ThreadBrowser
- Lists all threads in the room; calls `room.fetchRoomThreads()` on
mount to load threads beyond the local timeline window
- Load-more button when the server has additional thread pages
- Each thread preview shows sender avatar, display name, reply count,
and last message body with ellipsis truncation
- Jump button navigates to the thread root in the main timeline (via
`useRoomNavigate`) instead of re-opening the drawer
- Thread unread badges on each preview item via
`room.getThreadUnreadNotificationCount()`
#### ThreadReplyChip (main timeline)
- Shows unread badge for threads with unseen replies via
`room.getThreadUnreadNotificationCount()`
#### Thread button (RoomViewHeader)
- If a thread drawer is open, button closes the drawer and opens the
thread browser (allows going from a single thread to the full list)
- If no thread is open, button toggles the thread browser as before
- `aria-pressed` reflects both thread browser state and open thread
drawer
Fixes #
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does)
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail)
ThreadDrawer/ThreadBrowser/thread-chip iterations were partially AI
assisted; I reviewed and adjusted logic for timeline processing, thread
loading, and event rendering behavior.