fix(android): activate room context menu items on pointerup (#1281)

<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

On Android WebView, the long-press that opens the room context menu
suppresses the first synthesized click, so every menu item did nothing.

Activate on pointerup (with movement + duration thresholds) instead the
same pattern used for room-row navigation. Desktop unchanged.

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
This commit is contained in:
7w1 authored and GitHub committed 2026-07-24 15:34:21 +00:00
commit c2287d7f52
4 files changed
+69 -18

No files matched your search

@@ -0,0 +1,5 @@
---
default: patch
---
Activate room context menu items on pointerup on Android to work around WebView click synthesis being suppressed after the long-press gesture that opens the mobile menu.
+23
View File
@@ -0,0 +1,23 @@
import type { ComponentProps, MouseEventHandler } from 'react';
import { MenuItem } from 'folds';
import { useMobileTapActivation } from '$hooks/useMobileTapActivation';
type MenuItemProps = ComponentProps<typeof MenuItem>;
type MobileMenuItemProps = Omit<MenuItemProps, 'onClick'> & {
isMobile: boolean;
onClick?: MouseEventHandler<HTMLButtonElement>;
};
/**
* Wraps folds' `MenuItem` with pointer-based tap activation for Android
* WebView, where click synthesis is suppressed after the long-press gesture
* that opens the mobile swipe-down modal. On mobile the `onClick` handler
* fires on `pointerup` instead of relying on the missing click event.
*/
export function MobileMenuItem({ isMobile, onClick, ...props }: MobileMenuItemProps) {
const activation = useMobileTapActivation<HTMLButtonElement>(isMobile, (evt) => {
onClick?.(evt);
});
return <MenuItem onClick={onClick} {...activation} {...props} />;
}
+38 -15
View File
@@ -9,7 +9,6 @@ import {
IconButton,
Text,
Menu,
MenuItem,
config,
PopOut,
toRem,
@@ -62,6 +61,7 @@ import {
} from '$components/icons/phosphor';
import { Copy as CopyIcon } from '@phosphor-icons/react';
import { MobileSwipeDownModal } from '$components/MobileSwipeDownModal';
import { MobileMenuItem } from '$components/MobileMenuItem';
import { type DragOptsProps } from '$components/message/modals/Options';
import * as messageCss from '$features/room/message/styles.css';
import {
@@ -125,6 +125,7 @@ type RoomNavItemMenuProps = {
const RoomNavItemMenu = forwardRef<HTMLDivElement, RoomNavItemMenuProps>(
({ room, requestClose, notificationMode, dragOpts }, ref) => {
const mx = useMatrixClient();
const isMobile = useScreenSizeContext() === ScreenSize.Mobile;
const [hideReads] = useSetting(settingsAtom, 'hideReads');
const unread = useRoomUnread(room.roomId, roomToUnreadAtom);
const powerLevels = usePowerLevels(room);
@@ -184,7 +185,8 @@ const RoomNavItemMenu = forwardRef<HTMLDivElement, RoomNavItemMenuProps>(
/>
)}
<Box direction="Column" gap="100" style={{ padding: config.space.S100 }}>
<MenuItem
<MobileMenuItem
isMobile={isMobile}
onClick={handleMarkAsRead}
size="300"
after={menuIcon(Checks)}
@@ -194,10 +196,11 @@ const RoomNavItemMenu = forwardRef<HTMLDivElement, RoomNavItemMenuProps>(
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Mark as Read
</Text>
</MenuItem>
</MobileMenuItem>
<RoomNotificationModeSwitcher roomId={room.roomId} value={notificationMode}>
{(handleOpen, opened, changing) => (
<MenuItem
<MobileMenuItem
isMobile={isMobile}
size="300"
after={
changing ? (
@@ -213,13 +216,14 @@ const RoomNavItemMenu = forwardRef<HTMLDivElement, RoomNavItemMenuProps>(
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Notifications
</Text>
</MenuItem>
</MobileMenuItem>
)}
</RoomNotificationModeSwitcher>
</Box>
<Line variant="Surface" size="300" />
<Box direction="Column" gap="100" style={{ padding: config.space.S100 }}>
<MenuItem
<MobileMenuItem
isMobile={isMobile}
onClick={handleInvite}
variant="Primary"
fill="None"
@@ -232,29 +236,48 @@ const RoomNavItemMenu = forwardRef<HTMLDivElement, RoomNavItemMenuProps>(
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Invite
</Text>
</MenuItem>
<MenuItem onClick={handleCopyLink} size="300" after={menuIcon(Link)} radii="300">
</MobileMenuItem>
<MobileMenuItem
isMobile={isMobile}
onClick={handleCopyLink}
size="300"
after={menuIcon(Link)}
radii="300"
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Copy Link
</Text>
</MenuItem>
<MenuItem onClick={handleCopyName} size="300" after={menuIcon(CopyIcon)} radii="300">
</MobileMenuItem>
<MobileMenuItem
isMobile={isMobile}
onClick={handleCopyName}
size="300"
after={menuIcon(CopyIcon)}
radii="300"
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Copy Room Name
</Text>
</MenuItem>
<MenuItem onClick={handleRoomSettings} size="300" after={menuIcon(GearSix)} radii="300">
</MobileMenuItem>
<MobileMenuItem
isMobile={isMobile}
onClick={handleRoomSettings}
size="300"
after={menuIcon(GearSix)}
radii="300"
>
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Room Settings
</Text>
</MenuItem>
</MobileMenuItem>
</Box>
<Line variant="Surface" size="300" />
<Box direction="Column" gap="100" style={{ padding: config.space.S100 }}>
<UseStateProvider initial={false}>
{(promptLeave, setPromptLeave) => (
<>
<MenuItem
<MobileMenuItem
isMobile={isMobile}
onClick={() => setPromptLeave(true)}
variant="Critical"
fill="None"
@@ -266,7 +289,7 @@ const RoomNavItemMenu = forwardRef<HTMLDivElement, RoomNavItemMenuProps>(
<Text style={{ flexGrow: 1 }} as="span" size="T300" truncate>
Leave Room
</Text>
</MenuItem>
</MobileMenuItem>
{promptLeave && (
<LeaveRoomPrompt
roomId={room.roomId}
+3 -3
View File
@@ -1,4 +1,4 @@
import type { PointerEventHandler } from 'react';
import type { PointerEventHandler, PointerEvent as ReactPointerEvent } from 'react';
import { useRef } from 'react';
const TAP_MOVEMENT_THRESHOLD = 10;
@@ -10,7 +10,7 @@ const MAX_TAP_DURATION = 500;
// or defer it. That reintroduces the double-tap.
export function useMobileTapActivation<T extends HTMLElement>(
enabled: boolean,
onActivate: () => void
onActivate: (evt: ReactPointerEvent<T>) => void
): {
onPointerDown: PointerEventHandler<T>;
onPointerMove: PointerEventHandler<T>;
@@ -70,7 +70,7 @@ export function useMobileTapActivation<T extends HTMLElement>(
}
evt.preventDefault();
onActivateRef.current();
onActivateRef.current(evt);
};
const onPointerCancel: PointerEventHandler<T> = (evt) => {
if (evt.pointerId !== pointerDownRef.current?.pointerId) return;