refactor: remove redundant room-nav props/guards and minor naming cleanup

This commit is contained in:
hazre committed 2026-02-19 23:41:33 +01:00
1 parent ff3def0f72
commit 7f1a4656eb
3 files changed
+5 -7

No files matched your search

@@ -217,7 +217,6 @@ const RoomNavItemMenu = forwardRef<HTMLDivElement, RoomNavItemMenuProps>(
);
}
);
RoomNavItemMenu.displayName = 'RoomNavItemMenu';
type RoomNavItemProps = {
room: Room;
@@ -369,7 +368,6 @@ export function RoomNavItem({
size="100"
joinRule={room.getJoinRule()}
roomType={room.getType()}
locked={room.isCallRoom() && !canJoinCall}
/>
)}
</Avatar>
+4 -4
View File
@@ -28,14 +28,14 @@ export function RoomNavUser({ room, callMembership }: RoomNavUserProps) {
const avatarUrl = avatarMxcUrl
? mx.mxcUrlToHttp(avatarMxcUrl, 32, 32, 'crop', undefined, false, useAuthentication)
: undefined;
const getName = getMemberDisplayName(room, userId) ?? getMxIdLocalPart(userId);
const name = getMemberDisplayName(room, userId) ?? getMxIdLocalPart(userId);
const isCallParticipant = isActiveCall && userId !== mx.getUserId();
const handleNavUserClick: React.MouseEventHandler<HTMLButtonElement> = (evt) => {
openProfile(room.roomId, space?.roomId, userId, evt.currentTarget.getBoundingClientRect());
};
const ariaLabel = isCallParticipant ? `Call Participant: ${getName}` : getName;
const ariaLabel = isCallParticipant ? `Call Participant: ${name}` : name;
return (
<NavItem variant="Background" radii="400">
@@ -47,12 +47,12 @@ export function RoomNavUser({ room, callMembership }: RoomNavUserProps) {
<UserAvatar
userId={userId}
src={avatarUrl ?? undefined}
alt={getName}
alt={name}
renderFallback={() => <Icon size="50" src={Icons.User} filled />}
/>
</Avatar>
<Text as="span" size="B400" priority="300" truncate>
{getName}
{name}
</Text>
</Box>
</Box>
+1 -1
View File
@@ -298,7 +298,7 @@ function SpaceHeader() {
escapeDeactivates: stopPropagation,
}}
>
{space && <SpaceMenu room={space} requestClose={() => setMenuAnchor(undefined)} />}
<SpaceMenu room={space} requestClose={() => setMenuAnchor(undefined)} />
</FocusTrap>
}
/>