Files
Sven WeidenmannandClaude Opus 4.7 a475a5a562 perf(globe): replace viewer mutation with WeakMap<Viewer, Collections> [Patch]
Primitive collections (points, billboards, labels, polylines) were
attached directly to the Cesium Viewer instance as `_wwvX` properties
behind `(viewer as any)` casts. This created hidden coupling, blocked
multi-viewer setups, and left ~11 `as any` casts across three files.

Replace the viewer-mutation pattern with a module-level
`WeakMap<CesiumViewer, PrimitiveCollections>`:

- `initPrimitiveCollections` now writes into the WeakMap
- `getCollections` reads from the WeakMap and returns a destructurable
  shape with optional fields, preserving the existing call pattern
- `AnimationLoop` and `useEntityRendering` use `getCollections(viewer)`
  instead of direct `(viewer as any)._wwvX` reads
- Zero `(viewer as any)._wwv*` remain; collections GC cleanly when
  the viewer is dropped

Adds `src/core/globe/EntityRenderer.test.ts` with 7 tests covering:
- WeakMap roundtrip (init populates, getCollections retrieves, per-viewer
  isolation, graceful no-scene)
- Defer-clone behaviour from the previous commit (no clone on
  iconUrl/model path; clone on auto-SVG path; original untouched)

Refs #95

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
2026-05-13 16:42:12 -04:00
..
2026-05-13 16:20:59 +12:00