* chore(merge): resolve conflicts, fix mockWs error, and apply refactor standards
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* fix(ci): Stabilize github actions and resolve test failures
- fix(tests): update WsClient mock to use standard function for Vitest constructor compatibility
- fix(db): correct PrismaClient import path to use generated output directory
- fix(e2e): add predev database boot step to playwright CI workflow
- chore: sync pnpm-lock.yaml after merge conflict resolution
* refactor(plugins): decouple GeoJSON plugin and implement data bus lifecycle
- feat(sdk): [Minor] Added dynamicPluginCreate, dynamicPluginRemove, and pluginUnregistered to DataBusEvents.
- feat(core): [Minor] Implemented unregisterPlugin in PluginManager.ts for automated IndexedDB caching cleanup and polling teardown.
- feat(core): [Minor] Added removeLayer to layersSlice.ts to support safe removal of plugin states.
- refactor(plugins): [Patch] Refactored useGeoJsonImport.ts and ImportedLayerList.tsx to decouple from direct manager imports, utilizing DataBus for lifecycle events.
- refactor(core): [Patch] Added pluginUnregistered listener to DataBusSubscriber.tsx to handle state and cache cleanup synchronously via event.
* fix(types): resolve PluginManager type errors
* refactor(core): decouple PluginManager and fix rendering invariants
- refactor(core): Replace Zustand mutations in PluginManager with DataBus events (Patch)
- refactor(sdk): Add layerLoadingChanged, pluginError, pluginUnregistered to DataBusEvents (Patch)
- refactor(ui): Subscribe to new DataBus events in DataBusSubscriber (Patch)
- fix(plugins): Remove size from BaseAviationPlugin to fix model rendering clipping (Patch)
- fix(plugins): Migrate BaseIncidentPlugin from size to iconScale to fix billboard clipping (Patch)
* chore: resolve lockfile conflict
* fix: restore BottomPanelManager in AppShell and fix vitest config
* fix(layout): restore bottom panel positioning and transition styling
This commit corrects the missing bottom panel issue by resolving CSS aggregation errors and fixing transition logic. The version is bumped to 2.15.5.
* refactor(core): harden typescript and fix linting violations
This commit addresses the remaining any types and linting errors across the core engine.
* fix(eslint): resolve react-hook immutability and cascading render violations
---------
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* fix: package.json to reduce vulnerabilities
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-WS-16722635
* fix: update pnpm-lock.yaml for ws dependency bump and bump version to 2.15.11
---------
Co-authored-by: snyk-bot <[email protected]>
* fix: package.json to reduce vulnerabilities
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-WS-16722635
* fix: update pnpm-lock.yaml for ws dependency bump and bump version to 2.15.11
---------
Co-authored-by: snyk-bot <[email protected]>
* chore(merge): resolve conflicts, fix mockWs error, and apply refactor standards
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* fix(ci): Stabilize github actions and resolve test failures
- fix(tests): update WsClient mock to use standard function for Vitest constructor compatibility
- fix(db): correct PrismaClient import path to use generated output directory
- fix(e2e): add predev database boot step to playwright CI workflow
- chore: sync pnpm-lock.yaml after merge conflict resolution
* refactor(plugins): decouple GeoJSON plugin and implement data bus lifecycle
- feat(sdk): [Minor] Added dynamicPluginCreate, dynamicPluginRemove, and pluginUnregistered to DataBusEvents.
- feat(core): [Minor] Implemented unregisterPlugin in PluginManager.ts for automated IndexedDB caching cleanup and polling teardown.
- feat(core): [Minor] Added removeLayer to layersSlice.ts to support safe removal of plugin states.
- refactor(plugins): [Patch] Refactored useGeoJsonImport.ts and ImportedLayerList.tsx to decouple from direct manager imports, utilizing DataBus for lifecycle events.
- refactor(core): [Patch] Added pluginUnregistered listener to DataBusSubscriber.tsx to handle state and cache cleanup synchronously via event.
* fix(types): resolve PluginManager type errors
* refactor(core): decouple PluginManager and fix rendering invariants
- refactor(core): Replace Zustand mutations in PluginManager with DataBus events (Patch)
- refactor(sdk): Add layerLoadingChanged, pluginError, pluginUnregistered to DataBusEvents (Patch)
- refactor(ui): Subscribe to new DataBus events in DataBusSubscriber (Patch)
- fix(plugins): Remove size from BaseAviationPlugin to fix model rendering clipping (Patch)
- fix(plugins): Migrate BaseIncidentPlugin from size to iconScale to fix billboard clipping (Patch)
* chore: resolve lockfile conflict
* fix: restore BottomPanelManager in AppShell and fix vitest config
* fix(layout): restore bottom panel positioning and transition styling
This commit corrects the missing bottom panel issue by resolving CSS aggregation errors and fixing transition logic. The version is bumped to 2.15.5.
* refactor(core): harden typescript and fix linting violations
This commit addresses the remaining any types and linting errors across the core engine.
* fix(eslint): resolve react-hook immutability and cascading render violations
---------
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* chore(merge): resolve conflicts, fix mockWs error, and apply refactor standards
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* fix(ci): Stabilize github actions and resolve test failures
- fix(tests): update WsClient mock to use standard function for Vitest constructor compatibility
- fix(db): correct PrismaClient import path to use generated output directory
- fix(e2e): add predev database boot step to playwright CI workflow
- chore: sync pnpm-lock.yaml after merge conflict resolution
* refactor(plugins): decouple GeoJSON plugin and implement data bus lifecycle
- feat(sdk): [Minor] Added dynamicPluginCreate, dynamicPluginRemove, and pluginUnregistered to DataBusEvents.
- feat(core): [Minor] Implemented unregisterPlugin in PluginManager.ts for automated IndexedDB caching cleanup and polling teardown.
- feat(core): [Minor] Added removeLayer to layersSlice.ts to support safe removal of plugin states.
- refactor(plugins): [Patch] Refactored useGeoJsonImport.ts and ImportedLayerList.tsx to decouple from direct manager imports, utilizing DataBus for lifecycle events.
- refactor(core): [Patch] Added pluginUnregistered listener to DataBusSubscriber.tsx to handle state and cache cleanup synchronously via event.
* fix(types): resolve PluginManager type errors
* refactor(core): decouple PluginManager and fix rendering invariants
- refactor(core): Replace Zustand mutations in PluginManager with DataBus events (Patch)
- refactor(sdk): Add layerLoadingChanged, pluginError, pluginUnregistered to DataBusEvents (Patch)
- refactor(ui): Subscribe to new DataBus events in DataBusSubscriber (Patch)
- fix(plugins): Remove size from BaseAviationPlugin to fix model rendering clipping (Patch)
- fix(plugins): Migrate BaseIncidentPlugin from size to iconScale to fix billboard clipping (Patch)
* chore: resolve lockfile conflict
* fix: restore BottomPanelManager in AppShell and fix vitest config
* fix(layout): restore bottom panel positioning and transition styling
This commit corrects the missing bottom panel issue by resolving CSS aggregation errors and fixing transition logic. The version is bumped to 2.15.5.
---------
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* chore(merge): resolve conflicts, fix mockWs error, and apply refactor standards
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* Potential fix for pull request finding 'CodeQL / Incomplete URL substring sanitization'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* fix(ci): Stabilize github actions and resolve test failures
- fix(tests): update WsClient mock to use standard function for Vitest constructor compatibility
- fix(db): correct PrismaClient import path to use generated output directory
- fix(e2e): add predev database boot step to playwright CI workflow
- chore: sync pnpm-lock.yaml after merge conflict resolution
* refactor(plugins): decouple GeoJSON plugin and implement data bus lifecycle
- feat(sdk): [Minor] Added dynamicPluginCreate, dynamicPluginRemove, and pluginUnregistered to DataBusEvents.
- feat(core): [Minor] Implemented unregisterPlugin in PluginManager.ts for automated IndexedDB caching cleanup and polling teardown.
- feat(core): [Minor] Added removeLayer to layersSlice.ts to support safe removal of plugin states.
- refactor(plugins): [Patch] Refactored useGeoJsonImport.ts and ImportedLayerList.tsx to decouple from direct manager imports, utilizing DataBus for lifecycle events.
- refactor(core): [Patch] Added pluginUnregistered listener to DataBusSubscriber.tsx to handle state and cache cleanup synchronously via event.
* fix(types): resolve PluginManager type errors
* refactor(core): decouple PluginManager and fix rendering invariants
- refactor(core): Replace Zustand mutations in PluginManager with DataBus events (Patch)
- refactor(sdk): Add layerLoadingChanged, pluginError, pluginUnregistered to DataBusEvents (Patch)
- refactor(ui): Subscribe to new DataBus events in DataBusSubscriber (Patch)
- fix(plugins): Remove size from BaseAviationPlugin to fix model rendering clipping (Patch)
- fix(plugins): Migrate BaseIncidentPlugin from size to iconScale to fix billboard clipping (Patch)
* chore: resolve lockfile conflict
---------
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* feat(testing): add Playwright E2E infrastructure and stabilize test suite
- Add Playwright E2E configuration and ui-navigation / plugin-system tests
- Add GitHub Actions workflow for Playwright CI tests
- Add test helpers and fixtures (e2e-mock-plugin)
- fix(testing): resolve UnverifiedPluginBatchDialog UI blocking issue in E2E tests
- fix(testing): limit Playwright to 2 workers locally to avoid Next.js/Prisma exhaustion
- fix(api): replace deprecated processAuthCodeResponse with authorizationCodeGrant
- test(ui): add data-testid to PanelToggleArrows and AppShell
* Potential fix for pull request finding 'CodeQL / Workflow does not contain permissions'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* fix(ci): restrict GITHUB_TOKEN permissions to read contents
* docs(e2e): document Playwright infrastructure and mock plugin lifecycle
* fix(e2e): explicitly load .env in teardown and fix dev command pathing
* fix(ci): resolve playwright environment setup and database initialization
Changes:
- Patch: Added pnpm run setup step to .github/workflows/playwright.yml to generate .env in CI
- Patch: Added explicit loadEnv() helper to ests/global.setup.ts and ests/global.teardown.ts to ensure database credentials are fresh
- Patch: Hardened scripts/safe-db-push.mjs to detect missing DATABASE_URL and explicitly prompt for pnpm run setup rather than assuming production
- Patch: Updated scripts/dev.mjs to execute pnpm exec next dev instead of raw
ext dev to resolve pathing issues
- Patch: Bumped version in package.json to 2.14.4
---------
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
* feat(dx): implement worktree DB orchestration and graceful dev teardown
- feat(dx): [Minor] Implement deterministic port binding per git worktree
to mitigate Docker port conflicts during parallel development.
- feat(dx): [Minor] Implement graceful development environment teardown
using a custom node orchestrator (scripts/dev.mjs) replacing CLI concurrently,
enabling cross-platform tree-kill and optional DB stopping on exit.
- build(deps): Add tree-kill for process termination.
- fix(dx): Prevent rm -rf from orphaning Docker volumes by adding
a db:prune script and tying volume cleanup to git-wt remove.
* fix: update openid-client api usage to v6 and resolve db import
- Migrated processAuthCodeResponse to authorizationCodeGrant
- Updated db import to export prisma client correctly
- Updated unit tests with v6 openid-client mocks
- Bumped version to 2.13.1
* fix(ci): setup .env from example in local dev CI test
- Add PBKDF2 + AES-256-GCM encryption for credentials
- Update Prisma schema to include MarketplaceCredential
- Implement comprehensive SSRF utility with IP pinning
- Harden /api/camera/proxy and stream proxy with safeFetch
- Fix openid-client PKCE generator usage
- Update workspace configurations and ADRs
- Bump version to 2.10.0 (Minor)
* refactor(docker): separate self-host Docker compose structure from development
test(ci): add github action to verify self-host scripts
* Potential fix for pull request finding 'CodeQL / Workflow does not contain permissions'
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
---------
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Resolves three high+critical advisories surfaced by the dependency
audit added in PR #104:
CRITICAL form-data <2.5.4 GHSA-fjxv-7rqg-78g4 unsafe random boundary
HIGH fast-uri <=3.1.0 GHSA-q3j6-qgpj-74h6 path traversal
HIGH fast-uri <=3.1.1 GHSA-v39h-62p7-jpjc host confusion
form-data was 2.3.3 transitively via insecam-api -> [email protected].2.
fast-uri was 3.1.0 via @sentry/webpack-plugin -> webpack -> schema-utils
-> ajv (15 paths total).
Uses scoped pnpm overrides keyed on the vulnerable version ranges so
each major release line is patched in place: form-data stays in 2.x
(2.3.3 -> 2.5.5) rather than jumping to 4.x and risking compatibility
with the long-abandoned `request` package. Overrides for form-data 3.x
and 4.x are pre-emptive -- no current matches in the tree, but they
future-proof against new deps pulling vulnerable form-data versions.
After install, `pnpm audit --audit-level high` returns exit 0.
Five moderate findings remain (request SSRF, tough-cookie, qs,
@hono/node-server, postcss) -- all below the CI threshold and
addressable in a follow-up.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Consolidates four overlapping test-infra PRs (#113, #114, #117, #118)
into a single coherent batch. Each contributing PR has redundancies
with one or more of the others; together they ship a real ~134-test
expansion of the unit suite plus mutation-testing infrastructure.
Same shape as #110 / #111: small, focused, behavior-pinning tests
against load-bearing systems. Each test answers one question — *what
specific regression does it catch that I'd otherwise find from a user
bug report?* Tests pin observable contracts (events emitted, cache
entries written, public-API state) rather than internal mechanics, so
they survive refactors during the longer-term migration toward the
six-interface architecture.
## What's in this PR
### Stryker mutation testing (new in this batch)
- `stryker.config.json` — hybrid config: `coverageAnalysis: "perTest"`
for the 5–10× speedup on a real codebase, `ignoreStatic: true` to
drop false-positive mutants in module-load code, and a `mutate`
scope of `src/core/**` + `src/lib/**` covering the logic-heavy
layers without dragging the React component surface into noise.
- `.github/workflows/mutation-testing.yml` — runs Stryker on a weekly
schedule (Sundays 22:00 US Eastern / 03:00 UTC Monday) plus
`workflow_dispatch` for on-demand validation. Per-PR triggering
would be too expensive (10–30 min per run even with `perTest`).
- `package.json` — adds `@stryker-mutator/core`, `@stryker-mutator/vitest-runner`,
and `fast-check` as devDependencies. New `test:mutate` script.
### New test files (22 added)
Plugin lifecycle and loaders:
- `src/core/plugins/PluginManager.test.ts` — orchestrator lifecycle:
register, enable, disable, data-flow contract, getAllEntities
filters by enabled, updateTimeRange, destroy, togglePlugin,
loadFromManifest. 11 tests.
- `src/core/plugins/loadPluginFromManifest.test.ts`
- `src/core/plugins/validateManifest.test.ts`
- `src/core/plugins/loaders/mapGeoJsonToEntities.test.ts`
- `src/core/plugins/loaders/mapJsonToEntities.test.ts`
Data layer:
- `src/core/data/DataUtils.test.ts`
- `src/core/data/WsClient.test.ts`
State (9 Zustand slices + the integration tests):
- `src/core/state/StateSlices.test.ts`
- `src/core/state/configSlice.test.ts`
- `src/core/state/dataSlice.test.ts`
- `src/core/state/favoritesSlice.test.ts`
- `src/core/state/filterSlice.test.ts`
- `src/core/state/geojsonSlice.test.ts`
- `src/core/state/globeSlice.test.ts`
- `src/core/state/layersSlice.test.ts`
- `src/core/state/timelineSlice.test.ts`
- `src/core/state/uiSlice.test.ts`
Filters:
- `src/core/filters/filterEngine.test.ts`
Library:
- `src/lib/AuthConfig.test.ts`
- `src/lib/analytics.test.ts`
- `src/lib/origin.test.ts`
### Test files extended (9 modified)
Property-based and edge-case additions to existing tests, drawn from
the upstream PRs:
- `src/core/plugins/loaders/getNestedValue.test.ts` (+46 lines)
- `src/lib/geojson/converter.test.ts` (+31)
- `src/lib/geojson/normalizer.test.ts` (+52)
- `src/lib/rateLimit.test.ts` (+44)
- `src/core/plugins/loaders/DeclarativePlugin.test.ts` (+147 — type
fixes for `DataSourceConfig.method`/`pollInterval`/`format`)
- `src/lib/marketplace/cors.test.ts` (+5)
- `src/lib/marketplace/marketplaceToken.test.ts` (+21)
- `src/core/filters/filterEngine.test.ts` (type-corrected — uses
`latitude`/`longitude` not `position.lat`/`lon`, nested
`range: { min, max, step }` config, etc.)
## What's *not* in this PR (intentionally)
- **Duplicate tests for code already on main.** #113 originally
included `.spec.ts` versions of `CacheLayer`, `DataBus`,
`PollingManager`, `cors`, `marketplaceToken`, `repository`,
`rateLimit`, `edition`, and `seedDefaultPlugins` — all of which are
already tested via `.test.ts` files on main from #110 + prior. Vitest
picks up both `.test.ts` and `.spec.ts`, so keeping both would double
the maintenance burden without adding signal. Dropped.
- **Tautological tests.** A few accessors-only tests from #113
(`getEntities` returning the cached array, `getAllPlugins().length`
equals N) were dropped per the test-writing bar set on #110/#111:
each test must catch a specific bug class that two different broken
implementations would fail differently on.
- **`version` bump in `package.json`.** Three of the contributing PRs
bumped the version line independently (2.9.5, 2.9.10, 2.9.10), each
conflicting with the others. Reserve version bumps for explicit
release commits — feature/test PRs should leave the version field
alone to avoid this conflict hairball.
- **A duplicate `stryker.conf.json`.** #114 used that filename; #117
used `stryker.config.json`. Stryker accepts both but only loads one
(alphabetical resolution). Picked `stryker.config.json` as the
canonical name.
## Verification
```
Test Files 38 passed (38)
Tests 271 passed (271)
```
137 tests on main before this PR; +134 from this consolidation, no
regressions. Type check clean (`pnpm exec tsc --noEmit`).
## Replaces
- PR #113 (test/improve-coverage) — most of its 18 truly-new files
are included here; the 9 duplicate-of-main entries are not.
- PR #114 (chore/stryker-setup) — its CI workflow shape is here with
the trigger changed to weekly+manual instead of per-PR.
- PR #117 (chore/stryker-and-fast-check) — its full deps and test
additions are here.
- PR #118 (test/improve-project-coverage) — the type-corrected
versions of its 6 test files are here, including the typefix commit
pushed to that branch earlier.
Each of those PRs should be closed once this lands, with a comment
referencing this PR for credit.
Co-Authored-By: silvertakana <[email protected]>
This commit includes the work done by the Flash subagent to add comprehensive TSDoc comments to src/components/panels, src/core/state, and src/core/plugins, improving IDE intellisense and codebase maintainability.
Introduces a baseline ESLint configuration and wires it into CI.
Config:
- `eslint.config.mjs` (flat config, ESLint 9). Extends
`eslint-config-next/core-web-vitals` and `eslint-config-next/typescript`
directly — both ship as native flat-config arrays in `eslint-config-next` 16+.
- Ignores cover `.next`, `out`, `src/generated`, `public/cesium`,
`packages/*/dist`, plus the gitignored sandboxes (`local-scripts`,
`local-plugins`, `local-seeders`, `.agents`, `.claude`, `.worktrees`).
Rule policy:
- All rules that the Next.js preset surfaces as errors are demoted to
`warn` on first introduction, so the lint job is runnable against
the current codebase without blocking on pre-existing debt. The
demoted set (react-hooks/* in React 19's stricter purity suite,
no-unescaped-entities, ban-ts-comment, no-assign-module-variable,
prefer-const) plus the originally-flagged `no-explicit-any` and
`no-console` are all documented in the config with a recommended
promotion order.
- Current state: 0 errors, 564 warnings.
Scripts:
- `pnpm lint` runs `eslint .`.
CI:
- New `lint` job in `.github/workflows/ci.yml`, parallel to typecheck /
test / audit. Blocking on errors only — warnings are visible in the
job log but don't fail the build.
Same incremental-introduction pattern as the audit job (#97): land the
infrastructure now, tighten policy via follow-up PRs as the backlog is
worked down.
Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
Co-authored-by: Silvertakana <[email protected]>