David Crawshaw
|
d417be6a4b
|
controlclinet: clone filter.MatchAllowAll
This avoids a non-obvious data race, where the JSON decoder ends
up creating do-nothing writes into global variables.
==================
WARNING: DATA RACE
Write at 0x0000011e1860 by goroutine 201:
tailscale.com/wgengine/packet.(*IP).UnmarshalJSON()
/home/crawshaw/repo/corp/oss/wgengine/packet/packet.go:83 +0x2d9
encoding/json.(*decodeState).literalStore()
/home/crawshaw/go/go/src/encoding/json/decode.go:877 +0x445e
...
encoding/json.Unmarshal()
/home/crawshaw/go/go/src/encoding/json/decode.go:107 +0x1de
tailscale.com/control/controlclient.(*Direct).decodeMsg()
/home/crawshaw/repo/corp/oss/control/controlclient/direct.go:615 +0x1ab
tailscale.com/control/controlclient.(*Direct).PollNetMap()
/home/crawshaw/repo/corp/oss/control/controlclient/direct.go:525 +0x1053
tailscale.com/control/controlclient.(*Client).mapRoutine()
/home/crawshaw/repo/corp/oss/control/controlclient/auto.go:428 +0x3a6
Previous read at 0x0000011e1860 by goroutine 86:
tailscale.com/wgengine/filter.matchIPWithoutPorts()
/home/crawshaw/repo/corp/oss/wgengine/filter/match.go:108 +0x91
tailscale.com/wgengine/filter.(*Filter).runIn()
/home/crawshaw/repo/corp/oss/wgengine/filter/filter.go:147 +0x3c6
tailscale.com/wgengine/filter.(*Filter).RunIn()
/home/crawshaw/repo/corp/oss/wgengine/filter/filter.go:127 +0xb0
tailscale.com/wgengine.(*userspaceEngine).SetFilter.func1()
/home/crawshaw/repo/corp/oss/wgengine/userspace.go:390 +0xfc
github.com/tailscale/wireguard-go/device.(*Device).RoutineDecryption()
/home/crawshaw/repo/corp/wireguard-go/device/receive.go:295 +0xa1f
For #112
Signed-off-by: David Crawshaw <[email protected]>
|
2020-02-28 22:33:06 -05:00 |
|
David Crawshaw
|
4e3ff4b63b
|
controlclient: allow prefixed endpoints in tests
|
2020-02-27 16:52:14 -05:00 |
|
Brad Fitzpatrick
|
25797c8c2a
|
all: rename deep "Copy" methods to conventional Go name "Clone"
|
2020-02-27 12:20:29 -08:00 |
|
David Crawshaw
|
6879581891
|
controlclient: adjust user expiry test
Signed-off-by: David Crawshaw <[email protected]>
|
2020-02-26 09:44:42 -05:00 |
|
Brad Fitzpatrick
|
758744a4e3
|
Fix some Hostinfo value usages from the previous commit.
|
2020-02-25 11:01:20 -08:00 |
|
Brad Fitzpatrick
|
d8de11a01b
|
control: make Hostinfo accessed by pointer
Fix potential races in copying aliased slices by value.
Also few little doc updates.
Signed-off-by: Brad Fitzpatrick <[email protected]>
|
2020-02-25 10:35:51 -08:00 |
|
Brad Fitzpatrick
|
cc7b9b0dff
|
control/controlclient: fix priority of DERP server, add comment
|
2020-02-21 14:47:05 -08:00 |
|
Brad Fitzpatrick
|
c02f4b5a1f
|
control/controlclient: add temporary mechanism to force derp on
Signed-off-by: Brad Fitzpatrick <[email protected]>
|
2020-02-21 14:09:24 -08:00 |
|
David Anderson
|
59ba2e6316
|
ipn: implement Prefs.Equals efficiently.
Signed-off-by: David Anderson <[email protected]>
|
2020-02-17 15:01:23 -08:00 |
|
Brad Fitzpatrick
|
2896be60db
|
Move "logger" package to under types, now that we have it.
Signed-off-by: Brad Fitzpatrick <[email protected]>
|
2020-02-14 20:23:05 -08:00 |
|
Brad Fitzpatrick
|
747c7d7ce2
|
types/empty: add Message, stop using mysterious *struct{}
Signed-off-by: Brad Fitzpatrick <[email protected]>
|
2020-02-14 13:35:49 -08:00 |
|
Brad Fitzpatrick
|
587c3fcac4
|
control/controlclient, wgengine/magicsock: misc cleanups
Signed-off-by: Brad Fitzpatrick <[email protected]>
|
2020-02-14 09:50:08 -08:00 |
|
David Crawshaw
|
2b947b3b40
|
controlclient: handle nil Logf option
|
2020-02-11 15:08:07 -05:00 |
|
Shawn Smith
|
1ca83fd205
|
fix typos
Signed-off-by: Shawn Smith <[email protected]>
|
2020-02-11 08:55:11 -08:00 |
|
David Crawshaw
|
33dfb8999e
|
controlclient, ipn: update tests for key pointer change
Signed-off-by: David Crawshaw <[email protected]>
|
2020-02-11 04:55:07 -05:00 |
|
David Anderson
|
542f46ed4d
|
controlclient: remove unused function.
Signed-off-by: David Anderson <[email protected]>
|
2020-02-10 23:21:08 -08:00 |
|
David Anderson
|
2227ede8af
|
controlclient: fix staticcheck lint.
Signed-off-by: David Anderson <[email protected]>
|
2020-02-10 23:16:13 -08:00 |
|
David Anderson
|
fe9af19da9
|
controlclient: remove unnecessary comparison to bool.
Signed-off-by: David Anderson <[email protected]>
|
2020-02-10 23:14:38 -08:00 |
|
David Crawshaw
|
87334fb332
|
wgengine, controlclient: fewer pointers in wgcfg key types
Signed-off-by: David Crawshaw <[email protected]>
|
2020-02-10 22:09:59 -05:00 |
|
Earl Lee
|
a8d8b8719a
|
Move Linux client & common packages into a public repo.
|
2020-02-09 09:32:57 -08:00 |
|