This removes a potentially increased boot delay for certain boot
topologies where they block on ExecStartPre that may have socket
activation dependencies on other system services (such as
systemd-resolved and NetworkManager).
Also rename cleanup to clean up in affected/immediately nearby places
per code review commentary.
Fixes#11599
Signed-off-by: James Tucker <[email protected]>
Personal preference (so it's obvious it's not a bool flag), but it
also matches the --state= before it.
Bonus: stop allowing PORT to sneak in extra flags to be passed as
their own arguments, as $FOO and ${FOO} expand differently. (${FOO} is
required to concat to strings)
Change-Id: I994626a5663fe0948116b46a971e5eb2c4023216
Signed-off-by: Brad Fitzpatrick <[email protected]>
The dependency is a "soft" ordering dependency only, meaning that
tailscaled will start after those services if those services were
going to be run anyway, but doesn't force either of them to run.
That's why it's safe to specify this dependency unconditionally,
even for systems that don't run those services.
Updates #2127.
Signed-off-by: David Anderson <[email protected]>
Research in issue #1063 uncovered why tailscaled would fail with
ProtectClock enabled (it implicitly enabled DevicePolicy=closed).
This knowledge in turn also opens the door for locking down /dev
further, e.g. explicitly setting DevicePolicy=strict (instead of
closed), and making /dev private for the unit.
Additional possible future (or downstream) lockdown that can be done
is setting `PrivateDevices=true` (with `BindPaths=/dev/net/`), however,
systemd 233 or later is required for this, and tailscaled currently need
to work for systemd down to version 215.
Closes https://github.com/tailscale/tailscale/issues/1063
Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
While not a full capability lockdown of the systemd unit, this still
improves sandboxing and security of the running process a good deal.
Signed-off-by: Frederik “Freso” S. Olesen <[email protected]>
Addresses #964
Still to be done:
- Figure out the correct logging lines in util/systemd
- Figure out if we need to slip the systemd.Status function anywhere
else
- Log util/systemd errors? (most of the errors are of the "you cannot do
anything about this, but it might be a bad idea to crash the program if
it errors" kind)
Assistance in getting this over the finish line would help a lot.
Signed-off-by: Christine Dodrill <[email protected]>
util/systemd: rename the nonlinux file to appease the magic
Signed-off-by: Christine Dodrill <[email protected]>
util/systemd: fix package name
Signed-off-by: Christine Dodrill <[email protected]>
util/systemd: fix review feedback from @mdlayher
Signed-off-by: Christine Dodrill <[email protected]>
cmd/tailscale{,d}: update depaware manifests
Signed-off-by: Christine Dodrill <[email protected]>
util/systemd: use sync.Once instead of func init
Signed-off-by: Christine Dodrill <[email protected]>
control/controlclient: minor review feedback fixes
Signed-off-by: Christine Dodrill <[email protected]>
{control,ipn,systemd}: fix review feedback
Signed-off-by: Christine Dodrill <[email protected]>
review feedback fixes
Signed-off-by: Christine Dodrill <[email protected]>
ipn: fix sprintf call
Signed-off-by: Christine Dodrill <[email protected]>
ipn: make staticcheck less sad
Signed-off-by: Christine Dodrill <[email protected]>
ipn: print IP address in connected status
Signed-off-by: Christine Dodrill <[email protected]>
ipn: review feedback
Signed-off-by: Christine Dodrill <[email protected]>
final fixups
Signed-off-by: Christine Dodrill <[email protected]>
It appears that systemd has sensible defaults for limiting
crash loops:
DefaultStartLimitIntervalSec=10s
DefaultStartLimitBurst=5
Remove our insta-restart configuration so that it works.
Signed-off-by: David Crawshaw <[email protected]>
Port number has to be by itself for substitution to work.
Disabling the restart rate-limiting has to be in [Unit] not
[Service].
Signed-off-by: David Anderson <[email protected]>