mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2026-11-20 17:11:35 -08:00
The item access confirmation dialog used to hold raw Entry pointers in its model, its deny buttons, and its result signal. When the database locks or closes while the dialog is open, DatabaseWidget replaces the Database and destroys every Entry, while the dialog stays up: painting the model, or answering the dialog, then dereferenced freed entries (crash in UnlockPrompt::itemUnlockFinished via Entry::uuid, see the backtrace in #9104). Make the dialog self-contained: snapshot each entry's uuid and display data (title, username, icon) at construction and report decisions as a QHash<QUuid, AuthDecision>, so the dialog never touches an Entry again after it is shown. On the UnlockPrompt side, restore the invariant that a non-null item reference implies a usable backend: track items with QPointer and clear all references as soon as an item retires (Item::itemAboutToDelete), mirroring how collection retirement is handled. A decision for an item that has retired counts as rejected, so the prompt completes as dismissed instead of reporting success for nothing. Finally, match the browser behavior: the dialog now withdraws itself (rejects) when a collection it is asking about locks or goes away, instead of keeping a stale question on screen. Fixes #9104 Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01AqHu6RpvLpaoH2aUGSYQzR