Files
keepassxc/tests/gui/TestGuiFdoSecrets.h
AetfandClaude Fable 5 8e6fe3ffd6 FdoSecrets: keep AccessControlDialog safe across database lock
The item access confirmation dialog used to hold raw Entry pointers in
its model, its deny buttons, and its result signal. When the database
locks or closes while the dialog is open, DatabaseWidget replaces the
Database and destroys every Entry, while the dialog stays up: painting
the model, or answering the dialog, then dereferenced freed entries
(crash in UnlockPrompt::itemUnlockFinished via Entry::uuid, see the
backtrace in #9104).

Make the dialog self-contained: snapshot each entry's uuid and display
data (title, username, icon) at construction and report decisions as a
QHash<QUuid, AuthDecision>, so the dialog never touches an Entry again
after it is shown.

On the UnlockPrompt side, restore the invariant that a non-null item
reference implies a usable backend: track items with QPointer and clear
all references as soon as an item retires (Item::itemAboutToDelete),
mirroring how collection retirement is handled. A decision for an item
that has retired counts as rejected, so the prompt completes as
dismissed instead of reporting success for nothing.

Finally, match the browser behavior: the dialog now withdraws itself
(rejects) when a collection it is asking about locks or goes away,
instead of keeping a stale question on screen.

Fixes #9104

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01AqHu6RpvLpaoH2aUGSYQzR
2026-09-14 19:44:08 -04:00

168 lines
5.3 KiB
C++

/*
* Copyright (C) 2019 Aetf <[email protected]>
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 2 or (at your option)
* version 3 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#ifndef KEEPASSXC_TESTGUIFDOSECRETS_H
#define KEEPASSXC_TESTGUIFDOSECRETS_H
#include <QByteArray>
#include <QDBusConnection>
#include <QPointer>
#include "fdosecrets/dbus/DBusTypes.h"
#include "gui/MessageBox.h"
class MainWindow;
class Database;
class DatabaseTabWidget;
class DatabaseWidget;
class TemporaryFile;
class FdoSecretsPlugin;
namespace FdoSecrets
{
class Service;
class Session;
class Collection;
class Item;
class Prompt;
class DhIetf1024Sha256Aes128CbcPkcs7;
class DBusClient;
} // namespace FdoSecrets
class ServiceProxy;
class CollectionProxy;
class ItemProxy;
class SessionProxy;
class PromptProxy;
class QAbstractItemView;
class QSignalSpy;
class TestGuiFdoSecrets : public QObject
{
Q_OBJECT
public:
explicit TestGuiFdoSecrets();
~TestGuiFdoSecrets() override;
private slots:
void initTestCase();
void init();
void cleanup();
void cleanupTestCase();
void testServiceEnable();
void testServiceEnableNoExposedDatabase();
void testServiceSearch();
void testServiceSearchBlockingUnlock();
void testServiceSearchBlockingUnlockMultiple();
void testServiceSearchForce();
void testServiceUnlock();
void testServiceUnlockDatabaseConcurrent();
void testServiceUnlockConcurrentDelete();
void testServiceUnlockItems();
void testServiceUnlockItemsIncludeFutureEntries();
void testServiceUnlockItemsConcurrentLock();
void testServiceLock();
void testServiceLockConcurrent();
void testSessionOpen();
void testSessionClose();
void testCollectionCreate();
void testCollectionDelete();
void testCollectionDeleteConcurrent();
void testCollectionChange();
void testItemCreate();
void testItemCreateUnlock();
void testItemChange();
void testItemReplace();
void testItemReplaceExistingLocked();
void testItemSecret();
void testItemDelete();
void testItemLockState();
void testItemRejectSetReferenceFields();
void testAlias();
void testDefaultAliasAlwaysPresent();
void testExposeSubgroup();
void testModifyingExposedGroup();
void testNoExposeRecycleBin();
void testHiddenFilename();
void testDuplicateName();
private:
bool driveUnlockDialog(DatabaseWidget* target = nullptr);
bool driveNewDatabaseWizard();
bool driveAccessControlDialog(bool remember = true, bool includeFutureEntries = false);
bool waitForSignal(QSignalSpy& spy, int expectedCount);
void processEvents();
void lockDatabaseInBackend();
void unlockDatabaseInBackend();
QSharedPointer<ServiceProxy> enableService();
QSharedPointer<SessionProxy> openSession(const QSharedPointer<ServiceProxy>& service, const QString& algo);
QSharedPointer<CollectionProxy> getDefaultCollection(const QSharedPointer<ServiceProxy>& service);
QSharedPointer<ItemProxy> getFirstItem(const QSharedPointer<CollectionProxy>& coll);
QSharedPointer<ItemProxy> createItem(const QSharedPointer<SessionProxy>& sess,
const QSharedPointer<CollectionProxy>& coll,
const QString& label,
const QString& pass,
const FdoSecrets::wire::StringStringMap& attr,
bool replace,
bool expectPrompt = false,
bool expectUnlockPrompt = false);
FdoSecrets::wire::Secret
encryptPassword(QByteArray value, QString contentType, const QSharedPointer<SessionProxy>& sess);
template <typename Proxy> QSharedPointer<Proxy> getProxy(const QDBusObjectPath& path) const
{
auto ret = QSharedPointer<Proxy>{
new Proxy(QStringLiteral("org.freedesktop.secrets"), path.path(), QDBusConnection::sessionBus())};
if (!ret->isValid()) {
return {};
}
return ret;
}
template <typename T> T getSignalVariantArgument(const QVariant& arg)
{
const auto& in = arg.value<QDBusVariant>().variant();
return qdbus_cast<T>(in);
}
private:
Q_DISABLE_COPY(TestGuiFdoSecrets)
QScopedPointer<MainWindow> m_mainWindow;
QPointer<DatabaseTabWidget> m_tabWidget;
QPointer<DatabaseWidget> m_dbWidget;
QSharedPointer<Database> m_db;
QPointer<FdoSecretsPlugin> m_plugin;
QSharedPointer<FdoSecrets::DBusClient> m_client;
QScopedPointer<FdoSecrets::DhIetf1024Sha256Aes128CbcPkcs7> m_clientCipher;
QByteArray m_dbData;
QScopedPointer<TemporaryFile> m_dbFile;
};
#endif // KEEPASSXC_TESTGUIFDOSECRETS_H