mirror of
https://github.com/keepassxreboot/keepassxc.git
synced 2026-11-20 00:51:32 -08:00
Reject KeeShare references without a UUID and prevent synchronous reentry during import. A missing UUID previously got assigned a random UUID on each parse, causing equality checks to evaluate to false. During the merge, group removal signals could then trigger a nested import, leading to recursive destruction and use-after-free. References without a <Group> are now rejected, nested imports are blocked by reentrance guards, and regression tests are added. Additionally fixes file change updates arriving during a running import being silently dropped. These updates are now queue for later execution.
52 lines
1.5 KiB
C++
52 lines
1.5 KiB
C++
/*
|
|
* Copyright (C) 2018 KeePassXC Team <[email protected]>
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 or (at your option)
|
|
* version 3 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef KEEPASSXC_TESTSHARING_H
|
|
#define KEEPASSXC_TESTSHARING_H
|
|
|
|
#include <QObject>
|
|
|
|
namespace Botan
|
|
{
|
|
class RSA_PrivateKey;
|
|
}
|
|
class TestSharing : public QObject
|
|
{
|
|
Q_OBJECT
|
|
|
|
private slots:
|
|
void initTestCase();
|
|
void testNullObjects();
|
|
void testKeySerialization();
|
|
void testReferenceSerialization();
|
|
void testReferenceSerialization_data();
|
|
void testReferenceGroupUuid();
|
|
void testReferenceGroupUuid_data();
|
|
void testReferenceValidity();
|
|
void testReferenceValidity_data();
|
|
void testObserverRejectsInvalidReference();
|
|
void testObserverReinitializeReentry();
|
|
void testObserverDeferredImport();
|
|
void testSettingsSerialization();
|
|
void testSettingsSerialization_data();
|
|
|
|
private:
|
|
const QSharedPointer<Botan::RSA_PrivateKey> stubkey(int index = 0);
|
|
};
|
|
|
|
#endif // KEEPASSXC_TESTSHARING_H
|