Commit Graph
7 Commits
Author SHA1 Message Date
Aleksa Sarai 9f8943c89b keepassxc-cli show: resolve references in output (#1280)
* core: database: make UUID searching case-insensitive

4c4d8a5e84 ("Implement search for reference placeholder based on
fields other than ID") changed the semantics of searching-by-reference
in KeePassXC. Unforuntately it contained a bug where it implicitly
became case-sensitive to UUIDs, which broke existing databases that used
references (especially since the default reference format uses a
different case to the UUID used while searching).

The tests didn't catch this because ->toHex() preserves the case that it
was provided, they have been updated to check that UUIDs are case
insensitive.

* cli: show: resolve references in output

Previously, `keepassxc-cli show` would not resolve references. This
would make it quite hard to script around its output (since there's not
interface to resolve references manually either). Fix this by using
resolveMultiplePlaceholders as with all other users of ->password() and
related entry fields.

Fixes: keepassxreboot/keepassxc#1260

* tests: entry: add tests for ref-cloned entries

This ensures that the most "intuitive" current usage of references
(through the clone feature of the GUI) remains self-consistent and
always produces the correct results. In addition, explicitly test that
case insensitivity works as expected. These should avoid similar
regressions in reference handling in the future.

* http: resolve references in AccessControlDialog

The access control dialog previously would not show the "real" username
or "real" title when asking for permission to give access to entries.
Fix this by resolving it, as we do in many other places.

Fixes: keepassxreboot/keepassxc#1269


Signed-off-by: Aleksa Sarai <[email protected]>
2017-12-17 10:44:12 -05:00
thez3ro a53b111182 Update and fix copyright headers 2017-06-14 15:54:43 +02:00
Jonathan White 3de4395d5e Merge remote-tracking branch 'origin/master' into develop 2017-04-09 10:28:15 -04:00
Weslly aba0633a78 Bring HTTP Confirmation window to the front 2017-04-08 17:40:43 -04:00
Janek Bevendorff cb51ec61f7 Replace remaining instances of Q_FOREACH with C++11 range-based for loops 2017-03-10 16:11:57 +01:00
Jonathan White 7f7753a004 Fixed various Qt5 changes in the http code 2016-02-28 10:52:02 -05:00
Francois Ferrand ad67eac257 Confirmation dialog to list entries. 2013-04-12 15:17:56 +02:00