From 4f602d0fbaf68e460d5cbf6410666cd66bcfe657 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABl=20Goinvic?= Date: Wed, 2 Jul 2025 10:07:47 +0200 Subject: [PATCH] service/pods labels matching tests: also skip succeeded --- newsfragments/598.internal.md | 1 + tests/integration/test_networking.py | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 newsfragments/598.internal.md diff --git a/newsfragments/598.internal.md b/newsfragments/598.internal.md new file mode 100644 index 00000000..528e276d --- /dev/null +++ b/newsfragments/598.internal.md @@ -0,0 +1 @@ +Tests : Dont check services matching labels against terminating pods. diff --git a/tests/integration/test_networking.py b/tests/integration/test_networking.py index 2e501bbc..af97093f 100644 --- a/tests/integration/test_networking.py +++ b/tests/integration/test_networking.py @@ -40,7 +40,7 @@ async def test_services_have_matching_labels( label_selectors = {label: value for label, value in service.spec.selector.items()} async for pod in kube_client.list(Pod, namespace=generated_data.ess_namespace, labels=label_selectors): - if pod.status and pod.status.phase == "Terminating": + if pod.status and pod.status.phase not in ("Terminating", "Succeeded"): continue # Skip terminating pods assert service.metadata, f"Encountered a service without metadata : {service}" assert pod.metadata, f"Encountered a pod without metadata : {pod}" @@ -58,7 +58,8 @@ async def test_services_have_matching_labels( assert value.startswith( pod.metadata.labels[label.replace("k8s.element.io/target-", "app.kubernetes.io/")] ), ( - f"{pod.metadata.name} does not have the correct label {label}={value} " + f"{value} does not starts with " + f"{pod.metadata.labels[label.replace('k8s.element.io/target-', 'app.kubernetes.io/')]}" f"(pod status phase : {pod.status.phase if pod.status else 'N/A'}" )