From 4568ebb41a6039c2c065146ead01a64df66001ce Mon Sep 17 00:00:00 2001 From: Butterscotch! Date: Wed, 3 Sep 2025 20:11:24 -0400 Subject: [PATCH] Foot snapping fix (#1519) --- .../tracking/processor/skeleton/LegTweaks.kt | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/server/core/src/main/java/dev/slimevr/tracking/processor/skeleton/LegTweaks.kt b/server/core/src/main/java/dev/slimevr/tracking/processor/skeleton/LegTweaks.kt index 46a9f9cd5..37ef145f7 100644 --- a/server/core/src/main/java/dev/slimevr/tracking/processor/skeleton/LegTweaks.kt +++ b/server/core/src/main/java/dev/slimevr/tracking/processor/skeleton/LegTweaks.kt @@ -650,26 +650,30 @@ class LegTweaks(private val skeleton: HumanSkeleton) { var weightR = getFootPlantWeight(rightFootPosition) // if foot trackers exist add to the weights + val leftFootYaw = isolateYaw(leftFootRotation) if (leftFootTracker) { weightL *= getRotationalDistanceToPlant( leftFootRotation, + leftFootYaw, ) } + val rightFootYaw = isolateYaw(rightFootRotation) if (rightFootTracker) { weightR *= getRotationalDistanceToPlant( rightFootRotation, + rightFootYaw, ) } // perform the correction leftFootRotation = leftFootRotation .interpR( - isolateYaw(leftFootRotation), + leftFootYaw, weightL * masterWeightL, ) rightFootRotation = rightFootRotation .interpR( - isolateYaw(rightFootRotation), + rightFootYaw, weightR * masterWeightR, ) } @@ -805,8 +809,7 @@ class LegTweaks(private val skeleton: HumanSkeleton) { } // returns the amount to slerp for foot plant when foot trackers are active - private fun getRotationalDistanceToPlant(footRot: Quaternion): Float { - val footRotYaw: Quaternion = isolateYaw(footRot) + private fun getRotationalDistanceToPlant(footRot: Quaternion, footRotYaw: Quaternion): Float { var angle = footRot.angleToR(footRotYaw) angle = (angle / (2 * Math.PI)).toFloat() angle = FastMath.clamp( @@ -1005,12 +1008,9 @@ class LegTweaks(private val skeleton: HumanSkeleton) { } } - // remove the x and z components of the given quaternion - private fun isolateYaw(quaternion: Quaternion): Quaternion = Quaternion( - quaternion.w, - 0f, - quaternion.y, - 0f, + // isolate the euler yaw component of a given quaternion + private fun isolateYaw(quaternion: Quaternion): Quaternion = Quaternion.rotationAroundYAxis( + quaternion.toEulerAngles(EulerOrder.YZX).y, ) // return a quaternion that has been rotated by the new pitch amount