mirror of
https://github.com/SableClient/Sable.git
synced 2026-11-20 17:11:17 -08:00
<!-- Please read https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before submitting your pull request --> ### Description <!-- Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change. --> To appease the klipy overlords. Removes all uses of the gif proxy. Previous favorites/sent gifs are still rendered and parsed fully client side, so everything should migrate cleanly. Gifs now go directly to klipy, no homeserver or gif proxy intermediary to fully comply with Klipy's integration requirements. Obviously, this now means gifs will likely not appear on any clients other than Sable (it would just be a message with a raw link, so it would be dependent on homeserver fetching, sable attaches some metadata to the message to make it easier for us to render blurhash and sizes) and it means gifs are always going to be directly loaded by the client so there's a little bit of a privacy issue there, but I can't find any other way to satisfy Klipy. Toggle for unencrypted rooms is baked into the disable media autoload. There's an explicit opt-in toggle for automatically loading external gifs for encrypted rooms. #### Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings ### AI disclosure: - [ ] Partially AI assisted (clarify which code was AI assisted and briefly explain what it does). - [ ] Fully AI generated (explain what all the generated code does in moderate detail). <!-- Write any explanation required here, but do not generate the explanation using AI!! You must prove you understand what the code in this PR does. -->