2441 Commits
Author SHA1 Message Date
7w1 fec777aed4 Decode urls safely to avoid crashes (#512)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->

Fixes #510 

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
2026-03-24 10:00:23 -05:00
7w1 6ac65cc1f8 stupid linter 2026-03-24 09:58:09 -05:00
7w1 418fe2cc1a unduplicate code 2026-03-24 09:56:13 -05:00
7w1 80c207fc0d linter 2026-03-24 09:51:08 -05:00
7w1 7a6c74eeee decode urls safely! 2026-03-24 09:45:14 -05:00
Shea Duma ad9997756a fixed message edit overtaking the autocomplete for enter 2026-03-24 07:46:00 +02:00
Shea Duma 61151ae909 Merge remote-tracking branch 'upstream/dev' into emoji-scrolling
Updated to the latest version
2026-03-24 07:29:58 +02:00
7w1 f5d9e4a9c7 Fix: Add max height to state events (#491)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description
This PR wants to cap the height of an event to prevent one single event
taking the entire screensize.

(before the PR)
<img width="1331" height="867" alt="image"
src="https://github.com/user-attachments/assets/b299cacd-85ff-4496-ac28-174c9f511faa"
/>

(after the PR)
<img width="1321" height="769" alt="image"
src="https://github.com/user-attachments/assets/abbdcab2-b375-4572-909c-d59ff6e294b5"
/>

Fixes #

#### Type of change
prevents

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
2026-03-24 05:25:24 +00:00
7w1 70fade9189 fix standard embeds not rendering 2026-03-24 00:23:57 -05:00
Shea Duma 21a9bcdae6 removed hanging include 2026-03-24 07:15:08 +02:00
Shea Duma e2959e663a redone the formatting to focus it as a short variant while maximizing information provided 2026-03-24 07:12:30 +02:00
7w1 e5cc9c17d6 Add youtube link embeds (#497)
### Description

Adds support for optional client side youtube link embeds. Also includes
minimal scaffolding to support more embed types in the future.

Fixes #61

#### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [ ] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [X] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
2026-03-24 04:29:33 +00:00
7w1 c82384b041 Add title properties to settings toggles 2026-03-23 23:27:40 -05:00
7w1 d88cd9731b Sidebar settings and features discoverability (#474)
### Description
Improves discoverability of settings and features related to Sidebar.
Somewhat related to #391.

<img width="442" height="355" alt="image"
src="https://github.com/user-attachments/assets/e31bf732-c5f0-4f63-b588-10146e13b475"
/>

Fixes #

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
2026-03-23 22:32:21 -05:00
7w1 be8f253ee4 Add context aware search menu (#499)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->

Makes it so the current space's rooms will appear at the top of the
`ctrl + k` search menu. I think it only checks the current space, so
likely doesn't work particularly well in nested situations, but good
enough to add for now I think.

Fixes #486 

#### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
2026-03-23 22:09:54 -05:00
7w1 5e8d5aee11 always reload not just when sw is ready 2026-03-23 21:54:23 -05:00
7w1 496838c184 context aware search menu 2026-03-23 20:33:42 -05:00
Thunder 57208c9e00 fix final lints, add changeset 2026-03-24 00:46:24 +02:00
Thunderandtaskylizard 8cef4107b0 fix lints
Co-authored-by: taskylizard <[email protected]>
2026-03-24 00:22:55 +02:00
Thunder a4037c7f62 default settings 2026-03-24 00:22:55 +02:00
Thunder 17263e712a fixup 2026-03-24 00:22:55 +02:00
Thunder eefc4cdb38 don't nest ternary 2026-03-24 00:22:55 +02:00
Thunder f24bcb1bf5 formatting 2026-03-24 00:22:55 +02:00
Thunder c20479b689 cleanup and finalization ish 2026-03-24 00:22:55 +02:00
Thunder e5906183d7 horrendous state but it kind of works hopefully i can squash these 2026-03-24 00:22:55 +02:00
Kamil Wolter 5f0f01076b Prevent context menu from bubbling 2026-03-23 22:39:22 +01:00
Kamil Wolter 6b2e3a85e4 Moved quick sidebar settings to a context menu 2026-03-23 22:36:22 +01:00
7w1 d0523f0abd add login failure error messages 2026-03-23 13:19:02 -05:00
7w1 bb9e024d5d Fix PMP profile handling and rendering for empty PMP display names (#495)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->

This PR changes that whitespace only, or empty display names of
per-message-profiles resulting in display-names in the event being unset
and the fallback-string not being added to the body.

It also unsets the `avatar_url` if the avatar is not set. And internally
made the displayname an optional field. Only the `id` is now an required
field for the beeper pmp.

It also changes the message rendering, by removing the "via"-part if the
name is unset.

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
No AI was used for my changes
2026-03-23 17:16:39 +00:00
Rye 0500b6f70c fix(Message): fix type error relating to showPmPInfo 2026-03-23 15:02:27 +01:00
Rye dacab844cc fix(Message rendering): don't render the "via" for Per-Message-Profiles if the name is unset or whitespace only 2026-03-23 14:54:09 +01:00
Rye 4791ed09f4 fix(Per-Message-Profiles): whitespace only names will now disable the addition of fallback text 2026-03-23 14:46:11 +01:00
Shea Duma 6e490460d8 fixed the file description field being way too small when having the new editor 2026-03-23 14:15:00 +02:00
Shea a4cc180276 Merge branch 'dev' into Event-maxHeight 2026-03-23 12:01:26 +02:00
7w1 1451be371c fix my merge :3 2026-03-23 00:22:35 -05:00
7w1 1a7b555baf Merge branch 'dev' into more-styled-events 2026-03-23 00:20:15 -05:00
7w1 e5fe0813ce Merge branch 'dev' into more-styled-events 2026-03-23 00:11:31 -05:00
7w1 03daf81868 feat: reply mention indicator (#465)
<!-- Please read
https://github.com/ajbura/cinny/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

in yet another episode of "mini_bomba yoinks discord features into
sable":
reply mention indicators (the @ before the username, not the yellow
highlight)
<img width="239" height="124" alt="image"
src="https://github.com/user-attachments/assets/95a7a25a-7d70-4913-8cf8-c560f8605fcd"
/>

proudly vibecoded using my brain, while referencing matrix client docs

#### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
2026-03-23 05:09:42 +00:00
7w1 1adf98cd9b removed blocked users notice from setting (#490)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->

Just removed the very old section in notification settings about blocked
users moving to the account tab.

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
2026-03-23 00:03:55 -05:00
7w1 43ef337d2c Add knocking support (#470)
<!-- Please read
https://github.com/ajbura/cinny/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

This adds support for room knocking to Sable from both space hierarchy
and the room card (as seen when joining from address, clicking a room
mention, or in the featured page of discovery). It additionally adds a
new modal type that may be used for all knock attempts.

Fixes #

#### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
2026-03-23 05:01:25 +00:00
7w1 659c462133 remove unused imports 2026-03-22 23:54:03 -05:00
Shea Duma c04143d59d maxHeight to prevent visual overwhelming 2026-03-23 06:53:53 +02:00
7w1 15370e2340 removed blocked users notice from setting 2026-03-22 23:52:13 -05:00
7w1 4fbcfef90d feat: add editor multiline mode and many edge case fixes (#476)
### Description

Fixes #350

This adds a dynamic multiline layout to `CustomEditor`. When the message
input grows past a single line (word wrap, explicit newlines, or
multiple blocks), the editor shifts from a single-row layout into a
two-row grid, before/textarea on top, with responsive content spanning
the full width below. It drops back to single-row once the text fits on
one line again.

The old `replacementContent` prop (which swapped out the textarea on
mobile during voice recording) is gone. It's replaced by
`responsiveAfter`, which renders inline next to the send button in
single-line mode and moves down to the footer row in multiline mode.
There's also a `forceMultilineLayout` prop for when you want to push
into multiline immediately, which is what we use when the audio recorder
opens. This means the recorder now takes the same code path on desktop
and mobile instead of having a separate mobile-only branch.

A few other things got fixed along the way:

- Holding the record button on mobile was selecting the "following the
conversation" text underneath it. Fixed with `userSelect: none`.
(related to #350)
- The stop button's `onClick` was being skipped on mobile entirely, so
if `pointerup` got lost mid-drag there was no way to stop recording. Now
`onClick` works as a fallback when recording is already active. (a form
of recovery in case more situations like #350 happen again)
- The waveform bar count is now calculated from the actual container
width via `ResizeObserver` instead of a hardcoded number.
- `cleanupMediaRecorder` wasn't being called in all the
stop/delete/restart/error/unmount paths, which could leave the mic track
open. That's fixed.
- Firefox couldn't seek voice messages because `audio/webm` doesn't
include a seek index. Codec preference now puts `audio/ogg;codecs=opus`
first so Firefox records seekable blobs. Also added a `seekTo` helper
that waits for `loadedmetadata` if the audio element isn't ready yet,
and `audio.preload = 'auto'` + `audio.load()` on mount so Firefox parses
metadata right away.
- Multiline wrap detection is now debounced through
`requestAnimationFrame` and uses a `ResizeObserver` on the scroll
container to cut down on flicker and extra re-renders.
- Added cloudflared tunnels for easier testing on mobile

Also sorry for the cursed line height measurer, there was legit no other
way to detect it that didn't cause other issues.

Good amount of this was created with help of AI (like figuring out
options on how to fix the edge cases), especially the edge case unit
tests, but It had to be fixed by hand in many places and frankly I can't
tell you exactly where was what. I've been working on this for couple
days now.. (losing my mind over it)

### Screenshots:

https://github.com/user-attachments/assets/bcff3766-6c60-46c7-ac9e-a8b943a665d3

https://github.com/user-attachments/assets/367cdcc4-666e-4324-8e81-1b415feb0aca

#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
2026-03-23 04:02:36 +00:00
7w1 487221d985 fix: recover timeline after TimelineReset (#478)
### Description

This PR fixes the reconnect / limited-sync recovery path in the room
timeline. Managed to track it down, thanks to this sentry report
[SABLE-1V](https://sable-client.sentry.io/issues/104545427/events/741b82918ba34554996ad673efe75a6f/)

After `TimelineReset`, the hook now re-anchors live event detection to
the current live timeline, allows bottom-pinned recovery to bypass the
transient `liveTimelineLinked` lag, and avoids snapping non-bottom users
to latest.

It also adds a regression test covering the reset behavior so the scroll
recovery and non-bottom path stay locked down.

Fixes #360

Repro (It's a tricky one):

- Use a broken build on Android Chrome if possible. Desktop Chrome works
too, but mobile/backgrounding is closer to the original report.
- Open a busy room and stay pinned to the bottom.
- In another client/account, send several messages to that room while
the first client is disconnected.
- Force a real sync gap:
- Mobile: background the app/tab, lock the phone, or toggle Wi‑Fi/mobile
data off for 30-60s.
  - Desktop: open DevTools and set network to Offline for 30-60s.
- Reconnect and return to the room.

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [x] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
2026-03-23 02:28:52 +00:00
7w1 967c161b75 Fix touchpad zooming in image viewer (#481)
<!-- Please read
https://github.com/ajbura/cinny/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

When using the touchpad both browser and app zoom gets activated, so let
the browser handle zooming when using a touchpad

Fixes #463

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
2026-03-23 02:08:33 +00:00
Shea Duma 8e85e8a90e removed visual focus on the 1st item to avoid any potential bugginess 2026-03-23 03:19:53 +02:00
Shea Duma ef817ce175 forced the focus to go to the right editor to stop the main one from mainspreading 2026-03-23 03:10:27 +02:00
Rye 0c97bfcadc fix (per-message-profile): unset fields if their value is oprional, and don't include a fallback if the display name is empty 2026-03-23 01:58:33 +01:00
Rawrington 525d3e311d i forgot typescript is evil sometimes 2026-03-23 00:53:01 +00:00