Commit Graph
2859 Commits
Author SHA1 Message Date
7w1 fc7aec771c Some potential sync request spam fixes (#736)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->

As I haven't really had any issues I'm not 100% sure this fixes anything
at all, but it at least doesn't break anything.

Increase the timeout for background clients to 60s, separates them into
their own store, and makes sliding sync respect the setting instead of
the client setting, and hopefully better management.

Adds a startup timeout of 45s to the main loading screen to prevent
anything from getting stuck behind that which may or may not actually do
anything.

Replaces the sdk's thread root event fetching on initial load to prevent
the useless loading delay and request spam on load. Get's swapped back
once the client loads which then functions normally, only loading thread
events when a room is opened.

Also some random formatting changes that happened in initMatrix.ts when
I saved for some reason?? They're more readable imo so I just left them
in.

Also fixed the 1 lint issue from #730 

Maybe related to #710 

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->

Bickered with an AI to diagnose some potential syncing issues but none
of the changes were directly AI written.
2026-05-04 23:13:19 -05:00
7w1 e6a7746430 Error message for theme favoriting errors 2026-05-04 22:59:16 -05:00
7w1 c87630eb4c add export button and update changeset 2026-05-04 22:49:02 -05:00
7w1 af52a55aaa Improve theme loading disclaimers and chat preview setting options 2026-05-04 22:24:16 -05:00
7w1 e5bc629691 reverse theme source approval logic, empty is none 2026-05-04 21:58:51 -05:00
7w1 a4cd4e8e33 Remove relic of a bygone era 2026-05-04 21:50:11 -05:00
7w1 bc4ca6e2fd Changeset and formatting 2026-05-04 21:35:56 -05:00
7w1 eeab65b121 Consolidate theme cards a little 2026-05-04 21:25:32 -05:00
7w1 8ff6ff68de Improve initial enable flow 2026-05-04 21:04:59 -05:00
7w1 e635e9d28b Remove the no preview tokens in this tweak text 2026-05-04 20:54:02 -05:00
7w1 6ee0b9983a fix linting 2026-05-04 20:51:28 -05:00
7w1 1a6d6f4584 Merge branch 'dev' into feat/theme-edits-v2 2026-05-04 20:42:58 -05:00
7w1 7f62d389e8 replace setting with options to only render dark/light profiles 2026-05-04 20:37:28 -05:00
Shea Duma 1345a0b41e ill stop playing around with the minutia 2026-05-05 04:21:50 +03:00
7w1 e4cf72ed77 bypass sdk thread root spam on initial load 2026-05-04 20:03:44 -05:00
Shea Duma fb988dd20f merged and added setting 2026-05-05 03:34:12 +03:00
7w1 663aa4f876 fix lint issue from other pr 2026-05-04 18:38:45 -05:00
7w1 7bbcbb841c fixes to reduce background client syncs + increase poll timeout to 30s
increase the timeout for background clients to 60s, separates them into their own store, and makes sliding sync respect the setting instead of the client setting, and hopefully better management

adds a startup timeout of 45s to the main loading screen to prevent anything from getting stuck behind that which may or may not actually do anything.

so much writing for such little change :(
2026-05-04 18:33:05 -05:00
7w1 3b6fd542fd Add partial MSC4459 support and refactor related code (#730)
### Description

partial implementation of
[MSC4459](https://github.com/matrix-org/matrix-spec-proposals/pull/4459)

Currently only sending the data and not rendering anything

Partially #729

#### Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

No AI used
2026-05-04 21:46:10 +00:00
Shea f44835df01 Make the Read Receipts dialog scrollable again (#631)
### Description

At some point between commits
[43cb531](https://github.com/SableClient/Sable/commit/43cb5313be960746c984bbf1336f1a0dfde078a4)
and
[f4cc4d5](https://github.com/SableClient/Sable/commit/f4cc4d51de4301c8e3f201ecc2aec4bb7604cc1d),
in the process of switching various UI elements into unified modals, the
read receipts modal (specifically the one that opens from an individual
message's context menu) lost its ability to be scrolled through.

In this patch, I've reverted that specific component to its old form,
both to immediately return the functionality and to provide a useful
reference state for the process of creating a more polished fix.

I recommend directly patching this pull request to properly unify the
modals first, but it _should_ be functional enough on its own to be
implemented as an immediate fix if you prefer.

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
2026-05-04 21:42:54 +00:00
7w1 4f5f6e662a Merge branch 'dev' into feat/msc4459 2026-05-04 16:40:28 -05:00
7w1 ca311d9b8d Replace custom markdown parsing with marked, KaTeX, and some custom plugins for matrix things (#727)
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->

### Description

<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Replaced Cinny's custom markdown parsing with marked which should
drastically reduce the various random obscure errors and crashes caused
by it.
Added math rendering support with KaTeX, sent using standard formatting
of $ for inline and $$ for block with LaTeX.

Supersedes #726
Fixes #711 
Fixes #587
Fixes #467  
Fixes #684 

Tbh I doubt I've tested this enough so there's probably still a bunch of
bugs, especially in parsing html back to markdown, but hopefully it's
less than our current system?

Might consider using another library like Turndown for converting html
into markdown, currently using a partial custom parser with... well okay
results.

Updated to also remove the WYSIWYG editor because it's largely unused,
can be entirely covered by markdown, and complicates translating html to
markdown. Keyboard shortcuts from the editor have been rewritten to
instead apply markdown syntax.

#### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [x] Breaking change - removes the WYSIWYG editor.
- [ ] This change requires a documentation update

### Checklist:

- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings

### AI disclosure:

- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->

Tests were AI generated and then reviewed by me. I can confirm that the
tests probably test the right stuff.
I had AI do the initial merge and write the marked plugins for the link
preview hiding and spoiler hiding features, which I then tested and
reviewed.
2026-05-04 16:39:28 -05:00
Rye f49e84d1af fix(msc4459): don't set mxc when there is no data to associate with it 2026-05-04 06:57:11 +02:00
Rye ff41ff1061 perf: simple caching (might need some later adjustments) 2026-05-04 06:43:02 +02:00
Rye 952212e8d2 fix(msc4459): fix room local image packs 2026-05-03 21:11:34 +02:00
Rye 58a98b1d96 fix(msc4459): emoji discoverable as per MSC4459 2026-05-03 20:08:16 +02:00
Rye 3d1b1026bb fix(formatting): fix formatting issues 2026-05-03 19:11:48 +02:00
Rye cbe38bae35 Merge branch 'dev' into feat/msc4459 2026-05-03 18:34:54 +02:00
Rye 6a4d5059b8 fix(msc4459): refactoring and restricting getImagePackReferencesForMxc to public rooms 2026-05-03 18:19:45 +02:00
Rye 0b8b7bc534 fix(msc4459): remove duplicate matrix client argument 2026-05-03 17:39:25 +02:00
Rye f518ff50fe fixup! initial commit for MSC4459 support + a fair bit of refactoring 2026-05-03 17:20:19 +02:00
Rye 0e61fc9cdb initial commit for MSC4459 support + a fair bit of refactoring 2026-05-03 17:17:43 +02:00
Shea Duma 2b40919308 added changeset 2026-05-01 05:12:31 +03:00
Shea Duma d4cf86094c fix - scrollable read receipts 2026-05-01 05:01:02 +03:00
Shea Duma 59f8702674 minimal fix 2026-05-01 04:59:25 +03:00
Shea Duma 777493771a Reseparated items 2026-05-01 04:16:24 +03:00
7w1 5991790472 formatting 2026-04-30 14:57:28 -05:00
7w1 ee33176fd2 fix typecheck 2026-04-30 14:46:00 -05:00
7w1 c8851c32a2 remove WYSIWYG editor 2026-04-30 14:37:28 -05:00
7w1 f130f4e2fe fix typecheck 2026-04-30 10:59:59 -05:00
7w1 122a0e2f25 update tests 2026-04-30 10:56:22 -05:00
7w1 307f3b107d formatting and linting 2026-04-30 10:51:35 -05:00
7w1 574e177d82 dynamically load math library 2026-04-30 10:47:16 -05:00
7w1 d3c73176eb fix markdown rendering in spoilers 2026-04-30 10:40:50 -05:00
7w1 5c2a528229 remove the standard markdown extra new lines 2026-04-30 10:32:25 -05:00
7w1 6aa8dde28d formatting... 2026-04-30 09:41:16 -05:00
7w1 982c87557e firefox list fix 2026-04-30 09:39:43 -05:00
Shea Duma 9955ed68cb updated credit verbiage and links 2026-04-30 10:03:30 +03:00
7w1 ce0c646325 unused file 2026-04-30 01:40:36 -05:00
7w1 34b01b40a2 swap to new htmltomarkdown parser 2026-04-30 01:38:16 -05:00