<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Fixes #
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
fix packaging to not including wry in cef build + don't wait 45 minutes
to release the desktop auto update json
Fixes #
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
The updater-manifest job needed [setup-release, build, android], but
android takes 45 min and dev pushes cancel in-progress runs. So the
manifest almost never ran -- latest.json was stuck at nightly.29.1 for
4 builds.
The manifest only uses desktop .sig files (produced by the build job);
android produces no updater artifacts. Drop it from needs.
Add nightly iOS build job to tauri-build.yml using tauri ios build --no-sign,
upload the unsigned IPA + altstore-source.json to the release, and document
the install flow in the README.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Fixes #
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
this nix flake is heavily based off of prior work i have done in one of my
repos. it comes with the following features:
- building sable: `nix build .#sable` or just `nix build`. creates a `result/`
dir with the built application.
- devshell: nix users now no longer need to do download and install all the
dependencies for sable by themselves. the devshell comes with all the
dependencies needed to develop sable
- checks: `nix flake check` is configured to perform all checks listed in
`CONTRIBUTING.md` (fmt:check, lint, typecheck, knip, test:run)
- formatting: `nix fmt` runs all the formatters pnpm would also call, but
provides a more familiar interface for nix users.
- pre-commit checks: nix users can benefit from having their changes checked for
before the commit goes through. yay :3
`.vscode/settings.json` was updated to include hints for VS Code users using the
"nix env selector" extension to auto-detect the nix dev environment, if you have
nix installed.
I had to change `oxfmt.config.ts` just a tiny bit to make it work with the nix
stuff, because `node_modules` does not exist inside the nix build sandbox. `pnpm
fmt` successfully runs, so nothing should have broken.
`flake-lock-fix.yml` is a small workflow heavily based on
<https://docs.determinate.systems/guides/fix-hashes/>, which triggers on pushes
to `dev` which change `pnpm-lock.yaml`. The workflow uses `determinate-nixd` to
fix hashes in the `flake.nix`, then pushes the changes to `dev` automatically.
### Description
This PR adds the requirement to disclose AI usage on the PR, asking for
an explanation of what any AI generated code does.
With this I hope the AI dramas can end, while also making sure that no
vibecoded bad PR gets through, only the good ones.
I'm open to discussion but let's keep it calm here...
(Oh also, this PR fixes the link at the top of the PR template to link
to our contributing page and not Cinny's.)
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings