### Description
This pull request fixes an issue with forwarding messages for users on
Synapse homeservers by ensuring that relations and mentions are properly
removed from forwarded messages. The changes focus on improving privacy
and preventing confusion when messages are forwarded to other rooms.
#### Forwarding and privacy improvements
- Removed the `m.relates_to` and `m.mentions` fields from the forwarded
message content to avoid leaking relations or mentions from the original
message.
- Removed the addition of a new `m.relates_to` relation when
constructing the forwarded message, preventing references to the
original event in the forwarded message.
Fixes#539
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
no AI was used in the creation of this PR
### Description
This pull request adds support for saving and reading user bios in the
MSC4440 format, improving compatibility with the MSC4440 specification
for Matrix user profiles. The changes ensure that bios are now stored
and retrieved in both the legacy and MSC4440-compliant formats, and
introduce new types to support this functionality.
#### MSC4440 Bio Compatibility
- User bios are now saved in the MSC4440 format (`gay.fomx.biography`)
in addition to existing formats, ensuring forward compatibility with the
MSC4440 spec. When saving, both HTML and plain text representations are
stored.
- The user profile normalization logic now reads bios from the MSC4440
field first, falling back to legacy fields if necessary.
- The fields handled by the normalization function are updated to
include the MSC4440 bio key.
#### Type and Import Updates
- New types `MSC1767Text` and `MSC4440Bio` are introduced to represent
the MSC4440 bio format, and relevant imports are updated throughout the
codebase.
implements https://github.com/matrix-org/matrix-spec-proposals/pull/4440
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
No AI was used in the creation of this PR
### Description
When the pusher is configured with `event_id_only` format, the service
worker fetches event details itself rather than receiving them in the
push payload. Previously only the sender display name and room name were
retrieved — `room_avatar_url` was always `undefined`, so every
notification showed the default app logo regardless of whether the room
or sender had an avatar set. Display names could also be stale in the
encrypted path when the app resumed from a cold state.
**Changes in `src/sw.ts`:**
- `fetchMemberDisplayName` → `fetchMemberInfo`: the same single HTTP
request to `m.room.member` state now also extracts `avatar_url`, giving
both display name and sender avatar for free
- `fetchRoomAvatar`: new helper that fetches the `m.room.avatar` state
event URL
- `mxcToNotificationUrl`: converts `mxc://` to a legacy unauthenticated
thumbnail URL (`/_matrix/media/v3/thumbnail/…`) so the OS can load the
notification icon without an auth header
- `handleMinimalPushPayload`: room avatar is now fetched in the initial
parallel batch alongside the event and room name; icon is resolved as
room avatar → member avatar (DM fallback) → default logo;
`room_avatar_url` passed to all `handlePushNotificationPushData` call
sites
- Encrypted relay path now uses the server-fetched `senderDisplay`
(authoritative) rather than the SDK cache value from the relay, which
can be absent or stale when the app hasn't fully synced after a cold
resume
Fixes #
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [x] Fully AI generated (explain what all the generated code does in
moderate detail).
`fetchMemberInfo` extends the existing member state fetch to also return
`avatar_url`. `fetchRoomAvatar` GETs `m.room.avatar` state.
`mxcToNotificationUrl` builds a legacy `/_matrix/media/v3/thumbnail/`
URL (no auth required, OS-loadable) from an `mxc://` URI.
`handleMinimalPushPayload` adds `fetchRoomAvatar` to its parallel fetch
batch, resolves the notification icon with room > member > default
priority, and passes it through as `room_avatar_url` to every
`handlePushNotificationPushData` invocation. The encrypted relay path is
updated to prefer the server-fetched display name over the relay's
potentially-stale SDK cache value.
### Description
Add ability to open the user hero by clicking on the usernames shown in
member and state events (e.g. user joins room, room name changed). I
expected this behavior based on previous usage of discord, it wasn't
doing anything previously so I think this is a useful addition.
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [ ] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
Adds a room abbreviations feature: moderators can define term/definition
pairs in room settings. Defined terms are highlighted with a dotted
underline in messages and show a tooltip on hover (tap-to-pin on
mobile). Abbreviations defined in a parent space are inherited by child
rooms and nested spaces, with overrides allowed at each level. The
settings UI shows a flat list of inherited and locally-defined entries.
Fixes #
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [X] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
The code adds changes that allow for setting and viewing room
abbreviations, with an on-hover tooltip (or press on mobile -
semi-persistent). It stores these in the room state under a new key, and
recursively fetches abbreviations from the space level. This also adds
regex so that abbreviations correctly work at word boundaries. Also adds
the needed hooks to `room.ts` and `slidingSync.ts`
### Description
this is a tiny fix to a potentially confusing "problem" that i thought
of when going to sleep last night, previously if you enabled client side
embeds in both unencrypted and encrypted rooms, and then turned off the
main client side embeds toggle, the encrypted rooms setting would remain
on, even though it would be hidden in the setting ui
feel free to just close if this is stupid
#### Type of change
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [ ] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
### Description
Replace the previous hacky regex method with a slightly better link
parser. Add support for timestamps, playlists and youtube music links,
tracking info is still stripped and embeds use the timestamp. Previously
none of these features were supported, this might also be slightly more
robust.
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [ ] My code follows the style guidelines of this project
- [X] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [X] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
### Description
not setting `sender` to `null` anymore but just not setting it.
Fixes#539 (hopefully)
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
no AI was used for this PR
When the pusher uses event_id_only format the SW fetches event details
itself. Previously only the display name and room name were retrieved;
the notification icon was always the default app logo.
- fetchMemberDisplayName → fetchMemberInfo: also captures avatar_url
from the m.room.member state response, so a single HTTP request gives
us both the display name and the sender avatar
- fetchRoomAvatar: fetches m.room.avatar state; used for group rooms
- mxcToNotificationUrl: converts mxc:// to a legacy unauthenticated
thumbnail URL so the OS can load the icon without an auth header
- handleMinimalPushPayload: fetch room avatar in the initial parallel
request batch; resolve notification icon as room avatar > member
avatar (DM fallback); pass room_avatar_url to all
handlePushNotificationPushData call sites
- encrypted path: prefer the server-fetched senderDisplay (authoritative)
over the relay's SDK cache value, which may be stale or absent when
the app hasn't fully synced after a cold resume
### Description
Extends `scrubMatrixUrl` with two additional patterns that were leaking
through the existing scrubber.
**1. Opaque Matrix IDs with percent-encoded colon (`%3A`)**
Device IDs, filter tokens, and other Matrix IDs that lack a sigil prefix
but follow the `localpart%3Aserver` pattern were not matched by the
existing sigil-based patterns. For example:
```
/Gj3Wy2D8gAi8jTIyR%3Asable.moe → /[MATRIX_ID]
```
**2. Long opaque base64url path segments**
Access tokens, Curve25519 keys, MSC3575 session tokens, and push
endpoints appear as 30+ character base64url strings in URL path
segments. These were passing through unscrubbed. For example:
```
/vI02CuiDNpaYEhUIVLbqE8vdKqm2ZwqIR5Y6NwNY_Rg/ → /[REDACTED]/
```
The new pattern runs last so the earlier sigil-based patterns already
handle known Matrix IDs first.
Fixes #
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted
- [x] Fully AI generated
Two regex patterns added to `scrubMatrixUrl` in `sentryScrubbers.ts`.
The first matches path segments containing a bare `localpart%3Aserver`
form (no sigil) and replaces with `[MATRIX_ID]`. The second matches any
path segment of 30 or more base64url characters and replaces with
`[REDACTED]`, covering access tokens, crypto keys, and opaque session
identifiers. Both are appended after the existing patterns so known
sigil-prefixed IDs are handled first.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
This fixes unread badge positioning by deriving sidebar badge layout
from the same settings-aware mode that decides whether unread badges
render as dots or counts, so toggling badge display no longer leaves the
offset wrong. It also includes the related unread count formatting
cleanup, an Appearance toggle for large-count badge behavior, and
replaces `millify` dependency with a shared `Intl.NumberFormat` compact
formatter.
### Screenshots
<img width="68" height="463" alt="image"
src="https://github.com/user-attachments/assets/89f19c25-f6aa-46c2-8172-9748f43f605d"
/>
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
<!-- Please read
https://github.com/ajbura/cinny/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Adds a black theme (high contrast dark theme)
I used
https://github.com/7w1/sable/pull/51/changes/6f2d63046a57908b7d5d8c21c6eefe3dff160e43
as a reference of how to do this.
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### Description
Adds cross-device settings sync by storing Sable's app settings in a
Matrix account data event (`moe.sable.app.settings`). Change a setting
on one device and it propagates to your other sessions automatically.
Fixes #
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [x] Fully AI generated (explain what all the generated code does in
moderate detail).
**What the generated code does:**
`settingsSync.ts` — Serialise/deserialise helpers that convert the
settings state to/from the account data wire format. Unknown keys are
preserved so older clients don't silently drop data from newer ones.
`useSettingsSync.ts` — The main sync hook. On mount it reads any
existing account data and merges it into local state. It then listens
for live updates from other devices via `ClientEvent.AccountData`.
Uploads are debounced by 2 seconds and each one embeds a random
`synctoken`; when the server echoes the event back, the hook recognises
its own token and skips re-applying it. Exposes `settingsSyncStatusAtom`
and `settingsSyncLastSyncedAtom` for UI feedback.
`General.tsx` — Adds a "Sync settings across devices" toggle and a JSON
export/import section for manually backing up and restoring settings.
`ClientNonUIFeatures.tsx` — Mounts the sync hook once at the client root
so it stays active for the whole session.
`settings.ts` — Adds `settingsSyncEnabled: boolean` (default `false`) to
the settings atom.
Type files — Registers `moe.sable.app.settings` in the account data type
registry so SDK callbacks are typed correctly.
Tests cover the serialise/deserialise helpers, load-on-mount, merge
behaviour, echo-loop skipping, debounced uploads, and error states.
Previously, abbreviation term highlighting was skipped for any message
that has a formatted_body (virtually all messages from modern clients
using a rich-text editor), because RenderBody returned early from the
customBody path before reaching the abbreviation logic.
The fix adds an optional replaceTextNode callback to
getReactCustomHtmlParser. Since opts closes over itself, renderChildren
inside element handlers recurses through the same replace function, so
text nodes nested inside <p>, <strong>, <em>, list items, etc. are all
processed correctly.
buildAbbrReplaceTextNode is exported from RenderBody.tsx and wired
into both RoomTimeline and ThreadDrawer via useRoomAbbreviationsContext.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Hopefully should help us actually figure out why many people seemingly
can't forward messages.
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
previously you could enable client side embeds in encrypted rooms,
while disabling them in unencrypted rooms, even though turning off the
unencrypted room toggle hid the encrypted rooms toggle
- useMergedAbbreviations: drop space param; use getAllParents+roomToParentsAtom
to traverse the full ancestor chain and subscribe to state events at every
level (not just direct parent) via useStateEventCallback on the mx client
- Room.tsx: drop parentSpace/useSpaceOptionally — hook handles it internally
- RoomAbbreviations settings: replace two-section layout with a single flat
list; room entries shown without badge, inherited entries show a
'Space - <SpaceName>' chip badge; supports arbitrary nesting depth
(mirrors the useImagePackRooms multi-level pattern)
- Add textDecoration: 'underline dotted' and cursor: 'help' to <abbr>
elements in AbbreviationTerm so users can see the hover indicator
- RoomAbbreviations: add isSpace prop; when true, show 'Space Abbreviations'
/ 'space-level' labels and hide the inherited-from-space section
- SpaceSettings: pass isSpace to RoomAbbreviations