Commit Graph
6704 Commits
Author SHA1 Message Date
Rye 962fef476b fix random resizing of recorder pop up by setting the width to a constant 2026-03-15 14:15:03 +01:00
Kace Cottam 515b378a20 Added setting to control depth limit and cleaned up the code 2026-03-15 00:44:23 -07:00
Shea Duma a6cb35becd added changeset file 2026-03-15 09:27:47 +02:00
Shea Duma e6589c0a0f reverted unintended changes 2026-03-15 09:23:36 +02:00
Shea Duma d5ae28e34a added file description editing 2026-03-15 09:13:48 +02:00
Kace Cottam 8c4f5e512c Initial modification of Space navbar to have svg thread lines 2026-03-14 23:47:30 -07:00
Evie Gauthier 76fa7f3030 fix: prevent event listener accumulation during sync retries
- Add unreadInfoRef in RoomTimeline; remove unreadInfo from useLiveEventArrive
  callback deps and LocalEchoUpdated effect deps to stop per-message listener churn
- Fix CallEmbed .bind(this) leak: bind handlers once in start(), push cleanup to
  disposables so dispose() correctly removes all listeners
- Add stable refs in useCallSignaling for mutedRoomId/ring callbacks; tighten
  effect deps to [mx, mDirects, setMutedRoomId] to prevent SessionEnded listener
  accumulation during sync retry cycles
2026-03-15 01:27:19 -04:00
Evie Gauthier 1bd5281c93 fix(timeline): stable callback ref pattern for room event listener hooks
useLiveEventArrive, useRelationUpdate, useLiveTimelineRefresh, and
useThreadUpdate each passed their callback argument into the useEffect
dependency array. This caused the listener to be removed and re-added
every time the callback identity changed (e.g. when unreadInfo toggled
or when any other parent-scope value included in the useCallback deps
changed).

Under normal conditions React's synchronous effect cleanup guarantees
one listener at a time. But during sliding-sync error/retry cycles the
client emits MaxListenersExceededWarning (11 session_ended, 51
RoomState.events) confirming that listeners accumulate. When the
callbacks change fast enough — or React defers cleanup in concurrent
mode — multiple handleTimelineEvent instances are live simultaneously.
Each one independently calls setTimeline({ range: start+1, end+1 }) for
the same arriving event, producing the spurious scroll jumps reported.

Fix: use the stable callback ref pattern in all four hooks.
- Add a ref (onArriveRef / onRelationRef / onRefreshRef / onUpdateRef)
- Assign ref.current = callback on every render (always up-to-date)
- Remove the callback from the useEffect dep array (effect runs only
  when `room` changes)
- Inside handlers, delegate via ref.current() instead of the captured
  closure value

The event listener identity is now stable for the entire lifetime of
each room mount. Listener counts stay at 1 regardless of how many
re-renders occur or how many sync error/retry cycles fire.
2026-03-15 01:27:04 -04:00
Evie Gauthier 832f597d6a fix(timeline): don't force scroll-to-bottom on sync gap when scrolled up
When a sliding-sync limited response fires RoomEvent.TimelineReset (or
the app fires RoomEvent.TimelineRefresh) the useLiveTimelineRefresh
callback was unconditionally calling setAtBottom(true) and incrementing
scrollToBottomRef, scrolling the user to the bottom even if they had
scrolled up to read history.

Three coordinated changes:

1. Add RoomEvent.TimelineReset handler to useLiveTimelineRefresh.
   The SDK emits TimelineReset on the EventTimelineSet (not the Room)
   when a limited sync response replaces the live EventTimeline. Without
   this listener the stored linkedTimelines reference the old detached
   chain; back-pagination silently no-ops, freezing the room.

2. Gate the viewport scroll on atBottomRef.current (prior position).
   Capture wasAtBottom before calling setTimeline(getInitialTimeline).
   Only call setAtBottom(true) and increment scrollToBottomRef when the
   user was already at the bottom. When scrolled up we still reinit the
   timeline (the old chain is gone) but avoid the forced scroll.

3. Add timelineJustResetRef to allow the self-heal effect to run when
   atBottom=false after a reset. The SDK fires TimelineReset before
   populating the fresh timeline, so getInitialTimeline sees range.end=0.
   Without the atBottom guard bypass the range stays at {0,0} as events
   arrive, leaving the virtual paginator rendering nothing. The ref is
   cleared on first successful heal, after which normal atBottom-gated
   behaviour resumes.
2026-03-15 01:27:04 -04:00
Shea Duma ec6f772661 improved video loading logic 2026-03-15 06:39:40 +02:00
Shea Duma 70e6660224 improved image loading logic 2026-03-15 05:56:17 +02:00
jasonlaguidice 349d71dfce Add changeset 2026-03-14 17:38:02 -07:00
jasonlaguidice d2d0025098 Add graceful fail if MSC4140 event delay exceeded 2026-03-14 17:35:49 -07:00
haz b90555a27c Merge pull request #275 from SableClient/fix/release-tag-workflows
fix: align workflows to v* tags and support manual release deploys
2026-03-14 23:19:07 +00:00
hazre c710b5d803 fix: align workflows to v* tags and support manual release deploys 2026-03-15 00:16:30 +01:00
Kace Cottam 1445f3fdcf Merge branch 'dev' into improve-space 2026-03-14 16:08:49 -07:00
Kace Cottam bf36587df3 Update Space sidebar with depth-based link to space lobby 2026-03-14 16:05:42 -07:00
7w1 f80f2737de Merge pull request #272 from SableClient/release
chore: prepare release 1.8.0
v1.8.0
2026-03-14 22:25:10 +00:00
github-actions[bot] edddf2c06c chore: prepare release 1.8.0 2026-03-14 22:20:09 +00:00
7w1 162625a915 Merge pull request #274 from SableClient/7w1-patch-2
Update add_voice_message_func.md
2026-03-14 22:17:43 +00:00
7w1 25bb9dc7d2 Update add_voice_message_func.md 2026-03-14 17:16:04 -05:00
7w1 efeac92d08 Merge pull request #273 from SableClient/7w1-patch-1
add back deleted changeset
2026-03-14 22:10:46 +00:00
7w1 5cf778e891 Create fix_call_prefs.md 2026-03-14 17:08:57 -05:00
7w1 4925f0f579 Merge pull request #176 from dozro/feat/audio-recordings
Add voice message functionality
2026-03-14 21:59:07 +00:00
hazre 4795fb387e fix: move window creation into rust side for easier control 2026-03-14 20:48:20 +01:00
hazre e8670348ff feat: add cef support and switch to tauri-typegen for bindings (wip)
- deep link sso is busted on dev
2026-03-14 20:48:19 +01:00
7w1 b2728598a0 Merge pull request #262 from dozro/fix/sticker-picker-webkit-speed-optimizations
Implement opt-in experimental bandwidth saving for stickers and emojis
2026-03-14 19:17:35 +00:00
7w1 c13cb81035 Merge pull request #271 from SableClient/fix/workflows
fix workflows again
2026-03-14 18:57:29 +00:00
7w1 ee3fdf68d5 Update prepare-release.yml 2026-03-14 13:55:38 -05:00
7w1 2419d75615 Merge pull request #270 from SableClient/fix/workflows
Fix workflows
2026-03-14 18:48:51 +00:00
7w1 74a4d6a9ec Update prepare-release.yml 2026-03-14 13:47:28 -05:00
7w1 6881752c31 Update prepare-release.yml 2026-03-14 13:41:58 -05:00
7w1 f63a347df4 Update prepare-release.yml 2026-03-14 13:39:54 -05:00
7w1 fbbd46cd62 Update cloudflare-web-deploy.yml 2026-03-14 13:37:37 -05:00
Rye c5d194576f fix formatting 2026-03-14 18:45:04 +01:00
Rye afd5a5d488 fix maintainability issues raised by sonarqube
- Unicode-aware string methods should be used for proper character handling (typescript:S7758)
2026-03-14 18:23:46 +01:00
Rye c7ebd49e10 fix maintainability issues raised by sonarqube
- Use "globalThis" instead of "window", "self", or "global" (typescript:S7764)
- Unicode-aware string methods should be used for proper character handling (typescript:S7758)
2026-03-14 18:22:32 +01:00
Rye b44796ad0c fix maintainability issues raised by sonarqube
- Strings should use "replaceAll()" instead of "replace()" with global regex (typescript:S7781)
- Existence checks should use ".includes()" instead of ".indexOf()" or ".lastIndexOf()" (typescript:S7765)
- Use "globalThis" instead of "window", "self", or "global" (typescript:S7764)
2026-03-14 18:20:55 +01:00
Rye aa6a764732 fix maintainability issues raised by sonarqube
- Unicode-aware string methods should be used for proper character handling (typescript:S7758)
2026-03-14 18:18:57 +01:00
Rye 412c5284be fix maintainability issues raised by sonarqube
- Built-in constructors should be called consistently with or without "new" (typescript:S7723)
- Negated conditions should be avoided when an else clause is present (typescript:S7735)
- Strings should use "replaceAll()" instead of "replace()" with global regex (typescript:S7781)
- Use ".some()" instead of ".filter().length" checks or ".find()" for existence testing (typescript:S7754)
- React props should be read-only (typescript:S6759)
- Number static methods and properties should be preferred over global equivalents (typescript:S7773)
- The return value of "useState" should be destructured and named symmetrically (typescript:S6754)
- Optional chaining should be preferred (typescript:S6582)
- Arrays used only for existence checks should be Sets (typescript:S7776)
- Unicode-aware string methods should be used for proper character handling (typescript:S7758)
2026-03-14 18:14:24 +01:00
Rye 7b3ea2b9c0 fix sonarqube maintainability issues
- Number static methods and properties should be preferred over global equivalents (typescript:S7773)
- Function references should not be passed directly to iterator methods (typescript:S7727)
- Strings should use "replaceAll()" instead of "replace()" with global regex (typescript:S7781)
- "RegExp.exec()" should be preferred over "String.match()" (typescript:S6594)
- React props should be read-only (typescript:S6759)
- Prefer `Math.min()` to simplify ternary expressions (typescript:S7766)
- Optional property declarations should not use both '?' and 'undefined' syntax (typescript:S4782)
- Built-in constructors should be called consistently with or without "new" (typescript:S7723)
2026-03-14 17:32:19 +01:00
Rye 9363bee208 replace globalThis with window in useKeyDown for consistency 2026-03-14 17:12:30 +01:00
Rye b5b1766bd6 fix sonarqube maintainability/reliability issues
- typescript:S7773
- typescript:S4158
2026-03-14 17:12:15 +01:00
Rye 7c4decd4e9 fix reliability/maintainability issues raised by sonarqube
fixed issues:
- typescript:S7781
- typescript:S6759
2026-03-14 16:41:44 +01:00
Rye 1c5314dd55 fix maintainability issues raised by sonarqube
fixed sonarqube issues:
- React props should be read-only (typescript:S6759)
- Spacing between inline elements should be explicit (typescript:S6772)
2026-03-14 16:37:02 +01:00
7w1 8e67dbacbe Merge pull request #264 from piko-piko/urlpreview-middleclick
Middle click to open the url preview card thumbnail in a new tab
2026-03-14 15:16:24 +00:00
piko-piko 02aa299558 fixed formatting; fixed linting issues 2026-03-14 14:55:26 +01:00
hazre 01d5cdc435 chore: add nix devshell flake (android not tested) 2026-03-14 13:44:18 +01:00
7w1 28073b57a0 Merge pull request #253 from Vespe-r/small-notifications
Add width limit to notification banners
2026-03-14 12:38:55 +00:00
Vesper c811733e0a Add changeset 2026-03-14 11:31:10 +00:00