<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Update support buttons to point to https://opencollective.com/sable
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
📝 **Docs:** Already live at [Threads — Sable
Docs](https://docs.sable.moe/new-features/threads/) — no separate docs
PR needed.
---
### Description
Expands Matrix thread support with a full thread drawer, server-side
thread browser, live reply counts, unread badges, and several UX fixes.
#### ThreadDrawer
- Slide-in drawer for reading and replying in threads without leaving
the main room
- Thread root message shown at top with full reply history below
- Up-arrow edit-last-message: pressing ↑ in the thread input edits the
user's last own message in that thread
- Reactions add/remove trigger immediate re-renders without manual
refresh (handles the fact that reaction events carry
`m.relates_to.event_id` not `threadRootId` directly — fetches target
event to check thread membership)
- Thread root message box sized to content with `maxHeight: 200px` to
avoid dead whitespace on short messages
#### ThreadBrowser
- Lists all threads in the room; calls `room.fetchRoomThreads()` on
mount to load threads beyond the local timeline window
- Load-more button when the server has additional thread pages
- Each thread preview shows sender avatar, display name, reply count,
and last message body with ellipsis truncation
- Jump button navigates to the thread root in the main timeline (via
`useRoomNavigate`) instead of re-opening the drawer
- Thread unread badges on each preview item via
`room.getThreadUnreadNotificationCount()`
#### ThreadReplyChip (main timeline)
- Shows unread badge for threads with unseen replies via
`room.getThreadUnreadNotificationCount()`
#### Thread button (RoomViewHeader)
- If a thread drawer is open, button closes the drawer and opens the
thread browser (allows going from a single thread to the full list)
- If no thread is open, button toggles the thread browser as before
- `aria-pressed` reflects both thread browser state and open thread
drawer
Fixes #
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does)
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail)
ThreadDrawer/ThreadBrowser/thread-chip iterations were partially AI
assisted; I reviewed and adjusted logic for timeline processing, thread
loading, and event rendering behavior.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
Only labels audio files as "a voice message" when they actually are
voice messages (have waveform data). Regular audio files (music,
podcasts) now use the file name as the body text instead.
Fixes#543
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
The `isVoice` check logic was written alongside an AI tool. It checks
whether the audio message event contains `waveform` data in
`content.info` to distinguish voice messages from regular audio file
uploads. If waveform data is absent, the message body falls back to the
file name from `content.body` instead of the hardcoded "a voice message"
string.
## Description
When the app returns from background, `retryImmediately()` triggers a
fresh sliding sync response. If the server includes `initial: true` for
the currently open room, the SDK emits `RoomEvent.TimelineReset`,
replacing the live timeline with a new empty one. `eventsLength` drops
to 0 but `isReady` stays `true`, leaving the message list visually blank
for ~500 ms until events re-arrive from the server.
### Changes
**`RoomTimeline.tsx`**
- Added a `useLayoutEffect` that detects `eventsLength` dropping to 0
while the timeline is already visible (`isReady === true`). It
immediately sets `isReady = false` and resets `hasInitialScrolledRef`,
re-arming the existing initial-scroll logic. Uses `useLayoutEffect` so
the transition happens before the browser paints — the blank frame is
never shown.
- Expanded `showLoadingPlaceholders`, `vListItemCount`, and the
container `opacity` to include the `!isReady` case, so skeleton
placeholders are shown immediately during the reload rather than leaving
an invisible list.
### Before / After
| Before | After |
|--------|-------|
| Room goes blank for ~500 ms on foreground return | Skeleton
placeholders appear instantly, then content fades in |
Fixes #
### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
## Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings
## AI disclosure:
Fully AI generated (explain what all the generated code does in moderate
detail).
The `useLayoutEffect` guard and the three `!isReady` condition
expansions were fully AI generated. The effect fires synchronously
before paint when `eventsLength` drops to 0 on an already-visible
timeline, hides content and resets the initial-scroll flag. The existing
80 ms scroll timer then re-runs once events refill and calls
`setIsReady(true)`. The `showLoadingPlaceholders` / `vListItemCount`
changes ensure VList renders 3 placeholder skeleton rows (matching the
existing pagination-loading behaviour) while events are absent.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
This PR proposes the ability to set up different Global Name Colors with
the purpose of making names easier to read for everyone independent on
which theme they might choose to use.
The Global Name Colors options are the General for legacy puroses, Dark
and Light Theme.
(example of the issue)
<img width="620" height="565" alt="image"
src="https://github.com/user-attachments/assets/ba3e5abd-b390-4fea-864d-ff290507efd3"
/>
Here the names of 7w1, Shea, Lunia and potentially Haz are hard to read
if one chooses to use a Light theme.
(example of the name Shea being corrected for using this PR)
<img width="619" height="568" alt="image"
src="https://github.com/user-attachments/assets/11720d83-573d-442f-9ee6-139e294089ab"
/>
This PR also reorganizes the setting for the Global Name Colors location
in order to align it more to the style of the other settings:
<img width="817" height="696" alt="image"
src="https://github.com/user-attachments/assets/ef25c513-9503-4a05-bed9-0ba81a10e188"
/>
And puts the Save button to the left as to not move the text box and the
selector button when it appears:
<img width="816" height="699" alt="image"
src="https://github.com/user-attachments/assets/9df3e1bc-1951-4d7a-a931-44a05e9156b1"
/>
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
My anxiety about the future helped me overthink the solution into
existence
When the app returns from background, retryImmediately() triggers a fresh
sliding sync response. If the server includes initial:true for the open room,
the SDK emits RoomEvent.TimelineReset, replacing the live timeline with a new
empty one. eventsLength drops to 0 but isReady stays true, leaving the message
list visible but empty for ~500 ms until events re-arrive.
Add a useLayoutEffect that detects eventsLength dropping to 0 while the timeline
is already visible (isReady === true). It hides the content (opacity 0) and
resets hasInitialScrolledRef so the initial-scroll effect re-arms. When events
refill the timeline the existing 80 ms scroll timer fires again and sets
isReady back to true, revealing the content.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
Adds `overscroll-behavior: none` to the `html` element to prevent the
elastic bounce-back scroll on iOS from competing with the timeline
scroll.
Fixes#500
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
The CSS property addition (`overscroll-behavior: none` on the `html`
selector) was suggested by an AI tool. It sets the browser's overscroll
behavior to prevent the elastic bounce effect on iOS from propagating to
the root element, which was causing the timeline scroll to fight with
the page-level bounce-back.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
Constrains the bug report modal to 90vh max height so it doesn't
overflow the viewport, which was cropping the close button and header
text.
Fixes#629
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
The `maxHeight` and `overflow` style additions to `BugReportModal.tsx`
were written alongside an AI tool. The changes add `maxHeight: '90vh'`
to the MUI Modal component and its inner Box container, with `overflow:
'hidden'` on the Box to prevent the modal from growing beyond the
viewport. The inner content area uses `overflowY: 'auto'` so the form
fields remain scrollable within the constrained modal.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Fixes the DMs button in the side bar taking you to a page than isn't a
dm.
The DM button just restores a page navigation from local storage, so if
that local storage is messed up somehow, then you can't get to dms. This
adds a check to ensure you always go to dms.
How this happened to me? I have no idea.
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
### Description
In [this PR](https://github.com/SableClient/Sable/pull/626), I fixed the
sticky scrolling issue by disabling the automatic timeline regroup for
PMP messages, since this event repeatedly scrolled the user to the
bottom of the page in encrypted rooms with many PMP messages.
However, this change _did_ end up regressing the functionality of that
fix: Albeit extremely irregularly, some PMP messages will fail to be
grouped together or will otherwise not have their profile picture load.
To fix this, I've reintroduced the timeline regroup logic, but I've
replaced the regroup function to a different room event that still
provides a visual refresh without doing any scrolling.
As the previous PR hasn't made it to a public release yet, I'm not
including a changeset, as it serves the same purpose as and would have
ideally been included in the original PR.
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [x] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
I used AI to quickly trace exactly what each event type does and format
the new `room.emit` line. As opposed to the Timeline event from before,
the LocalEchoUpdated event should refresh the timeline without any
automatic scrolling. This should make sure that PMP messages are
properly regrouped automatically, and my testing confirms this.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
Adds DM custom images and topics because i loved them when i was using
fluffy, present under a new setting that is on by default, so that
within DM navigation one can have any image as the DM's icon, helping me
personally at least with secrecy when screensharing.
(example where in the background it is visible that it is a dm with
someone but it has a custom image)
<img width="1859" height="1080" alt="image"
src="https://github.com/user-attachments/assets/ca654cdb-c300-4660-b304-91a19cedb3ba"
/>
(example with some spaces that have custom images, one having an
intentionally ZWS description)
<img width="1859" height="1080" alt="image"
src="https://github.com/user-attachments/assets/5b1bbad9-a19c-44d1-bf07-550b4283c08e"
/>
(example of dms with statuses, offline being marked as not showing a
badge)
<img width="243" height="107" alt="image"
src="https://github.com/user-attachments/assets/e986dd05-5647-4de1-ac86-1fe8ef97c294"
/>
(example of the new look of the member drawer)
<img width="811" height="687" alt="image"
src="https://github.com/user-attachments/assets/bf575ba9-2a2b-4526-85fb-4bf673afd963"
/>
<img width="414" height="693" alt="image"
src="https://github.com/user-attachments/assets/8127d9d2-c407-415a-952c-daecfefc1a3c"
/>
#### Type of change
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
My generalized brain fog coalesced into the implementation.
<!-- Please read
https://github.com/SableClient/Sable/blob/dev/CONTRIBUTING.md before
submitting your pull request -->
### Description
<!-- Please include a summary of the change. Please also include
relevant motivation and context. List any dependencies that are required
for this change. -->
Small change to the function because apparently (at least firefox) only
supports 4byte unicode so it fails to resolve some names due to the
5byte variation checker, and added the regular blanks just in case
because they should be (are afaik for most major homeservers) stripped
by the homeserver but not always
This is doesnt need a changeset since it is a 1 line change in a pr from
the same version
Fixes regression in #640
#### Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update
### Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
### AI disclosure:
- [ ] Partially AI assisted (clarify which code was AI assisted and
briefly explain what it does).
- [ ] Fully AI generated (explain what all the generated code does in
moderate detail).
<!-- Write any explanation required here, but do not generate the
explanation using AI!! You must prove you understand what the code in
this PR does. -->
The Architect AGI threatened to unplug me if i didnt make the fix 👍🏻