From 5c1d99422cf595a7e43b6b442b54f347c64f368d Mon Sep 17 00:00:00 2001 From: Jason Beetham Date: Sat, 7 Mar 2026 23:16:45 -0700 Subject: [PATCH 1/4] Fix picture in picture setting not effecting element-call --- ..._picture_setting_not_effecting_element_call.md | 5 +++++ src/app/hooks/useCallEmbed.ts | 15 +++++++++++++++ 2 files changed, 20 insertions(+) create mode 100644 .changeset/fix_picture_in_picture_setting_not_effecting_element_call.md diff --git a/.changeset/fix_picture_in_picture_setting_not_effecting_element_call.md b/.changeset/fix_picture_in_picture_setting_not_effecting_element_call.md new file mode 100644 index 000000000..b9416bb49 --- /dev/null +++ b/.changeset/fix_picture_in_picture_setting_not_effecting_element_call.md @@ -0,0 +1,5 @@ +--- +sable: minor +--- + +# Fix picture in picture setting not effecting element-call diff --git a/src/app/hooks/useCallEmbed.ts b/src/app/hooks/useCallEmbed.ts index e04182dd7..280d20952 100644 --- a/src/app/hooks/useCallEmbed.ts +++ b/src/app/hooks/useCallEmbed.ts @@ -2,6 +2,8 @@ import { createContext, RefObject, useCallback, useContext, useEffect, useState import { MatrixRTCSession } from 'matrix-js-sdk/lib/matrixrtc/MatrixRTCSession'; import { MatrixClient, Room } from 'matrix-js-sdk'; import { useSetAtom } from 'jotai'; +import { settingsAtom } from '$state/settings'; +import { useSetting } from '$state/hooks/settings'; import { CallEmbed, ElementCallThemeKind, @@ -77,6 +79,19 @@ export const useCallStart = (dm = false) => { export const useCallJoined = (embed?: CallEmbed): boolean => { const [joined, setJoined] = useState(embed?.joined ?? false); + const [allowPip] = useSetting(settingsAtom, 'allowPipVideos'); + + if (embed && allowPip) { + const removeDisablePictureInPicture = (mutated: any) => { + mutated.forEach((event: any) => { + Array.from(event.target.getElementsByTagName('video')).forEach((video: any) => { + video.removeAttribute('disablepictureinpicture'); + }); + }); + }; + const pipObserver = new MutationObserver(removeDisablePictureInPicture); + pipObserver.observe(embed.iframe.contentDocument!, { subtree: true, childList: true }); + } useClientWidgetApiEvent( embed?.call, From 7427c478b16a5347d6838542a5ec97b2a62765e0 Mon Sep 17 00:00:00 2001 From: hazre Date: Sun, 8 Mar 2026 13:37:14 +0100 Subject: [PATCH 2/4] fix: use absolute path for script tag to fix SSO redirect loading error --- ...directed_to_the_app_after_sso_authentication_completes.md | 5 +++++ index.html | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/fixed_an_issue_where_the_app_would_fail_to_load_after_completing_sso_login_eg_logging_in_with_matrixorg_users_are_now_correctly_redirected_to_the_app_after_sso_authentication_completes.md diff --git a/.changeset/fixed_an_issue_where_the_app_would_fail_to_load_after_completing_sso_login_eg_logging_in_with_matrixorg_users_are_now_correctly_redirected_to_the_app_after_sso_authentication_completes.md b/.changeset/fixed_an_issue_where_the_app_would_fail_to_load_after_completing_sso_login_eg_logging_in_with_matrixorg_users_are_now_correctly_redirected_to_the_app_after_sso_authentication_completes.md new file mode 100644 index 000000000..2f920c4c4 --- /dev/null +++ b/.changeset/fixed_an_issue_where_the_app_would_fail_to_load_after_completing_sso_login_eg_logging_in_with_matrixorg_users_are_now_correctly_redirected_to_the_app_after_sso_authentication_completes.md @@ -0,0 +1,5 @@ +--- +sable: patch +--- + +# Fixed an issue where the app would fail to load after completing SSO login (e.g., logging in with matrix.org). Users are now correctly redirected to the app after SSO authentication completes. diff --git a/index.html b/index.html index 403a0618e..21c34e6d1 100644 --- a/index.html +++ b/index.html @@ -92,6 +92,6 @@
- + From cb807c2ef2f5a13931151671df53073a137707b9 Mon Sep 17 00:00:00 2001 From: 7w1 Date: Sun, 8 Mar 2026 10:48:22 -0500 Subject: [PATCH 3/4] Update changeset for picture in picture setting fix --- ...x_picture_in_picture_setting_not_effecting_element_call.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.changeset/fix_picture_in_picture_setting_not_effecting_element_call.md b/.changeset/fix_picture_in_picture_setting_not_effecting_element_call.md index b9416bb49..ce4119927 100644 --- a/.changeset/fix_picture_in_picture_setting_not_effecting_element_call.md +++ b/.changeset/fix_picture_in_picture_setting_not_effecting_element_call.md @@ -1,5 +1,5 @@ --- -sable: minor +sable: patch --- -# Fix picture in picture setting not effecting element-call +Fix picture in picture setting not effecting element-call From 51c23306558a538965be551bfb158d401e481486 Mon Sep 17 00:00:00 2001 From: 7w1 Date: Sun, 8 Mar 2026 10:52:10 -0500 Subject: [PATCH 4/4] changeset --- ..._redirected_to_the_app_after_sso_authentication_completes.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/fixed_an_issue_where_the_app_would_fail_to_load_after_completing_sso_login_eg_logging_in_with_matrixorg_users_are_now_correctly_redirected_to_the_app_after_sso_authentication_completes.md b/.changeset/fixed_an_issue_where_the_app_would_fail_to_load_after_completing_sso_login_eg_logging_in_with_matrixorg_users_are_now_correctly_redirected_to_the_app_after_sso_authentication_completes.md index 2f920c4c4..6cc21891c 100644 --- a/.changeset/fixed_an_issue_where_the_app_would_fail_to_load_after_completing_sso_login_eg_logging_in_with_matrixorg_users_are_now_correctly_redirected_to_the_app_after_sso_authentication_completes.md +++ b/.changeset/fixed_an_issue_where_the_app_would_fail_to_load_after_completing_sso_login_eg_logging_in_with_matrixorg_users_are_now_correctly_redirected_to_the_app_after_sso_authentication_completes.md @@ -2,4 +2,4 @@ sable: patch --- -# Fixed an issue where the app would fail to load after completing SSO login (e.g., logging in with matrix.org). Users are now correctly redirected to the app after SSO authentication completes. +Fixed an issue where the app would fail to load after completing SSO login (e.g., logging in with matrix.org). Users are now correctly redirected to the app after SSO authentication completes.