From 7e5ba5d75813cf7a9d68501135647b1d51d06c26 Mon Sep 17 00:00:00 2001 From: Erwan Leboucher Date: Sat, 25 Jul 2026 20:13:18 +0200 Subject: [PATCH] refactor: adopt getMouseEventCords at the hand-rolled literals --- .changeset/adopt-getMouseEventCords.md | 5 +++++ src/app/features/room-nav/RoomNavItem.tsx | 9 ++------- src/app/features/room/message/Message.tsx | 8 ++------ 3 files changed, 9 insertions(+), 13 deletions(-) create mode 100644 .changeset/adopt-getMouseEventCords.md diff --git a/.changeset/adopt-getMouseEventCords.md b/.changeset/adopt-getMouseEventCords.md new file mode 100644 index 000000000..c1a4bcbc3 --- /dev/null +++ b/.changeset/adopt-getMouseEventCords.md @@ -0,0 +1,5 @@ +--- +default: patch +--- + +Adopt the existing getMouseEventCords helper at the two remaining hand-rolled coordinate literals. diff --git a/src/app/features/room-nav/RoomNavItem.tsx b/src/app/features/room-nav/RoomNavItem.tsx index 5488bff92..90ee8040e 100644 --- a/src/app/features/room-nav/RoomNavItem.tsx +++ b/src/app/features/room-nav/RoomNavItem.tsx @@ -31,7 +31,7 @@ import { useMatrixClient } from '$hooks/useMatrixClient'; import { useRoomUnread } from '$state/hooks/unread'; import { roomToUnreadAtom } from '$state/room/roomToUnread'; import { usePowerLevels } from '$hooks/usePowerLevels'; -import { copyToClipboard } from '$utils/dom'; +import { copyToClipboard, getMouseEventCords } from '$utils/dom'; import { markAsRead } from '$utils/notifications'; import { confirm } from '$components/confirm/confirm'; import { showToast } from '$state/toast'; @@ -406,12 +406,7 @@ export function RoomNavItem({ } evt.preventDefault(); - setMenuAnchor({ - x: evt.clientX, - y: evt.clientY, - width: 0, - height: 0, - }); + setMenuAnchor(getMouseEventCords(evt.nativeEvent)); }; const handleOpenMenu: MouseEventHandler = (evt) => { diff --git a/src/app/features/room/message/Message.tsx b/src/app/features/room/message/Message.tsx index 764b116a7..87abe5912 100644 --- a/src/app/features/room/message/Message.tsx +++ b/src/app/features/room/message/Message.tsx @@ -41,6 +41,7 @@ import { } from '$components/message'; import { canEditEvent, getEditedEvent, getMemberAvatarMxc } from '$utils/room'; import { getMxIdLocalPart, mxcUrlToHttp } from '$utils/matrix'; +import { getMouseEventCords } from '$utils/dom'; import type { MessageSpacing } from '$state/settings'; import { getSettings, MessageLayout, settingsAtom } from '$state/settings'; import { useMatrixClient } from '$hooks/useMatrixClient'; @@ -912,12 +913,7 @@ function MessageInternal( } evt.preventDefault(); - setMenuAnchor({ - x: evt.clientX, - y: evt.clientY, - width: 0, - height: 0, - }); + setMenuAnchor(getMouseEventCords(evt.nativeEvent)); }; const handleOpenMenu: MouseEventHandler = (evt) => {