From 6effabaef4396250f300be926faa7bb64dea4204 Mon Sep 17 00:00:00 2001 From: 7w1 Date: Thu, 5 Mar 2026 16:05:27 -0600 Subject: [PATCH 1/2] add show unread ping counts toggle to optionally still show ping counts when normal counts are disabled --- .changeset/unread_pins_toggle.md | 5 +++++ src/app/components/unread-badge/UnreadBadge.tsx | 7 +++++-- src/app/features/settings/cosmetics/Cosmetics.tsx | 9 --------- src/app/features/settings/cosmetics/Themes.tsx | 8 ++++++++ src/app/state/settings.ts | 2 ++ 5 files changed, 20 insertions(+), 11 deletions(-) create mode 100644 .changeset/unread_pins_toggle.md diff --git a/.changeset/unread_pins_toggle.md b/.changeset/unread_pins_toggle.md new file mode 100644 index 000000000..0fec14164 --- /dev/null +++ b/.changeset/unread_pins_toggle.md @@ -0,0 +1,5 @@ +--- +sable: patch +--- + +Added an additional toggle, Show Unread Ping Counts, to override the Show Unread Counts allowing for only pings to have counts. diff --git a/src/app/components/unread-badge/UnreadBadge.tsx b/src/app/components/unread-badge/UnreadBadge.tsx index 9029cc9b7..49b8d664c 100644 --- a/src/app/components/unread-badge/UnreadBadge.tsx +++ b/src/app/components/unread-badge/UnreadBadge.tsx @@ -20,8 +20,11 @@ export function UnreadBadgeCenter({ children }: { children: ReactNode }) { } export function UnreadBadge({ highlight, count }: UnreadBadgeProps) { - const [showCounts] = useSetting(settingsAtom, 'showUnreadCounts'); - const showNumber = showCounts && count > 0; + const [showUnreadCounts] = useSetting(settingsAtom, 'showUnreadCounts'); + const [showPingCounts] = useSetting(settingsAtom, 'showPingCounts'); + + const showNumber = count > 0 && (showUnreadCounts || (highlight && showPingCounts)); + return ( } /> - - - } - /> - ); } diff --git a/src/app/features/settings/cosmetics/Themes.tsx b/src/app/features/settings/cosmetics/Themes.tsx index 1440ae602..56d73c245 100644 --- a/src/app/features/settings/cosmetics/Themes.tsx +++ b/src/app/features/settings/cosmetics/Themes.tsx @@ -328,6 +328,7 @@ function PageZoomInput() { export function Appearance() { const [twitterEmoji, setTwitterEmoji] = useSetting(settingsAtom, 'twitterEmoji'); const [showUnreadCounts, setShowUnreadCounts] = useSetting(settingsAtom, 'showUnreadCounts'); + const [showPingCounts, setShowPingCounts] = useSetting(settingsAtom, 'showPingCounts'); return ( @@ -356,6 +357,13 @@ export function Appearance() { } /> + + } + /> + ); diff --git a/src/app/state/settings.ts b/src/app/state/settings.ts index 835984b3f..fab455280 100644 --- a/src/app/state/settings.ts +++ b/src/app/state/settings.ts @@ -72,6 +72,7 @@ export interface Settings { hideMembershipInReadOnly: boolean; useRightBubbles: boolean; showUnreadCounts: boolean; + showPingCounts: boolean; } const defaultSettings: Settings = { @@ -128,6 +129,7 @@ const defaultSettings: Settings = { hideMembershipInReadOnly: true, useRightBubbles: false, showUnreadCounts: true, + showPingCounts: true, }; export const getSettings = () => { From 3f9f22fc8f0fc9f2a99f8a3c60bb69063573aa72 Mon Sep 17 00:00:00 2001 From: 7w1 Date: Thu, 5 Mar 2026 16:10:05 -0600 Subject: [PATCH 2/2] Update Cosmetics.tsx --- src/app/features/settings/cosmetics/Cosmetics.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/app/features/settings/cosmetics/Cosmetics.tsx b/src/app/features/settings/cosmetics/Cosmetics.tsx index 2bc357bad..d39d3a2ac 100644 --- a/src/app/features/settings/cosmetics/Cosmetics.tsx +++ b/src/app/features/settings/cosmetics/Cosmetics.tsx @@ -173,7 +173,6 @@ function IdentityCosmetics() { const [renderRoomFonts, setRenderRoomFonts] = useSetting(settingsAtom, 'renderRoomFonts'); const [uniformIcons, setUniformIcons] = useSetting(settingsAtom, 'uniformIcons'); const [rightBubbles, setRightBubbles] = useSetting(settingsAtom, 'useRightBubbles'); - const [showUnreadCounts, setShowUnreadCounts] = useSetting(settingsAtom, 'showUnreadCounts'); return (