From f40273c926502adbadc0724ec9d178f579c73633 Mon Sep 17 00:00:00 2001 From: Evie Gauthier Date: Sun, 8 Mar 2026 12:28:21 -0400 Subject: [PATCH 1/4] fix: in-app notification banner placement - render NotificationBanner in ClientLayout so it spans the full viewport as position:fixed and doesn't displace page content - remove the old banner render from Room.tsx --- .../notification-banner/NotificationBanner.css.ts | 12 ++---------- src/app/features/room/Room.tsx | 2 +- src/app/pages/client/ClientLayout.tsx | 2 ++ 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a/src/app/components/notification-banner/NotificationBanner.css.ts b/src/app/components/notification-banner/NotificationBanner.css.ts index 1ddfacda3..4a29d24d7 100644 --- a/src/app/components/notification-banner/NotificationBanner.css.ts +++ b/src/app/components/notification-banner/NotificationBanner.css.ts @@ -23,12 +23,11 @@ const slideOut = keyframes({ }, }); -// Floats at the top of the chat area, starting after the icon sidebar. +// Floats at the top of the viewport, spanning full width on all platforms. export const BannerContainer = style({ position: 'fixed', top: 0, - // 66px = sidebar icon strip width — overridden to 0 on mobile below - left: toRem(66), + left: 0, right: 0, zIndex: 9999, display: 'flex', @@ -37,13 +36,6 @@ export const BannerContainer = style({ padding: config.space.S400, pointerEvents: 'none', alignItems: 'stretch', - - '@media': { - // On narrow screens the sidebar collapses, so span the full width. - '(max-width: 768px)': { - left: 0, - }, - }, }); export const Banner = style({ diff --git a/src/app/features/room/Room.tsx b/src/app/features/room/Room.tsx index c960d431b..b7aef9107 100644 --- a/src/app/features/room/Room.tsx +++ b/src/app/features/room/Room.tsx @@ -2,6 +2,7 @@ import { useCallback } from 'react'; import { Box, Line } from 'folds'; import { useParams } from 'react-router-dom'; import { isKeyHotkey } from 'is-hotkey'; +import { useAtomValue } from 'jotai'; import { ScreenSize, useScreenSizeContext } from '$hooks/useScreenSize'; import { useSetting } from '$state/hooks/settings'; import { settingsAtom } from '$state/settings'; @@ -13,7 +14,6 @@ import { useMatrixClient } from '$hooks/useMatrixClient'; import { useRoomMembers } from '$hooks/useRoomMembers'; import { CallView } from '$features/call/CallView'; import { WidgetsDrawer } from '$features/widgets/WidgetsDrawer'; -import { useAtomValue } from 'jotai'; import { callChatAtom } from '$state/callEmbed'; import { RoomViewHeader } from './RoomViewHeader'; import { MembersDrawer } from './MembersDrawer'; diff --git a/src/app/pages/client/ClientLayout.tsx b/src/app/pages/client/ClientLayout.tsx index 4bbd4068f..9cb4a3f41 100644 --- a/src/app/pages/client/ClientLayout.tsx +++ b/src/app/pages/client/ClientLayout.tsx @@ -1,5 +1,6 @@ import { ReactNode } from 'react'; import { Box } from 'folds'; +import { NotificationBanner } from '$components/notification-banner'; type ClientLayoutProps = { nav: ReactNode; @@ -8,6 +9,7 @@ type ClientLayoutProps = { export function ClientLayout({ nav, children }: ClientLayoutProps) { return ( + {nav} {children} From 27600e2e63a41b6dd81382f91e763dac8c1dbcfc Mon Sep 17 00:00:00 2001 From: Evie Gauthier Date: Sun, 8 Mar 2026 14:38:06 -0400 Subject: [PATCH 2/4] chore: add changeset for notification banner fix --- .changeset/fix-notification-banner.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fix-notification-banner.md diff --git a/.changeset/fix-notification-banner.md b/.changeset/fix-notification-banner.md new file mode 100644 index 000000000..a3b7b19cb --- /dev/null +++ b/.changeset/fix-notification-banner.md @@ -0,0 +1,5 @@ +--- +"sable": patch +--- + +fix: in-app notification banner placement From 780591580f367d06f9c0dd26324d1c73fdf4e688 Mon Sep 17 00:00:00 2001 From: Evie Gauthier Date: Sun, 8 Mar 2026 18:35:52 -0400 Subject: [PATCH 3/4] fix: remove NotificationBanner from ClientNonUIFeatures MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Completes the placement move — banner is now rendered only in ClientLayout as position:fixed. --- src/app/pages/client/ClientNonUIFeatures.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/app/pages/client/ClientNonUIFeatures.tsx b/src/app/pages/client/ClientNonUIFeatures.tsx index 3116c4c56..56c333065 100644 --- a/src/app/pages/client/ClientNonUIFeatures.tsx +++ b/src/app/pages/client/ClientNonUIFeatures.tsx @@ -7,7 +7,6 @@ import { getReactCustomHtmlParser, LINKIFY_OPTS } from '$plugins/react-custom-ht import { sanitizeCustomHtml } from '$utils/sanitize'; import { roomToUnreadAtom } from '$state/room/roomToUnread'; import LogoSVG from '$public/res/svg/cinny.svg'; -import { NotificationBanner } from '$components/notification-banner'; import LogoUnreadSVG from '$public/res/svg/cinny-unread.svg'; import LogoHighlightSVG from '$public/res/svg/cinny-highlight.svg'; import NotificationSound from '$public/sound/notification.ogg'; @@ -559,7 +558,6 @@ export function ClientNonUIFeatures({ children }: ClientNonUIFeaturesProps) { - {children} ); From 652c487544597e6d87f3c436bdf9d39be0dbabf9 Mon Sep 17 00:00:00 2001 From: Evie Gauthier Date: Mon, 9 Mar 2026 17:08:03 -0400 Subject: [PATCH 4/4] chore: fix changeset formatting (prettier) --- .changeset/fix-notification-banner.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/fix-notification-banner.md b/.changeset/fix-notification-banner.md index a3b7b19cb..b46793fbe 100644 --- a/.changeset/fix-notification-banner.md +++ b/.changeset/fix-notification-banner.md @@ -1,5 +1,5 @@ --- -"sable": patch +'sable': patch --- fix: in-app notification banner placement