From 16e2c5cf290a7be5a01d06e01bbef79d877dbfcf Mon Sep 17 00:00:00 2001 From: 7w1 Date: Wed, 25 Feb 2026 15:04:31 -0600 Subject: [PATCH] fix typing indicator index on mobile --- CHANGELOG.md | 5 +++ .../message/modals/GlobalModalManager.tsx | 2 +- .../typing-indicator/TypingIndicator.css.ts | 1 - .../typing-indicator/TypingIndicator.tsx | 6 +++- src/app/features/room/message/Message.tsx | 35 +++++++------------ 5 files changed, 24 insertions(+), 25 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 98708f62b..fd21c2b6b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Sable Client Changelog +## Version 1.1.5 + +- Various performance improvements. See commits for details. +- Fix typing indicator z index on mobile. + ## Version 1.1.4 - Various performance improvements diff --git a/src/app/components/message/modals/GlobalModalManager.tsx b/src/app/components/message/modals/GlobalModalManager.tsx index a58c9924a..e4a9c5871 100644 --- a/src/app/components/message/modals/GlobalModalManager.tsx +++ b/src/app/components/message/modals/GlobalModalManager.tsx @@ -1,6 +1,6 @@ import React from 'react'; import { useAtom } from 'jotai'; -import { Overlay, OverlayBackdrop, OverlayCenter, Modal, Box } from 'folds'; +import { Overlay, OverlayBackdrop, OverlayCenter, Box } from 'folds'; import FocusTrap from 'focus-trap-react'; import { MessageReportInternal } from './MessageReport'; import { MessageDeleteInternal } from './MessageDelete'; diff --git a/src/app/components/typing-indicator/TypingIndicator.css.ts b/src/app/components/typing-indicator/TypingIndicator.css.ts index 2cab59654..662fe0556 100644 --- a/src/app/components/typing-indicator/TypingIndicator.css.ts +++ b/src/app/components/typing-indicator/TypingIndicator.css.ts @@ -16,7 +16,6 @@ export const TypingDot = recipe({ display: 'inline-block', backgroundColor: 'currentColor', borderRadius: '50%', - zIndex: 10, transform: 'translateY(15%)', }, ], diff --git a/src/app/components/typing-indicator/TypingIndicator.tsx b/src/app/components/typing-indicator/TypingIndicator.tsx index f8daa45e5..ccb9e43f8 100644 --- a/src/app/components/typing-indicator/TypingIndicator.tsx +++ b/src/app/components/typing-indicator/TypingIndicator.tsx @@ -13,7 +13,11 @@ export const TypingIndicator = as<'div', TypingIndicatorProps>( as="span" alignItems="Center" shrink="No" - style={{ gap: toRem(size === '300' ? 1 : 2), ...style }} + style={{ + gap: toRem(size === '300' ? 1 : 2), + zIndex: 10, + ...style + }} {...props} ref={ref} > diff --git a/src/app/features/room/message/Message.tsx b/src/app/features/room/message/Message.tsx index a33d872a2..23cd6c9b0 100644 --- a/src/app/features/room/message/Message.tsx +++ b/src/app/features/room/message/Message.tsx @@ -1,30 +1,19 @@ import { Avatar, Box, - Button, - Dialog, - Header, Icon, IconButton, Icons, - Input, Line, Menu, MenuItem, - Modal, - Overlay, - OverlayBackdrop, - OverlayCenter, PopOut, RectCords, - Spinner, Text, as, - color, config, } from 'folds'; import React, { - FormEventHandler, MouseEventHandler, ReactNode, useCallback, @@ -38,7 +27,6 @@ import { useHover, useFocusWithin } from 'react-aria'; import { MatrixEvent, Room } from 'matrix-js-sdk'; import { Relations } from 'matrix-js-sdk/lib/models/relations'; import classNames from 'classnames'; -import parse from 'html-react-parser'; import { useAtomValue, useSetAtom } from 'jotai'; import { RoomPinnedEventsEventContent } from 'matrix-js-sdk/lib/types'; import { @@ -53,13 +41,10 @@ import { } from '../../../components/message'; import { canEditEvent, - getEventEdits, getMemberAvatarMxc, - getMemberDisplayName, } from '../../../utils/room'; import { getCanonicalAliasOrRoomId, - getMxIdLocalPart, isRoomAlias, mxcUrlToHttp, } from '../../../utils/matrix'; @@ -68,11 +53,7 @@ import { nicknamesAtom, setNicknameAtom } from '../../../state/nicknames'; import { useMatrixClient } from '../../../hooks/useMatrixClient'; import { useRecentEmoji } from '../../../hooks/useRecentEmoji'; import * as css from './styles.css'; -import { EventReaders } from '../../../components/event-readers'; -import { TextViewer } from '../../../components/text-viewer'; -import { AsyncStatus, useAsyncCallback } from '../../../hooks/useAsyncCallback'; import { EmojiBoard } from '../../../components/emoji-board'; -import { ReactionViewer } from '../reaction-viewer'; import { MessageEditor } from './MessageEditor'; import { UserAvatar } from '../../../components/user-avatar'; import { copyToClipboard } from '../../../utils/dom'; @@ -462,8 +443,10 @@ function MessageInternal( return mEvent.getContent().body || ''; }, [mEvent]); + const MSG_CONTENT_STYLE = { maxWidth: '100%' }; + const msgContentJSX = ( - + {reply} {edit && onEditId ? ( = (evt) => { const target = evt.currentTarget.parentElement?.parentElement ?? evt.currentTarget; - setMenuAnchor(target.getBoundingClientRect()); + const rect = target.getBoundingClientRect(); + + window.requestAnimationFrame(() => { + setMenuAnchor(rect); + }); }; const closeMenu = () => { @@ -939,7 +926,11 @@ export const Event = as<'div', EventProps>( const handleOpenMenu: MouseEventHandler = (evt) => { const target = evt.currentTarget.parentElement?.parentElement ?? evt.currentTarget; - setMenuAnchor(target.getBoundingClientRect()); + const rect = target.getBoundingClientRect(); + + window.requestAnimationFrame(() => { + setMenuAnchor(rect); + }); }; const closeMenu = () => {