Inside the ThreadDrawer the user is already in thread context, so showing
the "Thread" badge in the reply chip is redundant and visually noisy.
The compose box always sets replyDraft.relation.rel_type = RelationType.Thread
when threadRootId is set (so the message goes to the right thread), but that
should not make the ThreadIndicator visible there.
Add !threadRootId guard to the ThreadIndicator render condition.
Adds 4 unit tests covering the four branches of the condition.
Covers the two bugs fixed in the previous commit:
- Verifies the first button gets data-selected="true" on initial render so the
CSS highlight rule fires immediately (regression for the dep-array fix).
- Verifies the first button is also stamped when async search results load new
buttons after the initial render (the original regression).
- Verifies keyboard navigation via the AUTOCOMPLETE_NAVIGATE_EVENT moves the
selected index and that it clamps at the list boundaries.
Also adds an eslint-disable comment in AutocompleteMenu.tsx explaining why
the no-dep-array useLayoutEffect is intentional (setSelectedIndex is a stable
React setter; the conditional call cannot cause an infinite loop).
Two related bugs in the mention/room/emoji autocomplete:
1. Enter key always inserted the first suggestion instead of the highlighted one.
Cause: querySelector('[data-selected]') matched ALL buttons since every button
has the attribute set to either 'true' or 'false'. The first button in DOM
order was always returned.
Fix: use '[data-selected="true"]' to select only the active item.
2. The first item had no visual highlight on initial open (the CSS rule requires
data-selected='true', but the useLayoutEffect responsible for stamping that
attribute only re-ran when selectedIndex changed -- not when buttons first
appeared after async search results loaded).
Fix: remove the dep array so the effect runs after every render; newly-loaded
buttons are stamped immediately.
- Extract scrubMatrixIds/scrubDataObject/scrubMatrixUrl from instrument.ts
into src/app/utils/sentryScrubbers.ts so they can be tested independently
- Add 43 unit tests covering token redaction, Matrix entity ID scrubbing,
URL path scrubbing (API + app routes + percent-encoded deep-links),
and scrubDataObject recursive traversal
- Add 12 RTL integration tests for TelemetryConsentBanner: visibility
gating (no DSN, pre-existing pref), Got it, dismiss, and Opt out flows
Outgoing links embedded in Matrix events (mention HTML, reply quotes)
must use https://matrix.to so other clients (Element, FluffyChat, etc.)
can parse them as Matrix permalinks. Custom base applies only to UI
navigation links (copy-to-clipboard buttons).
- matrix-to.ts: replace static hardcoded regexes with a lazily-built
cached set that matches both https://matrix.to (cross-client compat)
and the configured custom base URL (if matrixToBaseUrl is set in
config.json)
- editor/output.ts: Mention block now calls getMatrixToRoom /
getMatrixToRoomEvent instead of hardcoding the matrix.to base
- room.ts: parseReplyFormattedBody uses getMatrixToRoomEvent /
getMatrixToRoom for the same reason
The dot badge (8px circle) was positioned at top:-2px, left:-2px
which placed its CENTER 2px inside the avatar corner rather than
on the corner itself. Changed to top:-4px, left:-4px so the dot
is centered exactly on the top-left corner of the avatar, matching
how the count badge (top:-6px for ~12px height) is positioned.
Also updated the folder compound variant dot position from +2px to 0px
for consistency.
Fixes#293
The old code used IntersectionObserver anchors to determine whether scroll
arrows should be shown. This caused false positives in two scenarios:
1. When a UrlPreviewCard renders null (fetch error), the empty anchor div
was sometimes not detected as intersecting, leaving a stale arrow visible.
2. When loading (Spinner makes card 400px wide), the IO would mark the front
anchor as not visible, showing the arrow; after load failure the arrow
stayed stuck.
Replace with direct scrollWidth/clientWidth measurement via ResizeObserver
(fires on container and content resize) plus a scroll event listener. Arrows
now only appear when the horizontal scroll area actually has overflowed content.
Fixes#220