From 1be51b340732e23a09be7a03a2e4a7ef81edc1a4 Mon Sep 17 00:00:00 2001 From: mini-bomba <55105495+mini-bomba@users.noreply.github.com> Date: Fri, 6 Mar 2026 22:25:54 +0100 Subject: [PATCH 1/2] fix(commands): /myroomnick without new nick resets nick --- .changeset/pr207-myroomnick-unset.md | 5 +++++ src/app/hooks/useCommands.ts | 8 +++++--- 2 files changed, 10 insertions(+), 3 deletions(-) create mode 100644 .changeset/pr207-myroomnick-unset.md diff --git a/.changeset/pr207-myroomnick-unset.md b/.changeset/pr207-myroomnick-unset.md new file mode 100644 index 00000000..66b67053 --- /dev/null +++ b/.changeset/pr207-myroomnick-unset.md @@ -0,0 +1,5 @@ +--- +sable: patch +--- + +Executing /myroomnick without a new nickname now removes the nickname. diff --git a/src/app/hooks/useCommands.ts b/src/app/hooks/useCommands.ts index de830354..eae38cbb 100644 --- a/src/app/hooks/useCommands.ts +++ b/src/app/hooks/useCommands.ts @@ -33,6 +33,7 @@ import { createRoomEncryptionState } from '$components/create-room'; import { parsePronounsInput } from '$utils/pronouns'; import { useRoomNavigate } from './useRoomNavigate'; import { enrichWidgetUrl } from './useRoomWidgets'; +import { useUserProfile } from './useUserProfile'; export const SHRUG = '¯\\_(ツ)_/¯'; export const TABLEFLIP = '(╯°□°)╯︵ ┻━┻'; @@ -253,6 +254,7 @@ export type CommandRecord = Record; export const useCommands = (mx: MatrixClient, room: Room): CommandRecord => { const { navigateRoom } = useRoomNavigate(); const [developerTools] = useSetting(settingsAtom, 'developerTools'); + const profile = useUserProfile(mx.getSafeUserId()); const commands: CommandRecord = useMemo( () => ({ @@ -439,8 +441,8 @@ export const useCommands = (mx: MatrixClient, room: Room): CommandRecord => { name: Command.MyRoomNick, description: 'Change nick in current room.', exe: async (payload) => { - const nick = payload.trim(); - if (nick === '') return; + let nick: string | null = payload.trim(); + if (nick === '') nick = profile.displayName ?? null; const mEvent = room .getLiveTimeline() .getState(EventTimeline.FORWARDS) @@ -1288,7 +1290,7 @@ export const useCommands = (mx: MatrixClient, room: Room): CommandRecord => { }, }, }), - [mx, room, navigateRoom, developerTools] + [mx, navigateRoom, room, profile.displayName, profile.avatarUrl, developerTools] ); return commands; From 76faf7fb1768cb0f8d2569cd11eda89d83fa8d51 Mon Sep 17 00:00:00 2001 From: mini-bomba <55105495+mini-bomba@users.noreply.github.com> Date: Fri, 6 Mar 2026 23:19:15 +0100 Subject: [PATCH 2/2] fix(commands): do it for /myroomavatar as well --- .changeset/pr207-myroomnick-unset.md | 2 +- src/app/hooks/useCommands.ts | 38 ++++++++++++++++------------ 2 files changed, 23 insertions(+), 17 deletions(-) diff --git a/.changeset/pr207-myroomnick-unset.md b/.changeset/pr207-myroomnick-unset.md index 66b67053..76252010 100644 --- a/.changeset/pr207-myroomnick-unset.md +++ b/.changeset/pr207-myroomnick-unset.md @@ -2,4 +2,4 @@ sable: patch --- -Executing /myroomnick without a new nickname now removes the nickname. +Executing /myroomnick or /myroomavatar without a new nickname/avatar now removes the nickname/avatar. diff --git a/src/app/hooks/useCommands.ts b/src/app/hooks/useCommands.ts index eae38cbb..fb171874 100644 --- a/src/app/hooks/useCommands.ts +++ b/src/app/hooks/useCommands.ts @@ -464,23 +464,29 @@ export const useCommands = (mx: MatrixClient, room: Room): CommandRecord => { name: Command.MyRoomAvatar, description: 'Change profile picture in current room. Example /myroomavatar mxc://xyzabc', exe: async (payload) => { - if (payload.match(/^mxc:\/\/\S+$/)) { - const mEvent = room - .getLiveTimeline() - .getState(EventTimeline.FORWARDS) - ?.getStateEvents(StateEvent.RoomMember, mx.getSafeUserId()); - const content = mEvent?.getContent(); - if (!content) return; - await mx.sendStateEvent( - room.roomId, - StateEvent.RoomMember as any, - { - ...content, - avatar_url: payload, - }, - mx.getSafeUserId() - ); + let newAvatar: string | undefined = payload.trim(); + if (newAvatar.length === 0) { + // no avatar, reset to global + newAvatar = profile.avatarUrl; + } else if (!newAvatar.match(/^mxc:\/\/\S+$/)) { + // bad mxc + return; } + const mEvent = room + .getLiveTimeline() + .getState(EventTimeline.FORWARDS) + ?.getStateEvents(StateEvent.RoomMember, mx.getSafeUserId()); + const content = mEvent?.getContent(); + if (!content) return; + await mx.sendStateEvent( + room.roomId, + StateEvent.RoomMember as any, + { + ...content, + avatar_url: newAvatar, + }, + mx.getSafeUserId() + ); }, }, [Command.ConvertToDm]: {