From 970ad46fc64941e04a8ebbc1c30254e91dc98a96 Mon Sep 17 00:00:00 2001 From: Evie Gauthier Date: Sat, 21 Mar 2026 20:19:07 -0400 Subject: [PATCH] fix: prevent multi-device settings sync echo loop --- src/app/hooks/useSettingsSync.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/app/hooks/useSettingsSync.ts b/src/app/hooks/useSettingsSync.ts index afbf4f44..3e5c128a 100644 --- a/src/app/hooks/useSettingsSync.ts +++ b/src/app/hooks/useSettingsSync.ts @@ -46,7 +46,9 @@ export function useSettingsSyncEffect(): void { if (!event) return; const merged = deserializeFromSync(event.getContent(), settingsRef.current); if (merged) { - setSettings(merged); + if (JSON.stringify(merged) !== JSON.stringify(settingsRef.current)) { + setSettings(merged); + } setLastSynced(Date.now()); } }, [mx, syncEnabled, setSettings, setLastSynced]); @@ -72,10 +74,12 @@ export function useSettingsSyncEffect(): void { return; } - // Otherwise it came from another device — apply it. + // Otherwise it came from another device — apply it only if values changed. const merged = deserializeFromSync(content, settingsRef.current); if (merged) { - setSettings(merged); + if (JSON.stringify(merged) !== JSON.stringify(settingsRef.current)) { + setSettings(merged); + } setLastSynced(Date.now()); } },