From 79e4e0943608425192e114786270f4f5bd0bfeb2 Mon Sep 17 00:00:00 2001 From: Evie Gauthier Date: Fri, 13 Mar 2026 22:17:13 -0400 Subject: [PATCH] fix(lint): resolve react-hooks/exhaustive-deps, arrow-body-style, and no-plusplus errors --- src/app/features/room/RoomTimeline.tsx | 5 +++-- src/app/pages/client/BackgroundNotifications.tsx | 5 +++-- src/client/initMatrix.ts | 5 ++--- src/client/slidingSync.ts | 2 +- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/app/features/room/RoomTimeline.tsx b/src/app/features/room/RoomTimeline.tsx index 02c62fec..ee59ec62 100644 --- a/src/app/features/room/RoomTimeline.tsx +++ b/src/app/features/room/RoomTimeline.tsx @@ -717,7 +717,8 @@ export function RoomTimeline({ return () => { debugLog.info('timeline', 'Timeline unmounted', { roomId: room.roomId }); }; - }, [room.roomId, eventId]); // Only log on mount/unmount + // eslint-disable-next-line react-hooks/exhaustive-deps + }, [room.roomId, eventId]); // Only log on mount/unmount - intentionally capturing initial values // Log live timeline linking state changes useEffect(() => { @@ -806,7 +807,7 @@ export function RoomTimeline({ setTimeline(getInitialTimeline(room)); scrollToBottomRef.current.count += 1; scrollToBottomRef.current.smooth = false; - }, [alive, room]) + }, [alive, room, room.roomId]) ); useLiveEventArrive( diff --git a/src/app/pages/client/BackgroundNotifications.tsx b/src/app/pages/client/BackgroundNotifications.tsx index fb3848b4..2765613b 100644 --- a/src/app/pages/client/BackgroundNotifications.tsx +++ b/src/app/pages/client/BackgroundNotifications.tsx @@ -535,9 +535,10 @@ export function BackgroundNotifications() { }); return () => { + const cleanupMap = clientCleanupRef.current; current.forEach((mx, userId) => { - clientCleanupRef.current.get(userId)?.(); - clientCleanupRef.current.delete(userId); + cleanupMap.get(userId)?.(); + cleanupMap.delete(userId); stopClient(mx); }); current.clear(); diff --git a/src/client/initMatrix.ts b/src/client/initMatrix.ts index e8c70f16..71bbc316 100644 --- a/src/client/initMatrix.ts +++ b/src/client/initMatrix.ts @@ -354,9 +354,8 @@ const disposeSlidingSync = (mx: MatrixClient): void => { slidingSyncByClient.delete(mx); }; -export const getSlidingSyncManager = (mx: MatrixClient): SlidingSyncManager | undefined => { - return slidingSyncByClient.get(mx); -}; +export const getSlidingSyncManager = (mx: MatrixClient): SlidingSyncManager | undefined => + slidingSyncByClient.get(mx); export const startClient = async (mx: MatrixClient, config?: StartClientConfig): Promise => { debugLog.info('sync', 'Starting Matrix client', { userId: mx.getUserId() }); diff --git a/src/client/slidingSync.ts b/src/client/slidingSync.ts index b979f225..7cd01cab 100644 --- a/src/client/slidingSync.ts +++ b/src/client/slidingSync.ts @@ -368,7 +368,7 @@ export class SlidingSyncManager { this.onLifecycle = (state, resp, err) => { const syncStartTime = performance.now(); - this.syncCount++; + this.syncCount += 1; debugLog.info('sync', `Sliding sync lifecycle: ${state} (cycle #${this.syncCount})`, { state,