From 150acb9bbf58d4ffaeec2d7cc0c8dd7482ebc0e6 Mon Sep 17 00:00:00 2001 From: hazre Date: Sun, 1 Mar 2026 14:08:47 +0100 Subject: [PATCH] chore(lint): tighten unused vars rule updated the TypeScript no-unused-vars configuration and dropped now-unused imports across several components --- eslint.config.js | 12 +++++++++++- src/app/components/editor/output.ts | 2 +- src/app/components/image-viewer/ImageViewer.tsx | 2 +- src/app/components/url-preview/UrlPreviewCard.tsx | 3 --- src/app/features/room-settings/RoomSettings.tsx | 1 - src/app/features/room/RoomInput.tsx | 7 ------- src/app/features/room/RoomTimeline.tsx | 6 +----- src/app/features/room/message/Message.tsx | 4 ---- src/app/hooks/useCommands.ts | 2 -- src/app/hooks/useNickname.ts | 2 +- src/app/pages/client/BackgroundNotifications.tsx | 1 - src/app/pages/client/space/Space.tsx | 1 - 12 files changed, 15 insertions(+), 28 deletions(-) diff --git a/eslint.config.js b/eslint.config.js index 24512eba..a609a3ac 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -90,7 +90,17 @@ const projectOverrides = defineConfig([ name: 'project/typescript-legacy-rule-overrides', files: tsFiles, rules: { - '@typescript-eslint/no-unused-vars': 'error', + '@typescript-eslint/no-unused-vars': [ + 'error', + { + args: 'after-used', + enableAutofixRemoval: { + imports: true, + }, + ignoreRestSiblings: true, + vars: 'all', + }, + ], '@typescript-eslint/no-shadow': 'error', 'no-undef': 'off', }, diff --git a/src/app/components/editor/output.ts b/src/app/components/editor/output.ts index a63d803a..49302991 100644 --- a/src/app/components/editor/output.ts +++ b/src/app/components/editor/output.ts @@ -9,7 +9,7 @@ import { } from '$plugins/markdown'; import { findAndReplace } from '$appUtils/findAndReplace'; import { sanitizeForRegex } from '$appUtils/regex'; -import { getCanonicalAliasOrRoomId, isUserId } from '$appUtils/matrix'; +import { isUserId } from '$appUtils/matrix'; import { CustomElement } from './slate'; import { BlockType } from './types'; diff --git a/src/app/components/image-viewer/ImageViewer.tsx b/src/app/components/image-viewer/ImageViewer.tsx index 33361d16..bb24fd3a 100644 --- a/src/app/components/image-viewer/ImageViewer.tsx +++ b/src/app/components/image-viewer/ImageViewer.tsx @@ -1,4 +1,4 @@ -import React, { useEffect } from 'react'; +import React from 'react'; import FileSaver from 'file-saver'; import classNames from 'classnames'; import { Box, Chip, Header, Icon, IconButton, Icons, Text, as } from 'folds'; diff --git a/src/app/components/url-preview/UrlPreviewCard.tsx b/src/app/components/url-preview/UrlPreviewCard.tsx index cb2af9ac..b0a76685 100644 --- a/src/app/components/url-preview/UrlPreviewCard.tsx +++ b/src/app/components/url-preview/UrlPreviewCard.tsx @@ -11,9 +11,6 @@ import { mxcUrlToHttp } from '$appUtils/matrix'; import { useMediaAuthentication } from '$hooks/useMediaAuthentication'; import * as css from './UrlPreviewCard.css'; import { UrlPreview, UrlPreviewContent, UrlPreviewDescription, UrlPreviewImg } from './UrlPreview'; -import { ImageViewer } from '../image-viewer'; -import { Image, Video } from '../media'; -import { ImageContent, VideoContent } from '../message'; const linkStyles = { color: color.Success.Main }; const TARGET_HEIGHT = 300; diff --git a/src/app/features/room-settings/RoomSettings.tsx b/src/app/features/room-settings/RoomSettings.tsx index ff21ca62..9b54a1a2 100644 --- a/src/app/features/room-settings/RoomSettings.tsx +++ b/src/app/features/room-settings/RoomSettings.tsx @@ -12,7 +12,6 @@ import { mDirectAtom } from '$state/mDirectList'; import { RoomAvatar, RoomIcon } from '$components/room-avatar'; import { RoomSettingsPage } from '$state/roomSettings'; import { useRoom } from '$hooks/useRoom'; -import { SwipeableChatWrapper } from '$components/SwipeableChatWrapper'; import { SwipeableOverlayWrapper } from '$components/SwipeableOverlayWrapper'; import { General } from './general'; import { Members } from '../common-settings/members'; diff --git a/src/app/features/room/RoomInput.tsx b/src/app/features/room/RoomInput.tsx index c91b7e34..1c613eff 100644 --- a/src/app/features/room/RoomInput.tsx +++ b/src/app/features/room/RoomInput.tsx @@ -109,13 +109,6 @@ import { roomToParentsAtom } from '$state/room/roomToParents'; import { nicknamesAtom } from '$state/nicknames'; import { useMediaAuthentication } from '$hooks/useMediaAuthentication'; import { useImagePackRooms } from '$hooks/useImagePackRooms'; -import { usePowerLevelsContext } from '$hooks/usePowerLevels'; -import { useIsDirectRoom } from '$hooks/useRoom'; -import { useAccessiblePowerTagColors, useGetMemberPowerTag } from '$hooks/useMemberPowerTag'; -import { useRoomCreators } from '$hooks/useRoomCreators'; -import { useTheme } from '$hooks/useTheme'; -import { useRoomCreatorsTag } from '$hooks/useRoomCreatorsTag'; -import { usePowerLevelTags } from '$hooks/usePowerLevelTags'; import { useComposingCheck } from '$hooks/useComposingCheck'; import { useSableCosmetics } from '$hooks/useSableCosmetics'; import { CommandAutocomplete } from './CommandAutocomplete'; diff --git a/src/app/features/room/RoomTimeline.tsx b/src/app/features/room/RoomTimeline.tsx index 50bbd3db..cc679e45 100644 --- a/src/app/features/room/RoomTimeline.tsx +++ b/src/app/features/room/RoomTimeline.tsx @@ -116,15 +116,11 @@ import { useRoomNavigate } from '$hooks/useRoomNavigate'; import { useMediaAuthentication } from '$hooks/useMediaAuthentication'; import { useIgnoredUsers } from '$hooks/useIgnoredUsers'; import { useImagePackRooms } from '$hooks/useImagePackRooms'; -import { useIsDirectRoom } from '$hooks/useRoom'; import { useOpenUserRoomProfile } from '$state/hooks/userRoomProfile'; import { useSpaceOptionally } from '$hooks/useSpace'; import { useRoomCreators } from '$hooks/useRoomCreators'; import { useRoomPermissions } from '$hooks/useRoomPermissions'; -import { useAccessiblePowerTagColors, useGetMemberPowerTag } from '$hooks/useMemberPowerTag'; -import { useTheme } from '$hooks/useTheme'; -import { useRoomCreatorsTag } from '$hooks/useRoomCreatorsTag'; -import { usePowerLevelTags } from '$hooks/usePowerLevelTags'; +import { useGetMemberPowerTag } from '$hooks/useMemberPowerTag'; import { profilesCacheAtom } from '$state/userRoomProfile'; import * as css from './RoomTimeline.css'; import { EncryptedContent, Event, Message, Reactions } from './message'; diff --git a/src/app/features/room/message/Message.tsx b/src/app/features/room/message/Message.tsx index 0ed4eb76..e9fdfc04 100644 --- a/src/app/features/room/message/Message.tsx +++ b/src/app/features/room/message/Message.tsx @@ -44,9 +44,6 @@ import { MessageLayout, MessageSpacing, settingsAtom } from '$state/settings'; import { nicknamesAtom, setNicknameAtom } from '$state/nicknames'; import { useMatrixClient } from '$hooks/useMatrixClient'; import { useRecentEmoji } from '$hooks/useRecentEmoji'; -import { EventReaders } from '$components/event-readers'; -import { TextViewer } from '$components/text-viewer'; -import { AsyncStatus, useAsyncCallback } from '$hooks/useAsyncCallback'; import { EmojiBoard } from '$components/emoji-board'; import { UserAvatar } from '$components/user-avatar'; import { copyToClipboard } from '$appUtils/dom'; @@ -70,7 +67,6 @@ import { MessageSourceCodeItem } from '$components/message/modals/MessageSource' import { MessageDeleteItem } from '$components/message/modals/MessageDelete'; import { MessageReportItem } from '$components/message/modals/MessageReport'; import { MessageEditor } from './MessageEditor'; -import { ReactionViewer } from '../reaction-viewer'; import * as css from './styles.css'; export type ReactionHandler = (keyOrMxc: string, shortcode: string) => void; diff --git a/src/app/hooks/useCommands.ts b/src/app/hooks/useCommands.ts index 2a1f76e5..8a047949 100644 --- a/src/app/hooks/useCommands.ts +++ b/src/app/hooks/useCommands.ts @@ -3,7 +3,6 @@ import { EventTimeline, IContextResponse, MatrixClient, - MatrixEvent, Method, Preset, Room, @@ -13,7 +12,6 @@ import { } from '$types/matrix-sdk'; import { useMemo } from 'react'; import { Membership, StateEvent } from '$types/matrix/room'; -import { AccountDataEvent } from '$types/matrix/accountData'; import { addRoomIdToMDirect, getDMRoomFor, diff --git a/src/app/hooks/useNickname.ts b/src/app/hooks/useNickname.ts index 0f3d36d5..968cd17b 100644 --- a/src/app/hooks/useNickname.ts +++ b/src/app/hooks/useNickname.ts @@ -1,6 +1,6 @@ import { useAtomValue, useSetAtom } from 'jotai'; import { useCallback, useEffect } from 'react'; -import { ClientEvent, MatrixClient, MatrixEvent } from '$types/matrix-sdk'; +import { MatrixClient } from '$types/matrix-sdk'; import { AccountDataEvent } from '$types/matrix/accountData'; import { nicknamesAtom, setNicknameAtom } from '../state/nicknames'; import { useAccountDataCallback } from './useAccountDataCallback'; diff --git a/src/app/pages/client/BackgroundNotifications.tsx b/src/app/pages/client/BackgroundNotifications.tsx index e5210f04..8d87ce7d 100644 --- a/src/app/pages/client/BackgroundNotifications.tsx +++ b/src/app/pages/client/BackgroundNotifications.tsx @@ -10,7 +10,6 @@ import { PushProcessor, } from '$types/matrix-sdk'; import { useAtomValue, useSetAtom } from 'jotai'; -import { useNavigate } from 'react-router-dom'; import { sessionsAtom, activeSessionIdAtom, diff --git a/src/app/pages/client/space/Space.tsx b/src/app/pages/client/space/Space.tsx index 4de76a90..4f181c36 100644 --- a/src/app/pages/client/space/Space.tsx +++ b/src/app/pages/client/space/Space.tsx @@ -75,7 +75,6 @@ import { AsyncStatus, useAsyncCallback } from '$hooks/useAsyncCallback'; import { BreakWord } from '$styles/Text.css'; import { InviteUserPrompt } from '$components/invite-user-prompt'; import { CallNavStatus } from '$features/room-nav/RoomCallNavStatus'; -import { SwipeableChatWrapper } from '$components/SwipeableChatWrapper'; import { mobileOrTablet } from '$appUtils/user-agent'; import { useNavigate } from 'react-router-dom'; import { lastVisitedRoomIdAtom } from '$state/room/lastRoom';